• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Port of downstream fix by Markus Moser on live since 2022-09-21

Fix regression after disabled formfield reform

updated jqueryui to latest version

    • -323
    • +331
    ./www/resources/jquery/jquery-ui.js
    • -4
    • +4
    ./www/resources/jquery/jquery-ui.min.js
improved spelling

Provide a reference to the current object when configuring tinymce

Allow to completely override the imageSelectorDialog URL downstream

Introduce for richtext editors the concept of "preset"

A preset is an abstract set configurations designed to address a specific use case.

An example could be a preset for a "minimal" richtext editor, used in those forms where we want to limit the features a user should have access to. Other presets could address specific usages or applications.

Downstream developers can provide a set of ::richtext::$editor::preset::$preset procs, returning an options dict. This set of options will be merged other local configurations.

The same approach works in ad_forms and xowiki forms.

This also enables the use-case of switching to a different editor maintaining the existing application-specific configurations consistent.

  1. … 1 more file in changeset.
TinyMCE XoWiki formfield integration

We introduce a new richtext mixin richtext::tinymce, requiring the richtext-tinymce package, currently integrating TinyMCE editor 7.0.1.

This implementation has been tested with regular, repeat, compound and repeatedcompound fields.

Downstream implementations based on this formfield can customize the editor configuration further, e.g. provide custom plugins via the api parameters.

Add a richtext to the test formfields specifications

Move back richtext formfield implementations in form-field-procs

Moving to a different file may affect dependencies defined on form-field-procs that also expect the richtext editor to be loaded. As breaking changes are not desirable now, we revert this reform.

Cleanup leftover code from successful reform in December 2016

Since then, we have been long using dynamic repeat fields on production

Move the specific richtext-editor implementations into an own file

file richtext-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/richtext-procs.tcl
improved spelling

  1. … 3 more files in changeset.
Improved readability of configuration parameter "parameterSecret"

- Switched to camelCase for better readabilty and uniformity

- NaviServer configuration parameters are case insensitive, so no danger for backward compatibility

  1. … 5 more files in changeset.
Use a simpler approach to achieve the intended result, which does not rely on events

Keep comments on the server side

JS upstream updates

- Updated highcharts to 11.4.0 (when highcharts package is not installed)

- Updated jquery-3.6.3 to jquery-3.7.1.

- Bumped version number to 5.10.1b10

    • -10965
    • +0
    ./www/resources/jquery/jquery-3.6.4.js
    • -2
    • +0
    ./www/resources/jquery/jquery-3.6.4.min.js
    • -0
    • +10716
    ./www/resources/jquery/jquery-3.7.1.js
    • -0
    • +2
    ./www/resources/jquery/jquery-3.7.1.min.js
Ensure chat javascript is executed only when the chat itself is actually a part of the DOM

This may not be the case at the time of rendering, e.g. because the chat is rendered inside of a <template> tag and appended to the document at a later moment.

file jquery-3.7.1.js was initially added on branch oacs-5-10.

    • -0
    • +0
    ./www/resources/jquery/jquery-3.7.1.js
  1. … 2 more files in changeset.
file jquery-3.7.1.min.js was initially added on branch oacs-5-10.

    • -0
    • +0
    ./www/resources/jquery/jquery-3.7.1.min.js
  1. … 2 more files in changeset.
Fix variable name

Update italian localization

  1. … 4 more files in changeset.
Introduce server-side validation for HTML5 date and time formfields

A "formats" parameter can be specified on the formfields indicating one or more formats that we want to enforce. The syntax for any of such format is that of the Tcl clock command.

Default values have been set according to the expected behavior of each form field type.

Empty values are always considered valid. If a field is required, this will be enforced in its own validator.

Test behavior of HTML5 date and time formfields when invalid values are submitted

    • -0
    • +186
    ./tcl/test/xowiki-test-procs.tcl
removed code, which was commented out since ages.

Cleanup of external binaries: always use "util::which" to resolve binaries

    • -1
    • +3
    ./www/ckeditor-images/upload_image.tcl
  1. … 5 more files in changeset.
Fixed unreviewed commit, which might lead to hard-to-spot errors

The last change assumed that "nls_language" can be hard-wired to

contain most 5 characters. While this not backed by the OpenACS data

model, the standard (RFC 5646) explicitly states that there is no

upper limit on the size of language tags. The tree letter language

codes have been standard since 2001 (RFC 4646).

The change accepts now all defined locales. When the specified locale

is not enabled, it provides a log notice, when the locale is not

defined at all, it provides a warning and falls back to "en_US".

  1. … 2 more files in changeset.
Validate as a token also the default coming from _nls_language, ensure the resulting language key is at most 5 chars long (many thanks to Markus Moser for this)

improved bootstrap5 compatibility for personal notifications

This change improves the appearance of personal notifications

for bootstrap5. It still works with bootstrap3.

Many thanks to Sebastian Scheder for this contribution!

    • -11
    • +24
    ./tcl/personal-notification-procs.tcl
Close the connection to the EventSource before leaving the page

Some browsers such as current Firefox may complain otherwise

Many thanks to Sebastian Scheder