• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Make use of extended functionality of OrderedComposite->orderby

- Removed manual adding of mixin ::xo::OrderedComposite::IndexCompare

in "toc" includelet and in xowiki::TableWidget->create_from_form_fields

- xowiki::TableWidget->create_from_form_fields:

added type map to allow caller to specify, on which attributes e.g.

a numeric comparison should be used.

- bumped version number to 5.10.1d22

stick with integer for purely nsf-based checks in public code.

Added API call "CrClass ad_proc id_belongs_to_package"

The new API call is useful for checking input validity, i.e.

whether to provided revision_id or item_id belongs to the specified package.

bump version number of xowiki to 5.10.1d21

bump version number of xotcl-core to 5.10.1d5

  1. … 2 more files in changeset.
check parent_id more properly

prefer variable ::acs::rootdir over proc [acs_root_dir]

improve page contract

Revert port of downstream feature: the same check can be performed more flexibly via the condition=regexp and condition=match

Port of downstream feature: condition proc on the FormPage checking that a page name respects some regular expression

Fix typo

Make sure result is defined, small improvements

Port of old local modification: when mime type is text/plain, feed the content straight to the indexer, rather than render the file as HTML, then convert it again to text in the search indexer

prefer global variable over proc

  1. … 5 more files in changeset.
refine form.form and validation errors

provide (non-default) message keys for "form.form.page"

    • -6
    • +10
    ./resources/prototypes/form.form.page
align instance variable values of formfield "form" with "textarea" to make subclassing simpler

Fix provide language prefixes for pages in the test

Fix template case

add minimal check that page is from the current package

improve robustness on invalid input

reduce level of verboseness

fix bug: tcl clock format %e returns in current versions single digit values with leading whitespace, which are invalid values for the options field.

Since non of the date-component fields is supposed to contain leading (or trailing) white-space,

this is now trimmed.

added regression test for includelet includelet "child-resources"

    • -3
    • +98
    ./tcl/test/includelet-test-procs.tcl
added private function xowiki::test::require_form_page to ease regression testing

add test cases for three different toc styles

    • -52
    • +48
    ./tcl/test/includelet-test-procs.tcl
no need to sort already sorted sequence

This problem was introduced via the ns_strcoll support which is not sufficiently clever on numbers.

We should support for numerical sort when needed (which seems rare enough)

    • -13
    • +35
    ./tcl/test/includelet-test-procs.tcl
Test also that links rendered in the ToC point to an existing page

At least in the setup tested so far, links seem to contain the language prefix and would not be resolved correctly

Improve comment

add test file for includelt testing, that does not require the full webtest overhead

    • -0
    • +77
    ./tcl/test/includelet-test-procs.tcl
file includelet-test-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/includelet-test-procs.tcl
Extend the test for the case where all links should be expanded

This tests also exposes issued with the sorting