• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Chat reform:

- rework xotcl-core chat machinery to return its responses through JSON and include information about active users

- depend on xowiki instead of xotcl-core only

- exploit xowiki "Comet" server push implementation when the browser supports it

- reduce code duplication

- drop plain HTML chat

- reduce hardcoded styling

- minor cleanups

    • -0
    • +63
    ./www/ajax/chat-common.js
    • -37
    • +11
    ./www/ajax/scripted-streaming-chat.js
  1. … 17 more files in changeset.
improve spelling

  1. … 8 more files in changeset.
Whitespace changes

  1. … 6 more files in changeset.
Fix typos

  1. … 8 more files in changeset.
Fix variable name preventing validation_errors to be handled in www-save-attributes

Add ':' to formatting to uniform with the render method

Preliminary xowiki chat rework

- update javascript to comply with CSP (setInterval...)

- exploit template resource loading machinery to load javascripts

- remove code duplication

- remove inline styling

Unquote single quote from JSON before appending messages to chat

Remove leftover alert

Avoid javascript eval idiom as CSP will refuse to execute when unsafe-eval is disabled

This requires moving to a more approprate JSON parser... which is also pickier regarding single quotes, so I had to rework JSON encoding to please it.

  1. … 1 more file in changeset.
improve comments

  1. … 10 more files in changeset.
Whitespace changes

  1. … 6 more files in changeset.
Fix typos

  1. … 3 more files in changeset.
preserve orderby in child-resources (e.g. when clicking on the garbage can)

set style variable in every case

improve spelling

  1. … 1 more file in changeset.
improve spelling

  1. … 6 more files in changeset.
use proper method in xpath query to check attribute value

specify xpath query more

Fix parameter name in proc doc

use more of new testing infrastrucure, including acs::test::reply_has_status_code and acs::test::reply_contains, or acs::test::get_form

Fix @param names

  1. … 1 more file in changeset.
improve spelling

  1. … 2 more files in changeset.
move newly defined testing API (in OpenACS 5.10) to namespace acs::test

  1. … 8 more files in changeset.
Replace array idioms with dict idioms

Replace array idioms with dict idioms

Replace array idioms with dict idioms

Replace array idioms with dict idioms

Replace array idioms with dict idioms

move functions to acs-automated testing