• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
strengthen boolean variables in page contracts

  1. … 4 more files in changeset.
bumped version numbers to 5.10.1b1

  1. … 85 more files in changeset.
Prefer cached api

  1. … 1 more file in changeset.
Update uninstall callback:

- avoid convoluted idioms

- improve documentation

- use cross dbms api

Format code in a way to avoid false positives where a column name is taken as a deprecated proc

Cleanup deprecated api from test

Use UTF-8 emoji HTML entities instead of static images to convert smileys in the forums package

This has the advantage of not requiring a request to serve the images. It also avoids the need to hardcode the image size, as they will be basically treated as fonts.

Whitespace cleanup

Increase proc coverage, deprecate proc in the process

Test cornercase behavior

Make Service Contract implementations private

Deprecate forum::new_questions_allow and forum::new_questions_deny, one should use forum::edit, which will also track the change, or just inline the query instead

Deprecate forum::new_questions_allowed_p and replace occurrences

Increase proc coverage

Give priority to the information provided explicitly to the api (the forum_id) in order to determine the package id and fallback to the connection context only when this is not available

Enforce data type of hidden fields, add missing parameters to the page contract

avoid subst in export_vars when not necessary

  1. … 1 more file in changeset.
prefer adp:icon over old-style .gif images

  1. … 5 more files in changeset.
prefer adp:icon over old-style .gif and .png mages

  1. … 1 more file in changeset.
Reinstate the notnull validation constraint where missing

  1. … 10 more files in changeset.
re-add notnull value constraint on message_id

This constraint was removed about 14 days ago. Without this constraint,

errors like the following will show up....

[30/Aug/2022:14:07:29.820625][3102633.7f152c28d700][-conn:openacs.org:default:0:196214-] Error: rp_handler no-script-abort: errorMsg can't read "message(forum_id)": no such variable while serving GE

T /forums/message-view?message_id HTTP/1.1

: ad_url </forums/message-view> maps to file </var/www/openacs.org/packages/forums/www/message-view.adp>

: TCL LOOKUP VARNAME message

: can't read "message(forum_id)": no such variable

: while executing

: "forum::get -forum_id $message(forum_id) -array forum"

Probably, in many more cases, the incorrect removal of the notnull constrain performed by [1]

requires the same fix.

[1] https://github.com/openacs/forums/commit/c403e3134ce4e73ba94a80540a8b0f3cb1651ed0#diff-d35c736495ede0174fb39791ab660c5cd1a4ca467db2c4741cfc935167d7e5a8

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 33 more files in changeset.
forum_id is actually optional here

Harden page and include contracts using new acs-tcl feature

  1. … 21 more files in changeset.
harden page contract

passing properties consistently with @....;literal@

  1. … 12 more files in changeset.
passing properties consistently with @....;literal@

  1. … 43 more files in changeset.
passing properties consistently with @....;literal@ and not "noquote", since noquote content is already parsed

  1. … 14 more files in changeset.
add validation for message_id

add minimal permission check