OpenACS / openacs-4 / packages

forums

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 61
Last Commit: 14 Nov
Commits this week: 0
Total Lines of Code (LoC): 22,611
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 20 Mar 2023
3:15 pm

antoniop

Test cornercase behavior

Options
    • -2
    • +3
    ./tcl/test/forums-procs.tcl
2:58 pm

antoniop

Make Service Contract implementations private

Options
    • -5
    • +11
    ./tcl/forum-reply-procs.tcl
2:39 pm

antoniop

Deprecate forum::new_questions_allow and forum::new_questions_deny, one should use forum::edit, which will also track the change, or just inline the query instead

Options
    • -2
    • +6
    ./tcl/forums-callback-procs.tcl
    • -3
    • +11
    ./tcl/forums-procs.tcl
2:28 pm

antoniop

Deprecate forum::new_questions_allowed_p and replace occurrences

Options
    • -4
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +8
    ./tcl/forums-procs.tcl
    • -5
    • +1
    ./tcl/test/forums-procs.tcl
2:17 pm

antoniop

Increase proc coverage

Options
    • -9
    • +44
    ./tcl/test/forums-procs.tcl
Friday 24 Feb 2023
2:19 pm

antoniop

Give priority to the information provided explicitly to the api (the forum_id) in order to determine the package id and fallback to the connection context only when this is not available

Options
    • -12
    • +37
    ./tcl/forums-procs.tcl
Thursday 23 Feb 2023
5:12 pm

antoniop

Enforce data type of hidden fields, add missing parameters to the page contract

Options
    • -3
    • +6
    ./lib/message/post.tcl
Tuesday 08 Nov 2022
3:19 pm

gustafn

avoid subst in export_vars when not necessary

Options
    • -2
    • +3
    ./www/forum-view.tcl
  2. … 1 more file in changeset.
Friday 21 Oct 2022
10:52 am

gustafn

prefer adp:icon over old-style .gif images

Options
    • -1
    • +1
    ./lib/message/row.adp
  2. … 5 more files in changeset.
10:40 am

gustafn

prefer adp:icon over old-style .gif and .png mages

Options
    • -3
    • +3
    ./lib/message/attachment-list.adp
    • -4
    • +4
    ./lib/message/attachment-list.tcl
  3. … 1 more file in changeset.
Tuesday 30 Aug 2022
3:08 pm

antoniop

Reinstate the notnull validation constraint where missing

Options
    • -2
    • +2
    ./lib/message/post.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +2
    ./lib/user/post-history-chunk.tcl
    • -1
    • +1
    ./www/forum-view-statistic.tcl
    • -2
    • +2
    ./www/forum-view.tcl
    • -1
    • +1
    ./www/load-message-content.tcl
    • -1
    • +1
    ./www/mark-all-read.tcl
    • -2
    • +2
    ./www/message-email.tcl
    • -2
    • +2
    ./www/user-history.tcl
    • -2
    • +2
    ./www/admin/forum-disable.tcl
    • -2
    • +2
    ./www/admin/forum-edit.tcl
    • -2
    • +2
    ./www/admin/forum-enable.tcl
    • -2
    • +2
    ./www/admin/permissions-user-add.tcl
    • -5
    • +5
    ./www/admin/subscribe-others-2.tcl
    • -2
    • +2
    ./www/admin/subscribe-others.tcl
  16. … 10 more files in changeset.
2:22 pm

gustafn

re-add notnull value constraint on message_id

This constraint was removed about 14 days ago. Without this constraint,

errors like the following will show up....

[30/Aug/2022:14:07:29.820625][3102633.7f152c28d700][-conn:openacs.org:default:0:196214-] Error: rp_handler no-script-abort: errorMsg can't read "message(forum_id)": no such variable while serving GE

T /forums/message-view?message_id HTTP/1.1

: ad_url </forums/message-view> maps to file </var/www/openacs.org/packages/forums/www/message-view.adp>

: TCL LOOKUP VARNAME message

: can't read "message(forum_id)": no such variable

: while executing

: "forum::get -forum_id $message(forum_id) -array forum"

Probably, in many more cases, the incorrect removal of the notnull constrain performed by [1]

requires the same fix.

[1] https://github.com/openacs/forums/commit/c403e3134ce4e73ba94a80540a8b0f3cb1651ed0#diff-d35c736495ede0174fb39791ab660c5cd1a4ca467db2c4741cfc935167d7e5a8

Options
    • -2
    • +2
    ./www/message-view.tcl
Monday 29 Aug 2022
4:17 pm

antoniop

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

Options
    • -2
    • +2
    ./lib/forums/admin-forums-chunk.tcl
  2. … 33 more files in changeset.
Tuesday 23 Aug 2022
5:35 pm

antoniop

forum_id is actually optional here

Options
    • -2
    • +2
    ./lib/search/search-form.tcl
Friday 15 Jul 2022
6:19 pm

antoniop

Harden page and include contracts using new acs-tcl feature

Options
    • -3
    • +3
    ./forums.info
    • -1
    • +1
    ./lib/forums-portlet.tcl
    • -6
    • +4
    ./lib/forums/new.tcl
    • -3
    • +3
    ./lib/message/post.tcl
    • -2
    • +2
    ./lib/message/row.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +2
    ./lib/search/search-form.tcl
    • -2
    • +2
    ./lib/user/post-history-chunk.tcl
    • -1
    • +1
    ./www/forum-view-statistic.tcl
    • -15
    • +6
    ./www/forum-view.tcl
    • -5
    • +1
    ./www/load-message-content.tcl
    • -1
    • +1
    ./www/mark-all-read.tcl
    • -10
    • +4
    ./www/message-email.tcl
    • -12
    • +7
    ./www/message-post.tcl
    • -10
    • +4
    ./www/message-view.tcl
  16. … 21 more files in changeset.
Thursday 28 Apr 2022
5:06 pm

trenner

harden page contract

Options
    • -3
    • +3
    ./lib/message/post.tcl
Wednesday 27 Apr 2022
6:41 pm

gustafn

passing properties consistently with @....;literal@

Options
    • -1
    • +1
    ./www/message-email.adp
  2. … 12 more files in changeset.
6:30 pm

gustafn

passing properties consistently with @....;literal@

Options
    • -1
    • +1
    ./www/forum-view-statistic.adp
    • -1
    • +1
    ./www/message-email.adp
    • -1
    • +1
    ./www/message-post-confirm.adp
    • -1
    • +1
    ./www/message-post.adp
    • -1
    • +1
    ./www/admin/forum-edit.adp
    • -1
    • +1
    ./www/admin/subscribe-others.adp
    • -1
    • +1
    ./www/moderate/forum.adp
    • -1
    • +1
    ./www/moderate/message-delete.adp
    • -1
    • +1
    ./www/moderate/message-edit.adp
    • -1
    • +1
    ./www/moderate/message-move.adp
    • -1
    • +1
    ./www/moderate/thread-move-thread.adp
  12. … 43 more files in changeset.
2:22 pm

gustafn

passing properties consistently with @....;literal@ and not "noquote", since noquote content is already parsed

Options
    • -1
    • +1
    ./www/moderate/move-thread.adp
  2. … 14 more files in changeset.
Tuesday 12 Apr 2022
2:27 pm

trenner

add validation for message_id

Options
    • -2
    • +10
    ./www/message-email.tcl
2:14 pm

trenner

add minimal permission check

Options
    • -0
    • +1
    ./www/messages-get.tcl
Monday 11 Apr 2022
8:27 pm

gustafn

remove "verify" from page contrace, since variables are NOT signed

hardened page contract

Options
    • -13
    • +13
    ./lib/message/post.tcl
Thursday 31 Mar 2022
6:33 pm

antoniop

Replace the lame template::util::get_opts with some homemade utility that will parse arguments reliably, adjust the one upstream use case where arguments other than those documented might be passed to the element creation, introduce a warning when this happens somewhere else

Options
    • -5
    • +4
    ./tcl/form-procs.tcl
  2. … 1 more file in changeset.
Tuesday 15 Mar 2022
2:00 pm

trenner

harden page contract

Options
    • -4
    • +4
    ./lib/message/post.tcl
1:29 pm

trenner

harden page contract

Options
    • -2
    • +2
    ./www/user-history.tcl
Saturday 12 Feb 2022
9:11 pm

gustafn

improving Oracle upgrade scripts

Oracle has no "ALTER TABLE ADD COLUMN ...."

Oracle has no "ALTER TABLE ADD COLUMN if exists .."

Options
    • -1
    • +1
    ./sql/oracle/upgrade/upgrade-1.3-1.3d1.sql
    • -1
    • +1
    ./sql/oracle/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
  3. … 7 more files in changeset.
Tuesday 25 Jan 2022
5:47 pm

antoniop

Do the transaction only if necessary

Options
    • -4
    • +6
    ./lib/message/post.tcl
5:44 pm

antoniop

Break overlong lines

Options
    • -2
    • +16
    ./lib/message/post.tcl
Monday 03 Jan 2022
1:58 pm

antoniop

Replace reference to long-missing message key

Options
    • -3
    • +3
    ./tcl/messages-procs.tcl
Wednesday 29 Dec 2021
5:56 pm

antoniop

Trap the attempt to retrieve a non-existing forum and return a 404 in this case

this might need to happen in other places and/or be refined

Options
    • -2
    • +7
    ./www/admin/forum-edit.tcl