OpenACS / openacs-4 / packages / file-storage / tcl / test

file-storage-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 26 Apr
Commits this week: 0
Total Lines of Code (LoC): 297
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 26 Feb
4:05 pm

antoniop

download-archive reform

File-Storage used to generate downloaded archives in tgz format, to then switch to zip, more user-friendly, in particular outside the Linux world (See https://openacs.org/forums/message-view?message_id=557561). To ease the transition, a couple of parameters and relative API were introduced that would allow to choose the preferred command one should use. During this reform however, default parameter values in the tcl code became inconsistent with those in the info file. Furthermore, the chosen defaults were set as absolute paths to the executable, which is not friendly to non-linux environments, or other scenarios where the "typical" Linux filesystem structure cannot be assumed (e.g. containers, MacOS...).

The only usage of this parameters/api was in fact in the download-archive vuh. In upstream codebase, no package references this file, not even the file-storage itself. Upon review, one could see that the file would also allow to specify a custom download filename via the path, which could be considered questionable. It would also execute the command in a way that once again assumes some form of Linux environment (e.g. invoking bash).

Save for the ability to customize the archive format and the anti-feature of being able to manipulate the archive filename via the path, the script largely relplicates www/download-zip, in a better shape after a few reforms hinted by e.g. penetration tools.

Given the aformentioned considerations, I have decided to make download-archive a simple redirect to download-zip. Specifying the object_id via the path will keep working, while URLs out there expecting the name to change will not fail, but the name will not be modified. The archive format will from now on be assumed to be zip.

Options
    • -47
    • +1
    ./file-storage-procs.tcl
  2. … 4 more files in changeset.
Thursday 20 Apr 2023
4:47 pm

antoniop

Test external command dependency for the package

Options
    • -1
    • +25
    ./file-storage-procs.tcl
Friday 17 Mar 2023
3:43 pm

antoniop

Complete api coverage for the package

Options
    • -1
    • +21
    ./file-storage-procs.tcl
3:36 pm

antoniop

Cover remaining export api

Options
    • -15
    • +129
    ./file-storage-procs.tcl
2:25 pm

antoniop

Prevent usage of fs::get_archive_command outside a file-storage connection context, as in this case the parameter value will be uspecified

Options
    • -3
    • +17
    ./file-storage-procs.tcl
  2. … 1 more file in changeset.
Thursday 16 Mar 2023
3:49 pm

antoniop

Increase proc coverage

Options
    • -1
    • +33
    ./file-storage-procs.tcl
Friday 24 Feb 2023
5:29 pm

antoniop

Declare api as tested

Options
    • -1
    • +2
    ./file-storage-procs.tcl
5:18 pm

antoniop

Increase proc coverage

Options
    • -1
    • +169
    ./file-storage-procs.tcl
Sunday 27 Nov 2022
11:52 am

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -5
    • +3
    ./file-storage-procs.tcl
  2. … 6 more files in changeset.
Friday 09 Sep 2022
3:03 pm

antoniop

Deprecate twt::user::create and twt::user::delete, superseded by their acs::test::user:: counterparts

Options
    • -5
    • +5
    ./file-storage-procs.tcl
  2. … 11 more files in changeset.
Wednesday 24 Aug 2022
10:58 am

antoniop

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.

Options
    • -1
    • +121
    ./file-storage-procs.tcl
  2. … 2 more files in changeset.
Sunday 26 Jun 2022
9:28 pm

gustafn

acs::test::user::delete: added flag -delete_created_acs_objects and fix regression test for file-storage

Options
    • -3
    • +4
    ./file-storage-procs.tcl
  2. … 5 more files in changeset.
Thursday 09 Sep 2021
3:48 pm

antoniop

Fix typo, increase api coverage

Options
    • -1
    • +5
    ./file-storage-procs.tcl
  2. … 1 more file in changeset.
Wednesday 21 Apr 2021
1:03 pm

antoniop

Fix test category, add tested api

Options
    • -2
    • +3
    ./file-storage-procs.tcl
Tuesday 20 Apr 2021
1:42 pm

antoniop

Fix typo, write a basic test for the involved api

Options
    • -1
    • +43
    ./file-storage-procs.tcl
  2. … 1 more file in changeset.
Tuesday 13 Apr 2021
6:37 pm

gustafn

perform proper cleanup after the test

Options
    • -22
    • +40
    ./file-storage-procs.tcl
5:30 pm

hectorr

Avoid rollback in web tests

Options
    • -5
    • +5
    ./file-storage-procs.tcl
5:08 pm

hectorr

Avoid rollback in 'fs_add_file_to_folder' test in particular

Options
    • -3
    • +3
    ./file-storage-procs.tcl
1:17 pm

hectorr

Rollback after tests

Options
    • -6
    • +6
    ./file-storage-procs.tcl
Wednesday 31 Mar 2021
1:31 pm

gustafn

whitespace changes

Options
    • -2
    • +2
    ./file-storage-procs.tcl
  2. … 2 more files in changeset.
1:30 pm

gustafn

extend regression test, add covered procs to webtest

Options
    • -1
    • +24
    ./file-storage-procs.tcl
  2. … 2 more files in changeset.
11:15 am

hectorr

Remove bogus proc name. Fixes 'naming__proc_naming' test case

Options
    • -4
    • +3
    ./file-storage-procs.tcl
Tuesday 30 Mar 2021
1:19 pm

gustafn

extend tests by porting obsolete test fs_add_file_to_folder to new web testing framework

Options
    • -2
    • +51
    ./file-storage-procs.tcl
  2. … 2 more files in changeset.
Thursday 11 Mar 2021
7:09 pm

hectorr

Add 'fs_create_folder_using_api' test case, covering the 'fs::get_root_folder', 'fs::new_folder', 'fs::get_folder', 'fs::folder_p', 'fs::delete_folder', 'fs::rename_folder' and 'fs_get_folder_name' procs

Options
    • -1
    • +69
    ./file-storage-procs.tcl
Tuesday 16 Feb 2021
9:59 pm

gustafn

improve listing of test coverage

Options
    • -3
    • +13
    ./file-storage-procs.tcl
  2. … 17 more files in changeset.
Sunday 14 Feb 2021
10:05 pm

gustafn

make listing of tested procs more complete

Options
    • -1
    • +4
    ./file-storage-procs.tcl
  2. … 11 more files in changeset.
Wednesday 17 Apr 2019
1:00 pm

gustafn

add one more test case for editing a folder via the web interface

Options
    • -22
    • +48
    ./file-storage-procs.tcl
  2. … 2 more files in changeset.
Tuesday 16 Apr 2019
10:08 pm

gustafn

add test cases for web testing based on acs::test

Options
    • -87
    • +44
    ./file-storage-procs.tcl
  2. … 1 more file in changeset.
Monday 17 Sep 2018
4:23 pm

hectorr

Whitespace changes

Options
    • -101
    • +98
    ./file-storage-procs.tcl
  2. … 3 more files in changeset.
Wednesday 15 Aug 2018
6:35 pm

gustafn

- removed extra colons

- streamline layout of test cases

Options
    • -12
    • +62
    ./file-storage-procs.tcl
  2. … 1 more file in changeset.