• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add editor hints + Whitespace changes

Normalize indentation

Give templating a chance

move all hardcoded styling to the adp template, which might be styled by the theme. Also, biring some order in the login proc, e.g. don't open and read a file to include a javascript all the time.

  1. … 1 more file in changeset.
Modernize XoTcl idioms

Use finer grained api for user name

Retract package parameter configuration, as chat is not a singleton package... not clear if we will want a global paremeter for this in the future

Replace leftover Naviserver-only cache idioms with retro compatible ones

Create chat room cache in a way to provide compatibility with AOLserver

make timeout and cache size configurable.

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Rework variable assignment (set -> lassign) + Whitespace changes

  1. … 17 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 204 more files in changeset.
fix typos

  1. … 2 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7830 more files in changeset.
Port some improvements from Learn@WU codebase:

- check whether chat room exists exploits cache

- chat room retrieval enriches with some acs_objects metadata

Fix potential errors when we try entering a chat room that has been deleted and check for its activity status

Don't lookup creator name for messages coming from the system, as they won't be found

Fix spelling errors

  1. … 15 more files in changeset.
Don't abort script when people sends a message over a non-existing

chat, as this is required by the chat sweeper to happen.

- brace "if" condition

Replace inline js event when sending the message to comply with CSP

Uniform cache for chat room infos to the established nomenclature.

Increase size so that 1000 maximum entries would fit in the cache.

Fix typo

Allow user to specify how far in the past people connecting to the chat will see.

This is important on Learn@WU because people joining the chat room later want to

see the full conversation and before this was not settable from the UI. (Now defaults

to 4 hours) Useful also when somebody accidentally refreshes the chat after the

timewindow has passed.

Took this chance to ease a bit every future development: removed stored procedures

slowing greatly any change on the data model in favor of plain sql statements.

Incremented usage of cache.

Removed duplicated database operation when managing transcripts.

Fixed transcript name not being shown when deleting.

  1. … 9 more files in changeset.
Commit some leftover change, apply some review suggestions

  1. … 1 more file in changeset.
Chats won't throw an error anymore when people keep looking to a room that has been closed.

Instead, user will be informed that the room is unavailable.

Added missing locale key source of errors in the log.

Fixed wrong stored procedure, stating different arguments than in actual usage.

Cleaned up weird idioms in xql files and chat api, moved many db operations into tcl api.

Exploited cache (ns_cache) to retrieve quickly chat room information.

Improved code quality a bit.

Ported upstream some local modification, like prettifying of flags in chat room management

and fix of double quoting in chat's javascript.

  1. … 9 more files in changeset.
Introduced new options to set chat rooms so login and/or logout message are not issued everytime a user enters/exits the chat.

  1. … 12 more files in changeset.
- remove unneeded queries and .xql file

  1. … 4 more files in changeset.
- apply fresh patches to oacs-5-9 branch

  1. … 52 more files in changeset.
- remove deprecated calls

  1. … 18 more files in changeset.
- modernize Tcl

  1. … 6 more files in changeset.
- site_node::get_url_from_object_id returns a list, therefore take the first element