OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 3
Total Committers: 73
Last Commit: 11 Jun
Commits this week: 3
Total Lines of Code (LoC): 68,337
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 03 Aug 2021
9:22 pm

gustafn

provide a compatibility function for ns_parsehostport for earlier versions of NaviServer

Options
    • -3
    • +18
    ./tcl/00-icanuse-procs.tcl
Monday 02 Aug 2021
11:26 pm

gustafn

Reduce usage of ns_mktemp in OpenACS

ns_mktemp uses the deprecated old POSIX call mktemp(), which should

not be used anymore for security reasons (race between the name

creation and opening the file). This change removes several usages of

"ns_mktemp" from OpenACS and replaces it with calls to the

safe Tcl call "file tempfile ..." (introduced by Tcl 8.6).

Options
    • -6
    • +3
    ./tcl/01-database-procs.tcl
    • -4
    • +3
    ./tcl/http-client-procs.tcl
    • -9
    • +5
    ./tcl/pdf-procs.tcl
    • -3
    • +2
    ./tcl/utilities-procs-aolserver.tcl
    • -12
    • +7
    ./tcl/utilities-procs.tcl
  6. … 3 more files in changeset.
10:00 pm

gustafn

fix header generation

since the headers are set in a loop, "ns_set put" is incorrect

since it is additive. "ns_set update" is correct.

Options
    • -1
    • +1
    ./tcl/test/http-client-procs.tcl
7:38 pm

gustafn

make using page-filter "object_id" backwards compatible by allowing it to be used also during update scripts

Options
    • -5
    • +20
    ./tcl/tcl-documentation-procs.tcl
  2. … 1 more file in changeset.
7:36 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./tcl/test/security-procs.tcl
Thursday 29 Jul 2021
4:38 pm

hectorr

Adapt 'ad_urlencode_url' to the new 'ns_parseurl' stricter behavior

Options
    • -17
    • +33
    ./tcl/utilities-procs.tcl
Thursday 08 Jul 2021
11:04 pm

gustafn

added "ns_parseurl -strict" to icanuse definitions

Options
    • -0
    • +1
    ./tcl/00-icanuse-procs.tcl
Friday 02 Jul 2021
7:36 pm

antoniop

Make so that also party::update enforces emails to be lowercase, add/extend automated tests to make sure emails are lowercase everywhere

Options
    • -2
    • +3
    ./tcl/community-core-procs.tcl
    • -3
    • +1
    ./tcl/utilities-procs.tcl
    • -2
    • +15
    ./tcl/test/community-core-test-procs.tcl
2:02 pm

hectorr

Refine regex and extend tests

Options
    • -2
    • +2
    ./tcl/utilities-procs.tcl
    • -0
    • +1
    ./tcl/test/acs-tcl-test-procs.tcl
Thursday 01 Jul 2021
6:33 pm

hectorr

Extend 'acs_tcl__util_url_valid_p' test case

Options
    • -1
    • +1
    ./tcl/test/acs-tcl-test-procs.tcl
6:28 pm

hectorr

Make the check for relative URLs less strict to cover some valid cases (see RFC 1808) and extend test cases.

Options
    • -3
    • +11
    ./tcl/utilities-procs.tcl
    • -4
    • +33
    ./tcl/test/acs-tcl-test-procs.tcl
3:52 pm

hectorr

Add the 'relative' flag to 'util_url_valid_p', to check also relative URLs. Extend 'acs_tcl__util_url_valid_p' test case and bump package version.

Options
    • -3
    • +3
    ./acs-tcl.info
    • -4
    • +27
    ./tcl/utilities-procs.tcl
    • -5
    • +44
    ./tcl/test/acs-tcl-test-procs.tcl
12:36 pm

hectorr

Refine URL validation regexp and extend 'acs_tcl__util_url_valid_p' test case.

Options
    • -2
    • +5
    ./tcl/utilities-procs.tcl
    • -0
    • +63
    ./tcl/test/acs-tcl-test-procs.tcl
Thursday 24 Jun 2021
1:36 pm

hectorr

Reuse email validation logic

Options
    • -2
    • +2
    ./tcl/tcl-documentation-procs.tcl
1:31 pm

hectorr

Replace regexp for mail validation by the version proposed by mozilla for the email input type validation, and increment the test cases for valid/invalid emails. Thanks to Günter Ernst for the pointers.

Options
    • -3
    • +13
    ./tcl/utilities-procs.tcl
    • -1
    • +22
    ./tcl/test/utilities-procs.tcl
12:42 pm

hectorr

Fix ancient typo

Options
    • -2
    • +2
    ./tcl/tcl-documentation-procs.tcl
Wednesday 23 Jun 2021
4:22 pm

hectorr

Add 'object_p' test case, covering 'acs_object::object_p'

Options
    • -1
    • +23
    ./tcl/test/object-test-case-procs.tcl
4:12 pm

hectorr

Add 'string_length_compare' test case, covering 'util::string_length_compare'

Options
    • -0
    • +56
    ./tcl/test/utilities-procs.tcl
4:00 pm

hectorr

Add 'name_to_path' test case, covering 'util::name_to_path'

Options
    • -0
    • +23
    ./tcl/test/utilities-procs.tcl
3:50 pm

hectorr

Add 'util_email_valid_p' test case, covering 'util_email_valid_p'

Options
    • -0
    • +35
    ./tcl/test/utilities-procs.tcl
3:34 pm

hectorr

Increase verbosity

Options
    • -2
    • +2
    ./tcl/test/db-proc-test-procs.tcl
1:14 pm

hectorr

Add 'db_boolean' test case, covering 'db_boolean'

Options
    • -0
    • +18
    ./tcl/test/db-proc-test-procs.tcl
12:41 pm

hectorr

Add 'ad_future_years_list' test case, covering 'ad_future_years_list'

Options
    • -0
    • +19
    ./tcl/test/widget-test-procs.tcl
12:20 pm

hectorr

Add 'host_admin_and_outgoing_sender' test case, covering 'ad_outgoing_sender' and 'ad_host_administrator'

Options
    • -0
    • +22
    ./tcl/test/utilities-procs.tcl
Saturday 12 Jun 2021
8:01 pm

gustafn

fix once more handling of internal redirects in error cases

many thanks to thomas renner!

Options
    • -2
    • +2
    ./tcl/request-processor-procs.tcl
Monday 07 Jun 2021
3:55 pm

antoniop

Remove message keys sanitizing, which does not belong here

Options
    • -9
    • +1
    ./tcl/utilities-procs.tcl
Thursday 27 May 2021
9:08 pm

gustafn

use the right message key

VS: ----------------------------------------------------------------------

Options
    • -2
    • +2
    ./tcl/tcl-documentation-procs.tcl
9:07 pm

gustafn

Fixed a bug in the request processor, when URL is /%3F

The problem was that /%3F corresponds to a URL which is literally '/?'

(question mark is not the separator for query variables). In this case

a "string match" operation to determine the suffix based on this

string will lead to unexpected characters since '?' is a match

character. This lead in turn to a problem with redirects to the

internally redirect of custom error pages. So, in this case (and

probably others) the custom error page was not displayed.

Options
    • -13
    • +27
    ./tcl/request-processor-procs.tcl
Sunday 23 May 2021
7:57 pm

gustafn

improved spelling

Options
    • -1
    • +1
    ./tcl/00-icanuse-procs.tcl
    • -3
    • +3
    ./tcl/deprecated-procs.tcl
    • -1
    • +1
    ./tcl/form-processing-procs.tcl
    • -2
    • +2
    ./tcl/navigation-procs.tcl
    • -2
    • +2
    ./tcl/utilities-procs.tcl
    • -1
    • +1
    ./tcl/test/proxy-test-procs.tcl
7:56 pm

gustafn

Added page_contract filter "object_id"

This change adds the page_contract filter "object_id", which validates

values whether these are syntactically acceptable as object_ids in

PostgreSQL and Oracle.

Note that before one is able to use the filter, the server has to be

restarted. Otherwise, when e.g. "apm/version_reload.tcl" would be

executed with the new filter, it would fail. So, one has to be careful

on update scripts, when people upgrade from old version not to create

a blocking mutual blocking condition.

Options
    • -2
    • +2
    ./acs-tcl.info
    • -1
    • +2
    ./catalog/acs-tcl.de_DE.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-tcl.en_US.ISO-8859-1.xml
    • -2
    • +30
    ./tcl/tcl-documentation-procs.tcl
    • -1
    • +5
    ./tcl/test/acs-tcl-test-procs.tcl