OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 4
Total Committers: 73
Last Commit: 31 May
Commits this week: 4
Total Lines of Code (LoC): 68,337
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset MAIN:gustafn:20220220194520:1 does not match your current filter (clear filter).

Sunday 20 Feb 2022
8:45 pm

gustafn

file acs-db-00-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/acs-db-00-procs.tcl
8:45 pm

gustafn

file acs-db-12-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/acs-db-12-procs.tcl
2:18 pm

gustafn

minor cleanup to make code more consistent

Options
    • -17
    • +7
    ./tcl/01-database-procs.tcl
Friday 18 Feb 2022
1:37 pm

gustafn

util::file_content_check: new utility for checking content of a file

Check whether the provided file is of the requested type.

This function is more robust and protable than relying on

external programs and their output, but it does not work on

all possible file types. It checks a few common cases that

could lead to problems otherwise, like when uploading archives.

Bump version to 5.10.1d9

Options
    • -2
    • +2
    ./acs-tcl.info
    • -2
    • +40
    ./tcl/utilities-procs.tcl
    • -0
    • +24
    ./tcl/test/utilities-procs.tcl
1:34 pm

gustafn

minor changes: don't complain about postgres internal constraint names, provide hints for oversizing

Options
    • -11
    • +33
    ./tcl/test/datamodel-test-procs.tcl
12:50 pm

gustafn

more cases, use same testing idiom for permissions everywhere, break overlong lines

Options
    • -10
    • +16
    ./tcl/test/test-permissions-procs.tcl
12:45 pm

gustafn

fix test cases

Options
    • -14
    • +14
    ./tcl/test/test-permissions-procs.tcl
12:36 pm

gustafn

revert last change of Antonio, since this kills Oracle again

It is not clear, which code needs integer as results for Boolean results.

If there is such code, it should handle this requirement locally.

Options
    • -2
    • +2
    ./tcl/acs-permissions-procs.tcl
10:42 am

antoniop

Reintroduce cast to integer using a portable idiom

Options
    • -2
    • +2
    ./tcl/acs-permissions-procs.tcl
Tuesday 15 Feb 2022
6:10 pm

gustafn

Fixes for Oracle 19c: invalid cast to integer

This fixes the following bug for Oracle:

: invalid positional variable `:', valid values start with 1

: while executing

: "ns_ora 0or1row nsdb0 {

: select acs_permission.permission_p(:object_id, :party_id, :privilege)::integer from dual

: }"

Options
    • -2
    • +2
    ./tcl/acs-permissions-procs.tcl
6:00 pm

gustafn

fix editing bug

V: ----------------------------------------------------------------------

Options
    • -2
    • +1
    ./tcl/community-core-procs.tcl
5:57 pm

gustafn

Fixes for Oracle 19c boolean types in query

This fixes the following bug for Oracle:

: select u.user_id,

: u.authority_id,

: u.username,

: u.screen_name,

: u.priv_name,

: u.priv_email,

: u.email_verified_p,

: u.email_bouncing_p,

: u.no_alerts_until,

: u.last_visit,

: to_char(last_visit, 'YYYY-MM-DD HH24:MI:SS') as last_visit_ansi,

: u.second_to_last_visit,

: to_char(second_to_last_visit, 'YYYY-MM-DD HH24:MI:SS') as second_to_last_visit_ansi,

: u.n_sessions,

: u.password,

: u.salt,

: u.password_question,

: u.password_answer,

: u.password_changed_date,

: extract(day from current_timestamp - password_changed_date) as password_age_days,

: u.auth_token,

: mm.rel_id,

: mr.member_state !>>>!= 'approved' as registered_user_p,

: mr.member_state

: from users u

: left join group_member_map mm on mm.member_id = u.user_id

: and mm.group_id = mm.container_id

: and mm.group_id = :registered_users_group_id

: and mm.rel_type = 'membership_rel'

: left join membership_rels mr on mr.rel_id = mm.rel_id

: where u.user_id = :user_id

Options
    • -1
    • +2
    ./tcl/community-core-procs.tcl
Thursday 10 Feb 2022
10:33 pm

gustafn

fixes for Oracle 19c

Options
    • -0
    • +1
    ./tcl/20-memoize-init.tcl
    • -2
    • +2
    ./tcl/acs-kernel-procs.tcl
    • -4
    • +5
    ./tcl/apm-procs.tcl
  4. … 3 more files in changeset.
Monday 07 Feb 2022
1:21 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
    • -3
    • +3
    ./tcl/utilities-procs.tcl
    • -1
    • +1
    ./tcl/test/proxy-test-procs.tcl
1:13 pm

gustafn

extend tests and pinpoint essesntials

Options
    • -0
    • +20
    ./tcl/test/db-proc-test-procs.tcl
11:30 am

antoniop

Cleanup smelly comment: we don't need to catch the error, if it fails it fails and the application should handle it

Options
    • -2
    • +1
    ./tcl/utilities-procs.tcl
11:20 am

antoniop

Minimize and corrrect test: strings containing the null character are expected to fail when fed to the DBMS, even when quoted

Options
    • -10
    • +14
    ./tcl/test/db-proc-test-procs.tcl
    • -109
    • +0
    ./tcl/test/data/db-quoting-test.txt
Thursday 03 Feb 2022
3:33 pm

antoniop

New automated test

Options
    • -0
    • +18
    ./tcl/test/db-proc-test-procs.tcl
    • -0
    • +109
    ./tcl/test/data/db-quoting-test.txt
3:33 pm

antoniop

file db-quoting-test.txt was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/data/db-quoting-test.txt
2:58 pm

antoniop

Provide a fallback for vhost_url in ad_conn for code executed before this value has been set by the request processor

Options
    • -1
    • +6
    ./tcl/request-processor-procs.tcl
Friday 28 Jan 2022
11:44 pm

gustafn

use "ns_strcoll" for ordered composite when available

Options
    • -0
    • +8
    ./tcl/00-icanuse-procs.tcl
  2. … 1 more file in changeset.
Thursday 27 Jan 2022
11:27 am

gustafn

include timing information in DEBUG lines only, when nsf was configured properly with it

Options
    • -0
    • +2
    ./tcl/00-icanuse-procs.tcl
  2. … 1 more file in changeset.
10:23 am

antoniop

Deprecate template::util::tcl_to_sql_list, completely replaced by ns_dbquotelist, a native NaviServer command

Options
    • -2
    • +2
    ./tcl/application-data-link-procs.xql
  2. … 17 more files in changeset.
Wednesday 26 Jan 2022
12:12 am

gustafn

use icanuse machinery for "ns_reflow_text -offset"

Options
    • -0
    • +1
    ./tcl/00-icanuse-procs.tcl
    • -26
    • +34
    ./tcl/text-html-procs.tcl
12:10 am

gustafn

improve comment

Options
    • -4
    • +7
    ./tcl/request-processor-procs.tcl
Tuesday 25 Jan 2022
6:33 pm

antoniop

Streamline idiom

Options
    • -8
    • +4
    ./tcl/community-core-procs.tcl
6:31 pm

antoniop

Whitespace cleanup

Options
    • -20
    • +20
    ./tcl/community-core-procs.xql
Monday 24 Jan 2022
7:24 pm

gustafn

extend test cases

Options
    • -0
    • +34
    ./tcl/test/acs-tcl-test-procs.tcl
    • -4
    • +5
    ./tcl/test/doc-check-procs.tcl
Saturday 22 Jan 2022
1:09 pm

gustafn

Modernize parameter parsing (query and includelet paramters)

- handle invalid UTF-8 exception that might be triggered by

"ns_parsequery" in newer versions of NaviServer

- the new code is about 4 times faster than the old one

- replaced array by dict

- don't create helper procs on the fly but use "nsf::parseargs" if possible

- added icanuse rules for

* "nsf::parseargs -asdict"

* "ns_parsequery -charset"

Options
    • -1
    • +2
    ./tcl/00-icanuse-procs.tcl
  2. … 1 more file in changeset.
Thursday 20 Jan 2022
10:50 am

gustafn

improve comment

Options
    • -2
    • +2
    ./tcl/security-procs.tcl