• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
file apm-file-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/apm-file-procs.tcl
As tcllib was released in 2016, I believe we can cleanup the legacy zip implementation

Provide exec-free implementation of util::unzip using zipfile::decode

Extend the test to cover also cornercase behavior concerning overwriting of files

Test zipping and unzipping utilities

Make test less tautological

Test for psql only when this is expected

    • -12
    • +20
    ./tcl/test/acs-tcl-test-procs.tcl
Fallback to the location of the psql executable when a pgbin was not explicitly defined in the config file (which is allowed)

Test external command dependencies

This will currently fail because of a bug in db_get_pgbin

Test ad_change_password

Add notes about api

    • -5
    • +21
    ./tcl/site-node-apm-integration-procs.tcl
Update api

  1. … 1 more file in changeset.
Deprecate trivial wrappers to the NaviServer API

Modern ns_getform will not return the empty string for empty requests, but only when we are operating outside of a connection. In such circumstances is arguably useful to manipulate the request parameters.

  1. … 2 more files in changeset.
Commit missing change to the users api

Update documentation

Use a better regexp to reimplement ad_looks_like_html_p, use the improved api to port downstream feature: an ad_form datatype validator that won't allow to insert markup

Many thanks to Günter Ernst

  1. … 1 more file in changeset.
Deprecate ad_ns_set_to_tcl_vars, which can always be replaced with simple tcl idioms

Deprecate ad_user_class_description, private proc used nowhere in upstream codebase

Go straight to the database skipping the many trivial stored procedures, this reduces divergency between Oracle and Postgres

    • -47
    • +0
    ./tcl/membership-rel-procs-oracle.xql
    • -47
    • +0
    ./tcl/membership-rel-procs-postgresql.xql
addeded page contract filter: safetclchars

safetclchars should be used in cases, were the variable value is passed

to "subst", or "eval"...

Save and restore all variables properly to not be influenced or interfere with other tests

    • -6
    • +12
    ./tcl/test/tcl-documentation-procs.tcl
added suport in export_vars for exporting instance variables

example:

xotcl::Object create o1

o1 set x 1

o1 proc foo {} {export_vars -base /foo {a :x b}}

o1 foo

result:

/foo?x=1

Increase proc coverage

Tolerate the absence of the canonicalServer instance variable, complaining as if it was empty

Test ad_schedule_proc

Make test more robust with respect to side effects from other code around

    • -9
    • +24
    ./tcl/test/tcl-documentation-procs.tcl
Move remark about old AOLServer issues out of the public doc

Test ad_raise and ad_exception

file exception-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/exception-procs.tcl
Test ad_safe_eval api