OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 4
Total Committers: 73
Last Commit: 31 May
Commits this week: 4
Total Lines of Code (LoC): 68,337
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 28 Feb 2023
8:39 am

antoniop

file acs-cache-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/acs-cache-procs.tcl
Monday 27 Feb 2023
7:19 pm

gustafn

bump version number to 5.10.1d30

Options
    • -2
    • +2
    ./acs-tcl.info
7:19 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./tcl/request-processor-init.tcl
6:57 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./tcl/acs-cache-procs.tcl
    • -2
    • +2
    ./tcl/ad-functional-procs.tcl
    • -3
    • +3
    ./tcl/cluster-procs.tcl
    • -2
    • +2
    ./tcl/security-procs.tcl
    • -2
    • +2
    ./tcl/whos-online-init.tcl
6:53 pm

gustafn

Emit a warning to the log file when parametersecret is not set in the configuration file

Options
    • -1
    • +10
    ./tcl/security-init.tcl
6:51 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./tcl/test/db-proc-test-procs.tcl
    • -1
    • +1
    ./tcl/test/security-procs.tcl
    • -2
    • +2
    ./tcl/test/site-nodes-test-procs.tcl
6:47 pm

gustafn

security::safe_tmpfile_p: fix false positive under macOS

This fixes as well the regression test for acs-tcl under macOS

Options
    • -5
    • +6
    ./tcl/security-procs.tcl
6:31 pm

gustafn

provide an API for single-token signed values

Options
    • -1
    • +40
    ./tcl/security-procs.tcl
6:23 pm

gustafn

modernize test

Options
    • -28
    • +28
    ./tcl/test/test-membership-rel-procs.tcl
5:58 pm

gustafn

provide warning when split-location fails

Options
    • -1
    • +3
    ./tcl/utilities-procs.tcl
5:46 pm

antoniop

Increase proc coverage

Options
    • -0
    • +19
    ./tcl/test/widget-test-procs.tcl
  2. … 1 more file in changeset.
12:37 pm

antoniop

Consider failures obtaining the token as failure to verify the value and report into the log file

Options
    • -2
    • +8
    ./tcl/security-procs.tcl
Thursday 23 Feb 2023
12:57 pm

antoniop

Test all the cornercases of this api as intended, without using ad_tmpnam

Options
    • -30
    • +30
    ./tcl/test/security-procs.tcl
Tuesday 21 Feb 2023
11:59 am

antoniop

Fix typo

Options
    • -2
    • +2
    ./tcl/01-database-procs.tcl
11:58 am

antoniop

Test db_foreach with -column_set with at least 2 rows to check that feering the ns_set works properly

Options
    • -5
    • +12
    ./tcl/test/db-proc-test-procs.tcl
11:53 am

antoniop

Repair -column_set flag

A more efficient approach would use db api returning ns_sets directly, rather than db_list_of_lists, however this would require a deeper refactoring.

Options
    • -7
    • +26
    ./tcl/01-database-procs.tcl
11:49 am

antoniop

Test db_foreach -column_set flag, documented and used e.g. in the schema-browser

Options
    • -0
    • +8
    ./tcl/test/db-proc-test-procs.tcl
Monday 20 Feb 2023
4:48 pm

gustafn

reduce verbosity

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
Friday 10 Feb 2023
8:07 pm

gernst

Added proc "membership_rel::expire" so that all membership states are now covered. Note: The Oracle part is best effort only!

Options
    • -2
    • +2
    ./acs-tcl.info
    • -0
    • +5
    ./tcl/membership-rel-procs-oracle.xql
    • -0
    • +5
    ./tcl/membership-rel-procs-postgresql.xql
    • -1
    • +10
    ./tcl/membership-rel-procs.tcl
    • -1
    • +11
    ./tcl/test/test-membership-rel-procs.tcl
  6. … 6 more files in changeset.
Wednesday 08 Feb 2023
7:35 pm

gustafn

cluster reform: added admin page and minor updates

Options
    • -2
    • +2
    ./acs-tcl.info
    • -17
    • +20
    ./tcl/cluster-procs.tcl
  3. … 4 more files in changeset.
Tuesday 07 Feb 2023
6:50 pm

gustafn

Cluster reform

- Support for dynamic cluster nodes:

Previous versions of OpenACS required to know the IP addresses of

the cluster nodes in advance, which is a show-stopper for many cloud

applications.

The new functionality allows arbitrary nodes to register as client

nodes at the canonical server, provided that these know a shared

secret. All messages of the intra-cluster talk are now

cryptographically signed using this shared secret.

In the current version, the shared secret key has to be specified in

the NaviServer configuration file (ClusterSecret). Later versions

will support the use of other measures such as generated keys, kept

as files.

Also in the new version it is still possible to use static peer

addresses (which do not have to register during startup).

- Support for multiple protocols for intra-cluster talk

Previous version of OpenACS required the communication of the

intra-cluster talk over HTTP. With these changes, multiple protocols

are supported. Most prominently HTTPS can be used, which is required

by some organization for all web communication, especially for cloud

applications. Other protocols might be added later (e.g. UDP).

- Nodes (such as the canonical server) can be specified via URL

locations. These location specifier have the following advantages

over classical IP address and port.

* support different protocols (http, https, udp)

* support of IP addresses or DNS names

* when DNS names map to multiple IP addresses

(e.g. multiple IPv4 and/or multiple IPv6 addresses)

the new parameter PreferredLocationRegexp can be use

to select the wanted. When this regexp does not match

any of the addresses, the first address is used.

* ports are now optional (except UDP)

* for location specifier: https://openacs.org

- Support for cluster communication statistics

(requires xotcl-request-monitor)

These statistics show the amount of intra-server

communication. The following statistics are collected

per node:

- number of broadcast operations

- number of send operations (active flushes)

- number of receive operation (passive flushes)

For N cluster nodes, the send operations are

basically the number of broadcast operations times

the number of nodes minus one.

These statistics can also be used prior to cluster

enabling, to obtain the number of potential broadcast

operations.

Kernel Parameters

CanonicalServer : location of the canonical server

ClusterAuthorizedIP : obsolete

ClusterEnabledP : unchanged

ClusterPeerIP : obsolete

EnableLoggingP : unchanged

PreferredLocationRegexp : new

DynamicClusterPeers : new, no not edit

Differences between old and new value for "CanonicalServer":

old:

- specify IP address with port

- example: 137.208.116.31:443

new:

- specify URL location

- support different protocols (http, https, udp)

- support of IP address or domain name

- when domain name maps to different IP addresses

(e.g. multiple IPv4 and/or multiple IPv6 addresses)

PreferredLocationRegexp can be use to select the wanted.

When the provided regexp does not match any of

the addresses, take the first address.

- port is optional

- example: https://openacs.org

Sample setup

Old:

CanonicalServer : 137.208.116.31:443

ClusterAuthorizedIP : 137.208.116.31

ClusterPeerIP : 137.208.116.31:443 137.208.116.31:8443

ClusterEnabledP : 1

EnableLoggingP : 1

New:

CanonicalServer : https://openacs.org

PreferredLocationRegexp : https://

ClusterEnabledP : 1

EnableLoggingP : 1

#

# Cluster secret for intra-cluster communications in NaviServer

# configuration file. Clustering will not be enabled if no value is

# provided.

#

ns_section ns/server/$server/acs {

# ...

ns_param ClusterSecret "please change me"

}

#-----------------------------------------------------------------------

# Support for munin statistics

#

# 1) install munin plugins for naviserver (munin-plugins-ns.git)

# 2) add link to the munin plugins (replace "openacs" by the name

# of your server in the munin configuration)

# /etc/munin/plugins/naviserver_openacs_count_cluster -> /usr/share/munin/plugins/naviserver_count

# 3) in the plugin plugin configuration (e.g., etc/munin/plugin-conf.d/naviserver)

# add a section like the following (again, replace "openacs" by the server name you used)

#

# [naviserver_openacs_count_cluster]

# env.title Cluster

# env.vars cluster:broadcast cluster:sent cluster:received

#

# 4) restart munin

Options
    • -3
    • +3
    ./acs-tcl.info
    • -26
    • +44
    ./tcl/cluster-init.tcl
    • -245
    • +639
    ./tcl/cluster-procs.tcl
    • -95
    • +25
    ./tcl/server-cluster-procs.tcl
  5. … 1 more file in changeset.
6:28 pm

gustafn

make util::join_location usabel for udp and smtp

Options
    • -2
    • +2
    ./tcl/utilities-procs.tcl
6:27 pm

gustafn

silence warning about query names in the log file

Options
    • -2
    • +2
    ./tcl/acs-db-12-procs.tcl
6:00 pm

antoniop

Increase coverage of page contract filters

Options
    • -5
    • +167
    ./tcl/test/acs-tcl-test-procs.tcl
5:57 pm

antoniop

Deprecate usphone page filter, as a more generic alternative exists that does not assume the US as target audience

Options
    • -3
    • +8
    ./tcl/tcl-documentation-procs.tcl
3:09 pm

antoniop

Improve proc coverage

Options
    • -0
    • +88
    ./tcl/test/security-procs.tcl
2:36 pm

antoniop

Deprecate ad_decorate_top, superseded by modern templating features

Options
    • -4
    • +9
    ./tcl/defs-procs.tcl
2:32 pm

antoniop

Deprecate ad_package_admin_home, limited, inaccurate and superseded by site node api

Options
    • -4
    • +12
    ./tcl/defs-procs.tcl
2:21 pm

antoniop

Deprecate ad_db_select_widget, superseded by modern template system features

Options
    • -2
    • +9
    ./tcl/widgets-procs.tcl
2:15 pm

antoniop

Deprecate ad_dateentrywidget, with hardcoded values, superseded by modern features

Options
    • -3
    • +3
    ./tcl/tcl-documentation-procs.tcl
    • -2
    • +9
    ./tcl/widgets-procs.tcl
  3. … 2 more files in changeset.