• last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Whitespace changes

follow usual naming conventions

  1. … 2 more files in changeset.
Fix comment

Add flushing of user permissions as well when adding to a new group, extend comments

Tolerate usages of get_members_not_cached in "frontend code" around by making new member_state parameter optional and therefore not breaking previous contract

use consistently 'ad_script_abort' after 'ns_returnfile'

Add missing 'ad_script_abort' after 'ns_returnfile'

Deprecate duplicated api and replace its only occurence in upstream codebase

    • -9
    • +0
    ./tcl/plpgsql-utility-procs-postgresql.xql
  1. … 1 more file in changeset.
Better handling of errors during 'exec convert' in portrait-bits.tcl, returning the default avatar when it fails

Use a variable for the default avatar mime type

Return default avatar also when there are internal issues parsing the user provided picture

fix for bug #3375: set fully qualified url for instance_name

Allow to filter group members by membership state in the API

whitespace changes

S: ----------------------------------------------------------------------

use parameter::get_from_package_key only for singletons

Provide some basic way to create subgroups via the UI

Actually store the group name in the UI by intercepting the right form var

Fix test test by considering that group pretty name is automatically localized

Don't quote some function defaults that are meant to be evaluated literally

New automated test doing the roundrtrip of group-type related API

Note that this is currently failing due to a bug in package_instantiate_object, which triggered the creation of this test.

Move logics to delete a group type into the API

    • -1
    • +31
    ./tcl/group-type-procs-postgresql.xql
    • -62
    • +6
    ./www/admin/group-types/delete-2.tcl
    • -14
    • +0
    ./www/admin/group-types/delete-2.xql
Fix quoting of group type

Remove unneeded variable

Add (trivial) ad_include_contract

Avoid unnecessary computations

Reduce divergency between oracle and postgres codebase and bring portable sql inline

    • -39
    • +0
    ./tcl/application-group-procs-oracle.xql
    • -41
    • +0
    ./tcl/application-group-procs-postgresql.xql
Reuse return url over subsites, remove dummy sql

Use best practice list idiom

Avoid useless check

Use ad_include_contract for this include page

    • -25
    • +29
    ./www/admin/groups/elements-by-rel-type.tcl