• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use more API when retrieving user info and portrait, streamline queries, put all sql inline

Remove unnecessary xql

Put this last query also in the code as the others, so no xql is required

Use more API, reduce divergency between postgres and oracle code

Use more API

  1. … 1 more file in changeset.
Prefer API over handcrafted queries

Dont require role at the ends of relationships as this is not required in the data model and standard relationships (e.g. membership_rel, admin_rel) lack these roles as well

Fix page for deleting roles

Prefer literal in adp axpressions + Whitespace changes

  1. … 29 more files in changeset.
Streamline code

Remove broken portrait script from the old good days

    • -53
    • +0
    ./shared/portrait-thumbnail-bits.tcl
improve wording

  1. … 7 more files in changeset.
Fix typos

    • -1
    • +1
    ./permissions/perm-user-add-include.tcl
  1. … 10 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 467 more files in changeset.
image width information in table images seems flaky. since portrait-bits provides efficient

scaling, why not use it?

increase number of accepted sizes

make spelling more consitent

  1. … 2 more files in changeset.
add file-not-found .adp file

    • -0
    • +5
    ./shared/file-not-found.adp
Prefer '{}' to '[list]' when creating empty lists

  1. … 218 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 70 more files in changeset.
fix typos, regenerated documentation

    • -4
    • +5
    ./admin/groups/elements-by-group-type.tcl
    • -4
    • +5
    ./admin/groups/elements-by-rel-type.tcl
    • -4
    • +6
    ./doc/group-admin-pages-acceptance-test.adp
    • -5
    • +5
    ./doc/group-admin-pages-requirements.adp
  1. … 304 more files in changeset.
Rework variable assigning loops (set -> lassign)

  1. … 1 more file in changeset.
Fix typos

  1. … 31 more files in changeset.
remove conditions, which are always true

  1. … 6 more files in changeset.
remove conditions, which are always true

modernize Tcl

Use I18n messages for email and username

use canonical Tcl subcommand names

  1. … 7 more files in changeset.
remove $Id$ line

Use message key instead of hardcoded value