OpenACS / openacs-4 / packages / acs-subsite

www

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 2
Total Committers: 66
Last Commit: 26 Apr
Commits this week: 2
Total Lines of Code (LoC): 25,798
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 28 May 2018
7:45 pm

antoniop

Prefer API over handcrafted queries

Options
    • -6
    • +6
    ./user/portrait/index.tcl
Thursday 24 May 2018
12:02 pm

michaela

Dont require role at the ends of relationships as this is not required in the data model and standard relationships (e.g. membership_rel, admin_rel) lack these roles as well

Options
    • -1
    • +4
    ./admin/rel-types/new-2.tcl
11:40 am

michaela

Fix page for deleting roles

Options
    • -2
    • +2
    ./admin/rel-types/roles/delete.tcl
Tuesday 22 May 2018
5:59 pm

hectorr

Prefer literal in adp axpressions + Whitespace changes

Options
    • -10
    • +10
    ./admin/relations/one.adp
  2. … 29 more files in changeset.
5:11 pm

antoniop

Streamline code

Options
    • -12
    • +5
    ./pvt/set-on-vacation-to-null.tcl
4:59 pm

antoniop

Remove broken portrait script from the old good days

Options
    • -53
    • +0
    ./shared/portrait-thumbnail-bits.tcl
Thursday 17 May 2018
9:43 am

gustafn

improve wording

Options
    • -1
    • +1
    ./admin/themes/view.tcl
  2. … 7 more files in changeset.
Tuesday 15 May 2018
11:41 pm

hectorr

Fix typos

Options
    • -1
    • +1
    ./permissions/perm-user-add-include.tcl
  2. … 10 more files in changeset.
Wednesday 09 May 2018
5:33 pm

hectorr

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

Options
    • -2
    • +2
    ./index.tcl
    • -2
    • +2
    ./admin/group-types/delete-2.tcl
    • -2
    • +2
    ./admin/site-map/index.tcl
    • -3
    • +3
    ./admin/site-map/site-map.tcl
    • -3
    • +3
    ./permissions/grant.tcl
    • -2
    • +2
    ./permissions/one.tcl
    • -1
    • +1
    ./permissions/perm-include.tcl
    • -2
    • +2
    ./shared/whos-online.tcl
    • -3
    • +3
    ./site-map/index.tcl
  10. … 467 more files in changeset.
Thursday 03 May 2018
9:22 am

gustafn

image width information in table images seems flaky. since portrait-bits provides efficient

scaling, why not use it?

Options
    • -3
    • +8
    ./shared/community-member.tcl
9:18 am

gustafn

increase number of accepted sizes

Options
    • -2
    • +2
    ./shared/portrait-bits.tcl
Monday 30 Apr 2018
10:51 am

gustafn

make spelling more consitent

Options
    • -4
    • +4
    ./admin/relations/add.tcl
  2. … 2 more files in changeset.
10:30 am

gustafn

add file-not-found .adp file

Options
    • -0
    • +5
    ./shared/file-not-found.adp
Thursday 26 Apr 2018
10:56 am

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -2
    • +2
    ./index.tcl
    • -2
    • +2
    ./admin/group-types/delete-2.tcl
    • -3
    • +3
    ./admin/site-map/site-map.tcl
    • -2
    • +2
    ./permissions/grant.tcl
    • -2
    • +2
    ./permissions/one.tcl
    • -1
    • +1
    ./permissions/perm-include.tcl
    • -2
    • +2
    ./shared/whos-online.tcl
    • -3
    • +3
    ./site-map/index.tcl
  9. … 218 more files in changeset.
Wednesday 25 Apr 2018
9:23 pm

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -2
    • +2
    ./admin/site-map/index.tcl
    • -2
    • +2
    ./permissions/grant.tcl
  3. … 70 more files in changeset.
10:38 am

gustafn

fix typos, regenerated documentation

Options
    • -4
    • +5
    ./admin/groups/elements-by-group-type.tcl
    • -4
    • +5
    ./admin/groups/elements-by-rel-type.tcl
    • -4
    • +6
    ./doc/group-admin-pages-acceptance-test.adp
    • -5
    • +5
    ./doc/group-admin-pages-requirements.adp
    • -2
    • +2
    ./doc/index.adp
  6. … 304 more files in changeset.
Monday 23 Apr 2018
11:32 pm

hectorr

Rework variable assigning loops (set -> lassign)

Options
    • -8
    • +5
    ./permissions/perm-modify.tcl
    • -5
    • +4
    ./permissions/revoke-2.tcl
    • -5
    • +4
    ./permissions/revoke.tcl
  4. … 1 more file in changeset.
Wednesday 11 Apr 2018
11:35 pm

hectorr

Fix typos

Options
    • -3
    • +3
    ./o.vuh
  2. … 31 more files in changeset.
Saturday 07 Apr 2018
9:30 pm

gustafn

remove conditions, which are always true

Options
    • -3
    • +3
    ./admin/object-types/one.tcl
    • -7
    • +10
    ./user/password-update.tcl
  3. … 6 more files in changeset.
7:48 pm

gustafn

remove conditions, which are always true

Options
    • -2
    • +2
    ./admin/site-map/parameter-set.tcl
    • -2
    • +2
    ./permissions/grant.tcl
7:31 pm

gustafn

modernize Tcl

Options
    • -2
    • +2
    ./admin/site-map/new.tcl
    • -2
    • +7
    ./admin/site-map/site-map.tcl
Tuesday 03 Apr 2018
4:43 pm

michaela

Use I18n messages for email and username

Options
    • -3
    • +3
    ./register/recover-password.tcl
Friday 30 Mar 2018
1:21 am

gustafn

use canonical Tcl subcommand names

Options
    • -1
    • +1
    ./admin/site-map/allow-for-view.tcl
  2. … 7 more files in changeset.
Thursday 29 Mar 2018
11:51 pm

gustafn

remove $Id$ line

Options
    • -1
    • +0
    ./pvt/toggle-dont-spam-me-p.tcl
1:16 pm

michaela

Use message key instead of hardcoded value

Options
    • -2
    • +2
    ./members/index.tcl
1:36 am

hectorr

Fix typos

Options
    • -1
    • +1
    ./admin/themes/view.tcl
  2. … 17 more files in changeset.
Wednesday 28 Mar 2018
11:55 pm

hectorr

Fix typos

Options
    • -2
    • +2
    ./members/user-new.tcl
  2. … 7 more files in changeset.
Tuesday 27 Mar 2018
1:17 pm

hectorr

Fix typos

Options
    • -1
    • +1
    ./members/member-state-change.tcl
    • -2
    • +2
    ./shared/community-member.tcl
  3. … 41 more files in changeset.
Saturday 24 Mar 2018
1:14 am

hectorr

Fix even more typos

Options
    • -1
    • +1
    ./permissions/perm-modify.tcl
  2. … 29 more files in changeset.
Wednesday 21 Feb 2018
3:00 pm

antoniop

Portrait management reform and correction

Moved logics to create a portrait in a proc in order to reuse it in other places

such as picture retrieval services (e.g. Bach picture retrieval at WU). Turns out

we were not doing our homeworks here: when the portrait is created into CR, a

cr_child_rel is created. When the portrait was erased though, this was not cleaned

up propely, leaving dangling acs_objects with no reference in cr_child_rels table.

On busy sites, this can grow in the ten thousands order of magnitude. Changes include

also fix for this behavior and tuples cleanup.

Options
    • -16
    • +6
    ./user/portrait/index.tcl
    • -19
    • +0
    ./user/portrait/upload-oracle.xql
    • -22
    • +0
    ./user/portrait/upload-postgresql.xql
    • -75
    • +15
    ./user/portrait/upload.tcl
    • -38
    • +0
    ./user/portrait/upload.xql
  6. … 12 more files in changeset.