OpenACS / openacs-4 / packages / acs-subsite / www

pvt

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 20
Last Commit: 17:58
Commits this week: 0
Total Lines of Code (LoC): 405
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 28 Mar 2023
1:20 pm

antoniop

Remove no_alarms_until column

Rationale: the column or the related api is never used in upstream code to check whether notifications should be sent or not or not. The UI to manage the column's value was not linked anywhere. On the instances accessible by me downstream, no tuple was found where this column had a value.

Options
    • -8
    • +0
    ./set-on-vacation-to-null.adp
    • -29
    • +0
    ./set-on-vacation-to-null.tcl
    • -24
    • +0
    ./set-on-vacation-to-null.xql
    • -12
    • +0
    ./set-on-vacation-until.adp
    • -42
    • +0
    ./set-on-vacation-until.tcl
    • -11
    • +0
    ./set-on-vacation-until.xql
  7. … 13 more files in changeset.
Monday 05 Sep 2022
5:07 pm

antoniop

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

Options
    • -2
    • +2
    ./alerts.tcl
  2. … 6 more files in changeset.
Tuesday 28 Dec 2021
12:15 pm

antoniop

Streamline idiom

Options
    • -6
    • +7
    ./set-on-vacation-until.tcl
Friday 03 Jul 2020
9:43 am

gustafn

mprove spelling: move closer to the linux documentation recommendations, standardize variable names

Options
    • -7
    • +7
    ./alerts.tcl
  2. … 19 more files in changeset.
Thursday 02 Jan 2020
3:10 pm

antoniop

Use ad_page_contract, remove redundant sql

Options
    • -1
    • +6
    ./toggle-dont-spam-me-p.tcl
Thursday 16 May 2019
11:54 am

gustafn

whitespace changes

Options
    • -51
    • +51
    ./alerts.tcl
  2. … 51 more files in changeset.
Tuesday 29 May 2018
11:09 am

antoniop

Remove unnecessary xql

Options
    • -9
    • +11
    ./alerts.tcl
    • -40
    • +0
    ./alerts.xql
Monday 28 May 2018
7:53 pm

antoniop

Use more API

Options
    • -10
    • +8
    ./alerts.tcl
  2. … 2 more files in changeset.
Tuesday 22 May 2018
5:11 pm

antoniop

Streamline code

Options
    • -12
    • +5
    ./set-on-vacation-to-null.tcl
Thursday 29 Mar 2018
11:51 pm

gustafn

remove $Id$ line

Options
    • -1
    • +0
    ./toggle-dont-spam-me-p.tcl
Wednesday 31 Jan 2018
9:47 pm

gustafn

fix typo

Options
    • -2
    • +2
    ./set-on-vacation-to-null.tcl
Saturday 27 Jan 2018
5:19 pm

gustafn

delete unneeded .xql files

Options
    • -26
    • +0
    ./unsubscribe-2-oracle.xql
    • -23
    • +0
    ./unsubscribe-2-postgresql.xql
    • -2
    • +1
    ./unsubscribe-2.tcl
    • -15
    • +0
    ./unsubscribe-oracle.xql
    • -15
    • +0
    ./unsubscribe-postgresql.xql
    • -13
    • +0
    ./unsubscribe.xql
  7. … 20 more files in changeset.
Sunday 21 Jan 2018
1:35 am

gustafn

Use consistently ad_script_abort after ad_return_error.

Break long lines

Options
    • -2
    • +2
    ./set-on-vacation-until.tcl
  2. … 24 more files in changeset.
Friday 19 Jan 2018
3:09 pm

gustafn

add ad_script_abort after ad_returnredirect to make termination intent explicit

Options
    • -4
    • +3
    ./toggle-dont-spam-me-p.tcl
  2. … 48 more files in changeset.
Friday 05 Jan 2018
11:40 pm

gustafn

make sure to call ad_script_abort after ad_returnredirect

Options
    • -0
    • +1
    ./hide-email.tcl
    • -1
    • +2
    ./index.tcl
  3. … 14 more files in changeset.
Monday 20 Nov 2017
2:38 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -38
    • +0
    ./alerts-oracle.xql
    • -38
    • +0
    ./alerts-postgresql.xql
    • -0
    • +29
    ./alerts.xql
Tuesday 08 Aug 2017
1:47 am

gustafn

merged changes from the oacs-5-9 branch and resolved conflicts

Options
    • -5
    • +5
    ./alerts.adp
    • -3
    • +12
    ./alerts.tcl
    • -2
    • +7
    ./hide-email.tcl
    • -1
    • +1
    ./home.adp
    • -2
    • +7
    ./home.tcl
    • -1
    • +7
    ./index.tcl
    • -1
    • +7
    ./set-on-vacation-to-null.tcl
    • -3
    • +8
    ./set-on-vacation-until.tcl
    • -1
    • +7
    ./toggle-dont-spam-me-p.tcl
    • -1
    • +7
    ./unsubscribe-2.tcl
    • -1
    • +7
    ./unsubscribe.tcl
  12. … 7824 more files in changeset.
Saturday 04 Feb 2017
2:57 pm

gustafn

- replace "<include ... />" by "<include ... >", since adp parser in

AOLserver and NaviServer passes "/" as argument to the adp-include.

Options
    • -1
    • +1
    ./home.adp
  2. … 5 more files in changeset.
Wednesday 18 Jan 2017
9:05 am

gustafn

- make boolean tests in .adp files more uniform

Options
    • -5
    • +5
    ./alerts.adp
  2. … 56 more files in changeset.
Sunday 27 Nov 2016
1:19 pm

gustafn

Some more Tcl cleanup

- use curly brackes to enable byte code compilation

- don't use "[expr ...]" when not needed

- prefer "incr i -1" over "set i [expr {$i - 1}] "

Options
    • -2
    • +2
    ./set-on-vacation-until.tcl
  2. … 15 more files in changeset.
Saturday 02 Jan 2016
9:57 pm

gustafn

- write sql statements between curly braces

Options
    • -2
    • +6
    ./alerts.tcl
  2. … 14 more files in changeset.
1:42 pm

gustafn

.xql-file reform of acs-subsite:

- remove obsolete queries

email_image::new_item.new_lob_size

email_image::new_item.new_lob_size

group::member_p.group_id_from_name

subsite::default::create_app_group.group_exists

package_mounted_p

- add missing Oracle queries

acs-subsite/tcl/rel-types-procs-oracle.xql

rel_types::additional_rel_types_group_p.group_rel_type_exists

rel_types::additional_rel_types_group_type_p.group_rel_type_exists

www/admin/group-types/new-oracle.xql

select_group_supertypes

- add missing PostgreSQL queries

acs-subsite/tcl/rel-types-procs-postgresql.xql.xql

rel_types::additional_rel_types_group_p.group_rel_type_exists

- remove obsolete files

www/admin/index-oracle.xql

www/admin/index-postgresql.xql

www/admin/index.xql

www/admin/rel-types/roles/new-oracle.xql

www/admin/rel-types/roles/new-postgresql.xql

www/permissions/one.xql

www/pvt/unsubscribe-2-oracle.xql

www/pvt/unsubscribe-2-postgresql.xql

www/pvt/unsubscribe-oracle.xql

www/pvt/unsubscribe-postgresql.xql

www/pvt/unsubscribe.xql

www/register/user-new.xql

www/shared/portrait-bits-oracle.xql

www/shared/portrait-bits-postgresql.xql

www/shared/portrait-bits.xql

Options
    • -26
    • +0
    ./unsubscribe-2-oracle.xql
    • -23
    • +0
    ./unsubscribe-2-postgresql.xql
    • -15
    • +0
    ./unsubscribe-oracle.xql
    • -15
    • +0
    ./unsubscribe-postgresql.xql
    • -13
    • +0
    ./unsubscribe.xql
  6. … 22 more files in changeset.
Wednesday 28 Oct 2015
10:38 am

gustafn

.xql overhaul:

- removed misleading sql-statements from db_* calls, which were

ignored due .xql files

- removed bug where same query name was used in a single proc

with different intended sql queries, but the same was picked

up from the .xql file due to the name

- removed multiple entries of same query name from .xql files

(e.g. the entry "package_create_attribute_list.select_type_info" was

7 (!!!) times in a single .xql file)

- removed redundant queries for unsupported versions of the dbms

- added missing xql entries for db-backends, where other db-specific

queries exists (e.g. added an entry to -oracle.xql, where an entry

existed in -postgres.xql)

Options
    • -1
    • +1
    ./hide-email.tcl
  2. … 70 more files in changeset.
Thursday 10 Sep 2015
10:21 am

gustafn

- add editor hints to keep spaces/tabs in the furture more consistent

Options
    • -2
    • +7
    ./alerts.tcl
    • -1
    • +6
    ./hide-email.tcl
    • -2
    • +7
    ./home.tcl
    • -1
    • +7
    ./index.tcl
    • -1
    • +7
    ./set-on-vacation-to-null.tcl
    • -2
    • +7
    ./set-on-vacation-until.tcl
    • -1
    • +7
    ./toggle-dont-spam-me-p.tcl
    • -1
    • +7
    ./unsubscribe-2.tcl
    • -1
    • +7
    ./unsubscribe.tcl
  10. … 746 more files in changeset.
Wednesday 15 Jul 2015
12:26 am

gustafn

- standardize argument passing to adp-includes, don't perform double i18n and double quoting

Options
    • -1
    • +1
    ./home.adp
  2. … 124 more files in changeset.
Friday 03 Jul 2015
1:04 pm

gustafn

- fix and standardize quoting in template properties

Options
    • -1
    • +1
    ./home.adp
  2. … 42 more files in changeset.
12:25 pm

gustafn

- fix and standardize quoting in template properties

Options
    • -2
    • +2
    ./alerts.adp
    • -2
    • +2
    ./home.adp
    • -2
    • +2
    ./unsubscribe-2.adp
    • -2
    • +2
    ./unsubscribe.adp
  5. … 393 more files in changeset.
Monday 27 Oct 2014
5:38 pm

victorg

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

Options
    • -1
    • +1
    ./alerts.adp
    • -3
    • +3
    ./alerts.tcl
    • -1
    • +1
    ./hide-email.tcl
    • -1
    • +1
    ./home.adp
    • -1
    • +1
    ./set-on-vacation-to-null.adp
    • -2
    • +2
    ./set-on-vacation-to-null.tcl
    • -1
    • +1
    ./set-on-vacation-until.adp
    • -2
    • +2
    ./set-on-vacation-until.tcl
    • -2
    • +2
    ./toggle-dont-spam-me-p.tcl
    • -1
    • +1
    ./unsubscribe-2.adp
    • -1
    • +1
    ./unsubscribe.adp
  12. … 2537 more files in changeset.
Tuesday 05 Aug 2014
11:49 am

gustafn

- check ids in page contracts

Options
    • -1
    • +1
    ./hide-email.tcl
  2. … 40 more files in changeset.
Thursday 10 Oct 2013
11:00 pm

gustafn

- use numeric comparison for truth values

Options
    • -3
    • +3
    ./alerts.tcl
  2. … 16 more files in changeset.