OpenACS / openacs-4 / packages / acs-subsite

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 43
Last Commit: 17 Dec
Commits this week: 0
Total Lines of Code (LoC): 9,856
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 28 Oct 2020
4:39 pm

hectorr

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

Options
    • -2
    • +2
    ./apm-callback-procs.tcl
    • -2
    • +2
    ./attribute-procs.tcl
  3. … 57 more files in changeset.
Saturday 17 Oct 2020
6:40 pm

gustafn

prefer db_0or1row for exists-queries

Options
    • -4
    • +2
    ./group-procs.tcl
Sunday 27 Sep 2020
1:12 pm

gustafn

support passing a dict as argument to "group::update" (not only array)

Options
    • -12
    • +19
    ./group-procs.tcl
Thursday 03 Sep 2020
11:16 am

gustafn

prefer db_0or1row +"where exists" over db_string + "select case"

Options
    • -5
    • +3
    ./attribute-procs.tcl
  2. … 3 more files in changeset.
Tuesday 01 Sep 2020
7:37 pm

antoniop

Improve sql portability

Options
    • -5
    • +7
    ./attribute-procs.tcl
    • -4
    • +6
    ./group-procs.tcl
    • -6
    • +10
    ./group-type-procs.tcl
    • -3
    • +6
    ./subsite-procs.tcl
    • -12
    • +15
    ./test/acs-subsite-procs.tcl
  6. … 1 more file in changeset.
4:32 pm

antoniop

Replace limit with a portable idiom

Options
    • -5
    • +5
    ./group-procs.tcl
Monday 31 Aug 2020
2:42 pm

antoniop

Make apm callbacks private and move them together with the others

Options
    • -0
    • +70
    ./apm-callback-procs.tcl
    • -73
    • +1
    ./subsite-procs.tcl
Friday 28 Aug 2020
6:45 pm

antoniop

When a new group is created, flush all the group::get_id caches with the same name so that the new group has a chance to be retrieved

Note that it is wrong to assume a group_name will be unique, although this is normally not far from the truth in our everyday practice

Options
    • -1
    • +7
    ./group-procs.tcl
6:42 pm

antoniop

Cover more group api

this also exposes a potential problem with group::get_id when a group is created, deleted, and then a new one is created with the same name (e.g. executing the test multiple times). As the memoize cache is not maintained, the returned group_id will be incorrect.

Options
    • -1
    • +18
    ./test/acs-subsite-procs.tcl
5:25 pm

antoniop

Increase proc coverage

Options
    • -1
    • +3
    ./test/acs-subsite-procs.tcl
Tuesday 25 Aug 2020
3:42 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./test/acs-subsite-procs.tcl
3:38 pm

antoniop

acs-lang reform

Provide an optional object_id which can be used to register message keys that will be bound to the lifecycle of an acs-object. When the object is deleted, so will the message key.

This is useful for groups that automatically define a message key for their pretty name. Tcl api was already aware of this and would cleanup such message keys, but other idioms e.g. stored procedures used to delete groups would leave leftovers behind. These can become relatively numerous on group-intensive systems such as LEARN.

Other future usages for this new feature might be the automatic localization of xowiki FormPage properties.

Options
    • -2
    • +5
    ./group-procs.tcl
  2. … 9 more files in changeset.
2:57 pm

antoniop

New test checking that no leftover groups localizations are still there on the system

Options
    • -1
    • +16
    ./test/acs-subsite-procs.tcl
2:43 pm

antoniop

Cleanup test message key

Options
    • -1
    • +4
    ./test/acs-subsite-procs.tcl
2:40 pm

antoniop

Test covering the automagical localization of group pretty names

Options
    • -1
    • +48
    ./test/acs-subsite-procs.tcl
Sunday 23 Aug 2020
2:16 pm

gustafn

fix for issue #3445

a broken query (without a table alias) was

in the .xql file, where the correct query was

in the source (where it was ignored). This

can be quite confusing. It is probably

a good idea to improve code locality

and use .xql just in cases, where the

query is NOT included in the source.

I took the opportunity to fix more such cases

in this file.

Many thanks to Tony Kirkham for the bug report.

CVS: ----------------------------------------------------------------------

Options
    • -104
    • +0
    ./attribute-procs.xql
Saturday 08 Aug 2020
1:19 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./package-procs.tcl
  2. … 16 more files in changeset.
Tuesday 21 Jul 2020
4:06 pm

gustafn

use "ad_file" as a means to avoid unexpected tilde substitution in file names

Options
    • -5
    • +5
    ./subsite-navigation-procs.tcl
    • -5
    • +5
    ./subsite-procs.tcl
  3. … 11 more files in changeset.
3:58 pm

gustafn

prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

Options
    • -6
    • +6
    ./application-group-procs.tcl
    • -4
    • +4
    ./package-procs.tcl
    • -2
    • +2
    ./rel-segments-procs.tcl
    • -2
    • +2
    ./subsite-procs.tcl
  5. … 15 more files in changeset.
Friday 03 Jul 2020
9:43 am

gustafn

mprove spelling: move closer to the linux documentation recommendations, standardize variable names

Options
    • -2
    • +2
    ./attribute-procs.tcl
    • -7
    • +7
    ./group-procs.tcl
    • -3
    • +3
    ./package-procs.tcl
    • -3
    • +3
    ./plsql-utility-procs.tcl
    • -3
    • +3
    ./subsite-procs.tcl
  6. … 15 more files in changeset.
Tuesday 19 May 2020
9:15 pm

gustafn

acs::per_request_cache: standardize per-request caching

- added per-request cache verfsy similar to acs::per_thread_cache

- use per-request-cache on several occasions

- bump version number of acs-tcl to 5.10.0d35

Options
    • -19
    • +11
    ./package-procs.tcl
  2. … 9 more files in changeset.
Sunday 03 May 2020
7:00 pm

gustafn

prefer dict over array

Options
    • -4
    • +4
    ./subsite-procs.tcl
Tuesday 03 Mar 2020
7:38 pm

hectorr

Do not convert into upper case the 'id_column' attribute in 'acs_object_types' for group types. This attribute was upper case, both in oracle and postgres, causing a discrepancy with the column real name, found by the 'datamodel__acs_object_type_check' test case. The package upgrade fixes the already existing attributes in postgres.

Options
    • -0
    • +13
    ./apm-callback-procs.tcl
    • -2
    • +2
    ./group-type-procs.tcl
    • -1
    • +1
    ./group-type-procs.xql
  4. … 1 more file in changeset.
6:47 pm

hectorr

Restrict upgrade logic to postgres, as mentioned in previous commit

Options
    • -6
    • +8
    ./apm-callback-procs.tcl
6:35 pm

hectorr

Normalize case of 'table_name' attribute in 'acs_object_types' for group types to lower case, in postgres. This attribute was created in upper case, causing a discrepancy with the table real name. As this is now fixed by a previous commit, this package upgrade fixes the already existing attributes.

Options
    • -0
    • +11
    ./apm-callback-procs.tcl
  2. … 1 more file in changeset.
5:13 pm

hectorr

Whitespace changes

Options
    • -39
    • +31
    ./group-type-procs-oracle.xql
5:11 pm

hectorr

Only convert table names to uppercase, during group type creation, on oracle. This was producing case mixed issues on postgres installations, where the table_name attribute on 'acs_object_types' was upppercase, while the real table name was lowercase, as detected by the 'datamodel__acs_object_type_check' test case.

Options
    • -1
    • +1
    ./group-type-procs-oracle.xql
    • -2
    • +2
    ./group-type-procs.tcl
Sunday 09 Feb 2020
4:23 pm

gustafn

added missing editor hints

Options
    • -0
    • +6
    ./group-init.tcl
  2. … 20 more files in changeset.
Wednesday 08 Jan 2020
6:48 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -21
    • +0
    ./attribute-procs-oracle.xql
    • -31
    • +0
    ./attribute-procs-postgresql.xql
    • -7
    • +34
    ./attribute-procs.tcl
2:47 pm

antoniop

Qualify 'callback' proc in the global namespace, lest it might conflict with 'subsite::callback'

Options
    • -3
    • +2
    ./subsite-procs.tcl