• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Test covering the automagical localization of group pretty names

fix for issue #3445

a broken query (without a table alias) was

in the .xql file, where the correct query was

in the source (where it was ignored). This

can be quite confusing. It is probably

a good idea to improve code locality

and use .xql just in cases, where the

query is NOT included in the source.

I took the opportunity to fix more such cases

in this file.

Many thanks to Tony Kirkham for the bug report.

CVS: ----------------------------------------------------------------------

improve spelling

  1. … 16 more files in changeset.
use "ad_file" as a means to avoid unexpected tilde substitution in file names

  1. … 11 more files in changeset.
prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

  1. … 15 more files in changeset.
mprove spelling: move closer to the linux documentation recommendations, standardize variable names

  1. … 15 more files in changeset.
acs::per_request_cache: standardize per-request caching

- added per-request cache verfsy similar to acs::per_thread_cache

- use per-request-cache on several occasions

- bump version number of acs-tcl to 5.10.0d35

  1. … 9 more files in changeset.
prefer dict over array

Do not convert into upper case the 'id_column' attribute in 'acs_object_types' for group types. This attribute was upper case, both in oracle and postgres, causing a discrepancy with the column real name, found by the 'datamodel__acs_object_type_check' test case. The package upgrade fixes the already existing attributes in postgres.

  1. … 1 more file in changeset.
Restrict upgrade logic to postgres, as mentioned in previous commit

Normalize case of 'table_name' attribute in 'acs_object_types' for group types to lower case, in postgres. This attribute was created in upper case, causing a discrepancy with the table real name. As this is now fixed by a previous commit, this package upgrade fixes the already existing attributes.

  1. … 1 more file in changeset.
Whitespace changes

Only convert table names to uppercase, during group type creation, on oracle. This was producing case mixed issues on postgres installations, where the table_name attribute on 'acs_object_types' was upppercase, while the real table name was lowercase, as detected by the 'datamodel__acs_object_type_check' test case.

added missing editor hints

  1. … 20 more files in changeset.
Reduce divergency between oracle and postgres codebase

Qualify 'callback' proc in the global namespace, lest it might conflict with 'subsite::callback'

Whitespace cleanup

Reduce divergency between oracle and postgres codebase

Replace deprecated idiom

Rename subsite_callback to comply with OpenACS naming convention, reduce divergency between oracle and postgres codebase

    • -21
    • +0
    ./subsite-callback-procs-oracle.xql
    • -22
    • +0
    ./subsite-callback-procs-postgresql.xql
Move rel_segments_* procs in new rel_segment:: namespace to comply with OpenACS naming convention, create deprecated wrappers, replace occurrences

  1. … 5 more files in changeset.
Whitespace cleanup

add missing SQL query

prefer all caps spelling for SQL

  1. … 2 more files in changeset.
Take care of removing the automatically generated group name translation when deleting the group

Correct inconsistent message key creation between group::new (underscore) and group update (dot)

improve spelling

  1. … 6 more files in changeset.
Close bracket and enjoy the fruits of automated testing

improve spelling

  1. … 18 more files in changeset.
Add a test about group membership for tcl api as well (will right now fail on direct membership)