• last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix typos

Fix priority check in 'acs_mail_lite_inbound_procs_check' test case

warn about unexpected entries (typos) in EmailDeliveryMode

Index acs_mail_lite_queue(package_id)

    • -1
    • +3
    ./sql/postgresql/acs-mail-lite-create.sql
file upgrade-5.10.0d11-5.10.0d12.sql was initially added on branch oacs-5-10.

Add a second period to new lines starting with one ('dot-stuffing'), as defined by RFC 5321 section 4.5.2, before sending mail via nssmptd.

According to the RFC:

- "Before sending a line of mail text, the SMTP client checks the

first character of the line. If it is a period, one additional period is inserted at

the beginning of the line."

- "When a line of mail text is received by the SMTP server, it checks the line. If the

line is composed of a single period, it is treated as the end of mail indicator. If

the first character is a period and there are other characters on the line, the first

character is deleted."

This change adds the second period at the beginning of a line suggested in the first

paragraph, preventing nssmptd from deleting dots by acting as mentioned in the second one.

In the case of lines comprised of just a single period, '::mime::qp_encode' already takes

care of them by converting the '.' into '=2E', so they are not affected by this.

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

  1. … 57 more files in changeset.
make packages in principle installable under PG 13+

    • -2
    • +2
    ./sql/postgresql/acs-mail-lite-create.sql
  1. … 19 more files in changeset.
Use only 100 objects for the test, as in large instances this can take several minutes

Improve sql portability

Replace limit (pg only) with fetch idiom, which should be portable on "modern" Oracle

Fix typo in description

Drop duplicate index 'acs_mail_lite_from_external_aml_email_id_idx'. Postgres creates automatically indexes for unique constraints and primary keys, this index duplicates 'acs_mail_lite_from_external_pkey'

    • -3
    • +1
    ./sql/postgresql/acs-mail-lite-create.sql
    • -2
    • +1
    ./sql/postgresql/acs-mail-lite-drop.sql
file upgrade-5.10.0d10-5.10.0d11.sql was initially added on branch oacs-5-10.

Whitespace changes

    • -64
    • +64
    ./sql/postgresql/acs-mail-lite-create.sql
    • -6
    • +3
    ./sql/postgresql/acs-mail-lite-drop.sql
Drop duplicate index 'acs_mail_lite_send_msg_id_map_msg_id_idx'. Postgres creates automatically indexes for unique constraints and primary keys, this index duplicates 'acs_mail_lite_send_msg_id_map_pkey'

    • -4
    • +1
    ./sql/postgresql/acs-mail-lite-create.sql
    • -2
    • +1
    ./sql/postgresql/acs-mail-lite-drop.sql
file upgrade-5.10.0d9-5.10.0d10.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0d9-5.10.0d10.sql
mprove spelling: move closer to the linux documentation recommendations

    • -2
    • +2
    ./tcl/acs-mail-lite-callback-procs.tcl
    • -4
    • +4
    ./www/doc/incoming-email-legacy-notes.adp
  1. … 17 more files in changeset.
improve wording for package parameters

add EmailDeliveryMode 'ignore'. Similar to 'log' but less verbose.

use 'ignore' in case 'redirect' is set wihout a value for EmailRedirectTo

fall back to 'log' mode, when EmailDeliveryMode "redirect" is used without "EmailRedirectTo" value

add turkish message catalog

    • -0
    • +23
    ./catalog/acs-mail-lite.tr_TR.utf-8.xml
file acs-mail-lite.tr_TR.utf-8.xml was initially added on branch oacs-5-10.

    • -0
    • +0
    ./catalog/acs-mail-lite.tr_TR.utf-8.xml
Fix parameter name in acs-mail-lite

- acs_mail_lite::send_immediately: new switch for "-force_delivery_mode"

to force delivery mode for a single call (ignoring package parameter

"EmailDeliveryMode")

- New potential value for "EmailDeliveryMode": "nssmtpd"

When this parameter is specified, the behavior is like

"smtp", but the code tries use the SMTP implementation

of the nssmtpd NaviServer module.

- It is also possible to combine "nssmtpd" with the delivery methods

"filter" or "redirect" simply by writing e.g. "filter nssmtpd"

- some refactoring to avoid repeated code

    • -51
    • +104
    ./tcl/acs-mail-lite-procs.tcl
Use optionally nssmtpd as different mail delivery agent

when the "-experimental" flag is provided to

acs_mail_lite::send_immediately, and the NaviServer

nssmtpd modules is installed.

whitespace changes

    • -42
    • +115
    ./tcl/acs-mail-lite-procs.tcl
added missing editor hints

    • -0
    • +6
    ./www/doc/incoming-email-legacy-notes.tcl
  1. … 7 more files in changeset.
Rename 'random', 'randomInit' and 'randomRange' procs to something compliant to OpenACS naming convention, replace occurrences, create deprecated wrapper

    • -29
    • +29
    ./tcl/test/email-inbound-procs.tcl
  1. … 6 more files in changeset.