• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Deprecate exists_and_not_null proc as it does not comply with openacs naming convention and can be replaced with plain tcl idioms

    • -2
    • +2
    ./www/doc/incoming-email-legacy-notes.adp
  1. … 3 more files in changeset.
Rename build_mime_message to ad_build_mime_message to comply with naming convention, replace occurrences, create deprecated wrapper

  1. … 5 more files in changeset.
moved "safe_eval" under the "ad_" prefix and marked the original function as deprecated

  1. … 2 more files in changeset.
improve spelling

    • -2
    • +2
    ./sql/postgresql/acs-mail-lite-create.sql
Replace deprecated api in this weird adp

    • -18
    • +18
    ./www/doc/incoming-email-legacy-notes.adp
provide proper title properties in .adp files to reduce warnings in log files

    • -1
    • +1
    ./www/doc/incoming-email-legacy-notes.adp
Prefer '==' over 'eq' on numeric comparison

  1. … 2 more files in changeset.
Keep accepting empty values as proper ids, as deprecated ad_var_type_check_integer_p would have done

replace deprecated functions ad_var_type_check_integerlist_p and ad_var_type_check_number_p

whitespace changes

avoid usage of ad_var_type_check_integer_p

(use Tcl idiom "string is integer -strict" instead)

improve spelling

  1. … 21 more files in changeset.
Speed up referential integrity by avoiding sequential scans

    • -1
    • +9
    ./sql/postgresql/acs-mail-lite-create.sql
    • -0
    • +24
    ./sql/postgresql/upgrade/upgrade-5.10.0d6-5.10.0d7.sql
Removed obsolete @arch-tag

    • -4
    • +1
    ./tcl/acs-mail-lite-callback-procs.tcl
  1. … 25 more files in changeset.
Fix typo

max test cases explicit

Enable ns_imap dependent tests only when this is installed.

    • -57
    • +70
    ./tcl/test/email-inbound-procs.tcl
Fix typo

Un-deprecate acs_mail_lite::bounce_address

Whitespace cleanup

    • -29
    • +26
    ./tcl/test/email-inbound-procs.tcl
Whitespace changes

    • -33
    • +33
    ./tcl/acs-mail-lite-callback-procs.tcl
Rename 'bounce-procs.xql' -> 'email-inbound-procs.xql'

    • -0
    • +72
    ./tcl/email-inbound-procs.xql
Move leftover procs in 'bounce-procs.tcl' and 'incoming-mail-procs.tcl' into 'email-inbound-procs.tcl'

Move and deprecate legacy inbound procs into 'legacy-inbound-procs.tcl'

    • -0
    • +388
    ./tcl/legacy-inbound-procs.tcl
    • -0
    • +23
    ./tcl/legacy-inbound-procs.xql
Discriminate proc scheduling by 'IncomingMode' in acs-mail-lite initialization

Whitespace changes

Deprecate 'acs-mail-lite::get_parameter', just a wrapper for 'parameter::get', used almost nowhere.

Add new 'acs-mail-lite' parameter 'IncomingMode'. Bump version number.

Fix typos and duplicated word

Whitespace cleanup

    • -170
    • +170
    ./tcl/email-inbound-procs.tcl