• last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fix for bug #3338

modernize Tcl code

prefer ad_try over catch, simplify expression

fix typos

Protect Tcl's file operations against leading dashes in file names

change "fetch first 1 row only" to "limit 1" to generic xql file, since Oracle started to support fetch first only with version 12c

merge with changes from https://github.com/tekbasse/acs-mail-lite/tree/master/tcl

in essence, these changes provide support for handling email with attachments based on nsIMAP.

see https://openacs.org/forums/message-view?message_id=5378972 for more background

    • -5
    • +134
    ./acs-mail-lite-callback-procs.tcl
    • -0
    • +20
    ./acs-mail-lite-procs-postgresql.xql
    • -0
    • +2434
    ./email-inbound-procs.tcl
    • -0
    • +877
    ./imap-inbound-procs.tcl
    • -0
    • +442
    ./maildir-inbound-procs.tcl
    • -0
    • +737
    ./test/email-inbound-procs.tcl
  1. … 59 more files in changeset.
whitespace cleanup

Shorten overlong lines

Use "ad_try" instead of "with_finally"

Fix typo

  1. … 1 more file in changeset.
Backport from HEAD

  1. … 1 more file in changeset.
Reduce divergence between oracle and postgres codebase, fix postgres only idiom in xql file

    • -20
    • +0
    ./acs-mail-lite-procs-postgresql.xql
Reduce divergence between oracle and postgres codebase, fix typo

Bug fix: avoid confusion between command argument and option, when argument starts with "-"

  1. … 81 more files in changeset.
Bug fix: avoid confusion between test argument and option, when text starts with "-"

Many thanks to Franz Penz

whitespace changes

merged changes from the oacs-5-9 branch and resolved conflicts

    • -15
    • +14
    ./acs-mail-lite-callback-procs.tcl
  1. … 7828 more files in changeset.
Fix spelling errors

  1. … 10 more files in changeset.
Improve robustness of "file delete" operations

  1. … 18 more files in changeset.
- add safety-belt for subject lines: in case the string passed in for the subject line contains CRLF, the produced mail might end up destroyed. so remove crlf and add a warning, in case it happens (client bug)

- remove one more assumption that the "base" configuration is always using the http driver

- fix typo

- get variable from ns_set

  1. … 1 more file in changeset.
- remove editing-bug

- make sure to pass always object_id to acs_mail_lite::send_immediately

- perform cleanup and call callback as well in error situations

to be able to handle failed smtp deliveries

- add optional arguments "-status" and "-errorMsg" to interface

of callback acs_mail_lite::send

- prefer ns_quotehtml over ad_quotehtml

  1. … 28 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 748 more files in changeset.
- don't use errorInfo as variable name, if just error message is meant

- standardize url construction