• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
bugfix: provide proper encoding for text phrases in email addresses

Previously, mails to addresses of the form

PHRASE <USER@HOST>

where PHRASE contains UTF-8 were sent without the required encoding.

One many systems, this was perfectly fine, but on some, these

where leading to mangled characters. Now, the "to_addr" adresseses

and the "from_addr" address of acs_mail_lite::send_immediately

are properly encoded. Note, that "to_addr" is a list of addresses.

Many thanks to Franz Penz for reporting this.

improved spelling

  1. … 2 more files in changeset.
Basic test of acs_mail_lite::send

file acs-mail-lite-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/acs-mail-lite-procs.tcl
Make acs_mail_lite::utils::build_body, replace (commented) references in other packages

  1. … 1 more file in changeset.
improve spelling

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 33 more files in changeset.
replace occurrences of <br/> in api doc strings

  1. … 2 more files in changeset.
Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

  1. … 11 more files in changeset.
improve spelling

Reduce number of queries, improve documentation

Queries could be made even less e.g. by locking and querying the tuples in one statement. However, it would be trickyer to make the code portable.

Simplify nsv idiom

Simplify documentation

Fix typo in doc

Fixes for Oracle 19c: replaced "limit" by the portable idiom "fetch ... rows only"

This fixes the following bug in Oracle installations:

: SQL:

: select aml_email_id from acs_mail_lite_from_external

: where processed_p <>'1'

: and release_p <>'1'

: order by priority

: !>>>!limit :email_max_ct

: nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00933: SQL command not properly ended

Deprecate util_ns_set_to_list: ns_set array is an equivalent oneliner

  1. … 4 more files in changeset.
improve spelling

  1. … 42 more files in changeset.
fix for issue #3463

Many thanks to Tony Kirkham for the fix!

Replace deprecated 'acs_mail_lite::utils::valid_email_p' with 'util_email_valid_p'

Deprecate 'acs_mail_lite::utils::valid_email_p', as it is duplicated by 'util_email_valid_p'. It was not deleted because it was a public proc recently turned to private.

reduce public footprint

replace low-level cr_fs_path by higher level interface content::revision::get_cr_file_path

  1. … 7 more files in changeset.
Deprecate acs_mail_lite::message_interpolate in favor of 'string map'

Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 3 more files in changeset.
Make api deprecated, complies with acs-api-browser.graph__bad_calls automated test

mark functions called only internally as private

  1. … 12 more files in changeset.
improve listing of test coverage

  1. … 8 more files in changeset.
Add default to avoid empty values. Fixes 'acs_mail_lite_inbound_procs_check' test case

make listing of tested procs more complete

  1. … 6 more files in changeset.
Handle to_addr specified as "DisplayName <email>": keep the display name in the header value and strip it in the RCPT TO