• last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Prefer '==' over 'eq' on numeric comparison

  1. … 2 more files in changeset.
Keep accepting empty values as proper ids, as deprecated ad_var_type_check_integer_p would have done

replace deprecated functions ad_var_type_check_integerlist_p and ad_var_type_check_number_p

whitespace changes

avoid usage of ad_var_type_check_integer_p

(use Tcl idiom "string is integer -strict" instead)

Removed obsolete @arch-tag

  1. … 25 more files in changeset.
Fix typo

max test cases explicit

Enable ns_imap dependent tests only when this is installed.

Fix typo

Un-deprecate acs_mail_lite::bounce_address

Whitespace cleanup

Whitespace changes

    • -33
    • +33
    ./acs-mail-lite-callback-procs.tcl
Rename 'bounce-procs.xql' -> 'email-inbound-procs.xql'

    • -0
    • +72
    ./email-inbound-procs.xql
Move leftover procs in 'bounce-procs.tcl' and 'incoming-mail-procs.tcl' into 'email-inbound-procs.tcl'

Move and deprecate legacy inbound procs into 'legacy-inbound-procs.tcl'

    • -0
    • +388
    ./legacy-inbound-procs.tcl
    • -0
    • +23
    ./legacy-inbound-procs.xql
Discriminate proc scheduling by 'IncomingMode' in acs-mail-lite initialization

Whitespace changes

Deprecate 'acs-mail-lite::get_parameter', just a wrapper for 'parameter::get', used almost nowhere.

Fix typos and duplicated word

Whitespace cleanup

Remove redundant query definitions

    • -20
    • +0
    ./acs-mail-lite-procs-postgresql.xql
only lowercase meta-data is recognized

improve Tcl code

acs_mail_lite::incoming_email calls deprecated acs_mail_lite::parse_bounce_address. Comment, that this should not stay so.

improve spelling

  1. … 12 more files in changeset.
Use more API

Note that now we assume email and user_id will be from parties that actually belong to the system

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Rework variable assigning loops (set -> lassign) + Whitespace changes

  1. … 13 more files in changeset.
remove duplicated words

  1. … 9 more files in changeset.