• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merged oacs-5-6 to HEAD. HEAD now installs and passes all core tests. There

may still be some lingering problems due to my screwing up the oacs-5-6

branch earlier, I'll be looking into this later.

  1. … 212 more files in changeset.
- fix test files__tcl_file_common_errors

- report errors as such in aa-test (wrote warnings into error log, this was ignored since ages)

- fixed naming in acs-tcl, acs-mail-lite and acs-subsite

  1. … 3 more files in changeset.
Implements TIP #140. Rollout support params are package parameters now (instead of config.tcl ones). ns_sendmail is now deprecated but provided as a wrapper to acs_mail_lite::send for backward compatibility.

  1. … 1 more file in changeset.
Added comment to explain Dcc vs Bcc

Rolling back Victor's change. DCC is correct (BCC wouldn't work as expected).

most likely the author meant BCC instead of DCC.

Added rollout support without using ns_sendmail anymore. Beware that the email message will be print out to the log raw, so if there are attachments, they will be print out too.

Remove complex-send as agreed in TIP#127

    • -103
    • +0
    ./complex-send-procs-postgresql.xql
  1. … 16 more files in changeset.
the arg is -paramter not -name to parameter::get_from_package_key, not sure how this ever worked...

remove duplicate procs bounce_prefix and address_domain which live in incoming-mail-procs.tcl and bounce-procs.tcl

- eliminated dead code

Fix typo user should be user_id

- reduce lock contention with other background jobs scheduled at full minutes

  1. … 1 more file in changeset.
TIP#127 Add object_id as optional parameter to acs_mail_lite::send

Envelope sender disappeared during the refactoring of send between 5.3 and 5.4 and therefore was set using the from address. This led messages to be identified as junk by SPF, and bounces to be sent back to the user. This is a fix that puts the correct envelope sender back.

Since acs_mail_lite::send now accepts a multiple TO address, the user_id part of the bounce address it set to 0 if there are multiple recipients.

Envelope sender disappeared during the refactoring of send between 5.3 and 5.4 and therefore was set using the from address. This led messages to be identified as junk by SPF, and bounces to be sent back to the user. This is a fix that puts the correct envelope sender back.

Since acs_mail_lite::send now accepts a multiple TO address, the user_id part of the bounce address it set to 0 if there are multiple recipients.

fix bug, where months higher equal 08 lead to problems due to octal interpretation (can't use invalid octal number as operand...), aborting immediate ma

il sends in aug. or later.

fix bug, where months higher equal 08 lead to problems due to octal interpretation (can't use invalid octal number as operand...), aborting immediate mail sends in aug. or later.

Fix 3087 reordering the insert by putting the clob ones (cc, bcc, body and extraheaders) at the end to avoid crash on oracle 10g.

    • -10
    • +10
    ./acs-mail-lite-procs-oracle.xql
Merged from 5.4.2

  1. … 280 more files in changeset.
Add feature to allow incoming email to create new bugs

  1. … 5 more files in changeset.
mime::encode (tclllib 1.8 and 1.10) doesn't encode the question mark which is a character used as a delimiter for the content of the subject of an email message. That would cause email clients to interpret it incorrectly.

Removed the check for tcllib 1.10 to use our proc in all cases.

Add reply_to column necessary to sweeper proc in call acs_mail_lite::send_immediately

Ooops, forgot to rename a variable

Reodered the steps to build the message parts first, then add the headers using mime::setheaders (except To, From, CC and BCC). Retrieve the message as a string only if delivery mode is not set to default (smtp). Tested successfully with tcllib 1.8 and 1.10 (unless I missed something)

After discussion in the OCT, rolled this back. And leave it rolled back.

Fixed problem with complex send not knowing about the new valid_email_p procedure. additionally made sure that no empty header could be passed, as this breaks smtp::sendmail

Fix bug in subject encoding proc

Added an explicit blank body to two callbacks added by Malte, so automated

tests will pass. This is about the third release in which I've had to do

this. Simply adding "-" after the empty doc comment block is sufficient,

ad_proc treats that as an empty body.

Removed these two procs entirely, since a search of packages and contrib shows

that nothing in our tree uses them (and no package outside of acs-mail-lite

should've used them in the first place).