acs-content-repository

  • last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Aantoniop%3A20240423144330

currently, file-storage will copy files by simply copying the revision entry of the new file from the original one. This means that copied files will in fact point to the same filesystem file of the original.

This "works" because the file-storage api will currently never delete a file from the filesystem, so deleting the original file will not affect the copies.

This behavior is probably not ideal, but we won't address it before the release, as to change it will most likely require some careful planning, in particular for existing installations.

Prevent sneaking symlinks in the content repository

Many thanks to Thomas Rennner and Günter Ernst for analyzing the issue

cr_write_content reform

when serving files, do not trust the content information, as the absolute path to the file can be determined programmatically in this case.

This also reduce divergency between Oracle and Postgres

Add new extension mjs, for Javascript modules, to the Javascript mime type

    • -0
    • +32
    ./sql/oracle/upgrade/upgrade-5.10.1b3-5.10.1b4.sql
file upgrade-5.10.1b3-5.10.1b4.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.1b3-5.10.1b4.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.1b3-5.10.1b4.sql
deprecate unused command cr_check_orphaned_files

    • -2
    • +2
    ./tcl/acs-content-repository-procs.tcl
Cleanup of external binaries: always use "util::which" to resolve binaries

Furthermore, this change makes the handling of "identify" consistent

with "convert". Before, the parameter "ImageMagickIdentifyBinary"

could not be modified via the parameter settings, only

"ImageMagickConvertBinary" was defined.

Bump version number to 5.10.1b3 to pick up additional parameter.

Handle differences in data-model between oracle and postgres, where oracle uses an additional filename column in the cr_revisions table when a revision points to a file

Many thanks to Josue Cardona for reporting the regression

Increase proc coverage

    • -1
    • +31
    ./tcl/test/content-revision-test-procs.tcl
Reitroduce missing query clause that should be executed when we retrieve the content of a text/* content item

    • -0
    • +7
    ./tcl/content-item-procs-postgresql.xql
Test that when content::item::get_content is called on a text/* mime typed content-item, an extra "text" attribute should be returned in the result array

This currently fails because of a missing query in the xql

    • -1
    • +10
    ./tcl/test/content-item-test-procs.tcl
Redefine content_item__get_virtual_path so that get_virtual_path__root_folder_id argument is not ignored

file upgrade-5.10.1b1-5.10.1b2.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.1b1-5.10.1b2.sql
Test content::item::get_virtual_path

This will expose a logn standing bug where the root_folder_id argument is ignored

    • -1
    • +26
    ./tcl/test/content-item-test-procs.tcl
Extend test suite

    • -1
    • +14
    ./tcl/test/content-item-test-procs.tcl
Test content::item::get_root_folder

    • -1
    • +27
    ./tcl/test/content-item-test-procs.tcl
Remove broken line (non-existing arguments)

Increase api coverage, this uncovered a bug in content::item::unpublish

    • -1
    • +24
    ./tcl/test/content-item-test-procs.tcl
Test content::item::get_publish_date

    • -4
    • +34
    ./tcl/test/content-item-test-procs.tcl
Extend test to include content::item::get_path

    • -4
    • +27
    ./tcl/test/content-item-test-procs.tcl
Whitespace cleanup

    • -3
    • +3
    ./tcl/test/content-item-test-procs.tcl
Test content::item::get_descendants

    • -1
    • +115
    ./tcl/test/content-item-test-procs.tcl
harden page contracts

  1. … 24 more files in changeset.
bumped version numbers to 5.10.1b1

  1. … 85 more files in changeset.
regenerated documentation

  1. … 281 more files in changeset.
Disable tests to check for executables on the system

    • -16
    • +20
    ./tcl/test/acs-content-repository-procs.tcl
  1. … 7 more files in changeset.
Prefer binary from parameter as everywhere else

Test external command line dependencies

    • -1
    • +17
    ./tcl/test/acs-content-repository-procs.tcl
fix incorrect names in .xql files

Fixed missing update_content-lob.set_content

Added missing set_content SQL statement for updating revisions stored in LOBs.

This statement was already missing in the release of OpenACS 5.10.0.

LOBs are for PostgreSQL somewhat depreacted and these are just there for

legacy applications.

    • -2
    • +9
    ./tcl/content-revision-procs-postgresql.xql