OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 07 Mar 2022
5:00 pm

gustafn

no need to sort already sorted sequence

This problem was introduced via the ns_strcoll support which is not sufficiently clever on numbers.

We should support for numerical sort when needed (which seems rare enough)

Options
    • -4
    • +2
    /openacs-4/packages/xowiki/tcl/tree-procs.tcl
    • -13
    • +35
    /openacs-4/packages/xowiki/tcl/test/includelet-test-procs.tcl
    • -1
    • +0
    /openacs-4/packages/xowiki/tcl/test/tree-procs.tcl
4:21 pm

antoniop

Test also that links rendered in the ToC point to an existing page

At least in the setup tested so far, links seem to contain the language prefix and would not be resolved correctly

Options
    • -0
    • +14
    /openacs-4/packages/xowiki/tcl/test/tree-procs.tcl
4:17 pm

antoniop

Improve comment

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/test/tree-procs.tcl
4:02 pm

gustafn

add test file for includelt testing, that does not require the full webtest overhead

Options
    • -0
    • +77
    /openacs-4/packages/xowiki/tcl/test/includelet-test-procs.tcl
4:02 pm

gustafn

file includelet-test-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xowiki/tcl/test/includelet-test-procs.tcl
3:54 pm

antoniop

Extend the test for the case where all links should be expanded

This tests also exposes issued with the sorting

Options
    • -0
    • +37
    /openacs-4/packages/xowiki/tcl/test/tree-procs.tcl
3:37 pm

antoniop

Extend test to start enforcing that the expected number of links is rendered and that the sorting is correct

This will expose that already in this simple case, we have that "100" comes before "2"

Options
    • -8
    • +58
    /openacs-4/packages/xowiki/tcl/test/tree-procs.tcl
3:06 pm

antoniop

Streamline idiom, fixes xowiki toc_includelet automated test

Options
    • -7
    • +4
    /openacs-4/packages/xowiki/tcl/tree-procs.tcl
3:04 pm

antoniop

Basic test where we render the ToC includelet

This test currently fails because of a bug concerning the ul_class variable

Options
    • -0
    • +83
    /openacs-4/packages/xowiki/tcl/test/tree-procs.tcl
3:04 pm

antoniop

file tree-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xowiki/tcl/test/tree-procs.tcl
2:24 pm

antoniop

Also allow to specify the page order

Options
    • -4
    • +13
    /openacs-4/packages/xowiki/tcl/test/test-procs.tcl
2:16 pm

antoniop

Allow to specify the content when requiring the page

Options
    • -2
    • +11
    /openacs-4/packages/xowiki/tcl/test/test-procs.tcl
Sunday 06 Mar 2022
7:00 pm

gustafn

Extend randomization of multiple alternatives for cases, where one alternative must be "true"

Certain evaluation schemes for multiple choice questions require that

at least one alternative must be true. Otherwise, a division by 0

might appear. This is an issue, when a subset of alternatives is used

(e.g. 3 out of 10 alternatives). The version know evaluation schemes

with such a requirement and makes sure that in the resulting set, at

least one correct alternative is correct. Note: this change does not

make sure that the full set of alternatives contains at least one

correct alternative.

Options
    • -6
    • +36
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
Saturday 05 Mar 2022
10:40 am

gustafn

Improve rebustness in error situations.

This change makes sure to always provide initialized aggregated values in case

that "dump read" fails to initialized these.

Options
    • -2
    • +9
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
10:35 am

gustafn

keep avoiding call "value_if_nothing_is_returned_from_form" for disabled field

This change reverts to the previous behavior and is logically sound.

All regression test continue to work. Not clear, why Antonio removed

this call (maybe due to downstream changes, but these should be

sorted out).

Options
    • -6
    • +9
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
10:28 am

gustafn

add test case for disabled checkbox (should be the same as for non-disabled case)

Options
    • -2
    • +14
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
10:27 am

gustafn

include field name in debug message

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
Friday 04 Mar 2022
10:11 pm

gustafn

add canvas evaluation scheme of MC questions

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -1
    • +1
    /openacs-4/packages/xowf/resources/prototypes/TestItemMC.form.page
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -4
    • +6
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
8:18 pm

gustafn

Undo the change trying to alter the order inside "add_pages"

The method is intended to preserve the order of the passed-in ordered

composite. Added comments to clarify it for people not so familiar with the

code.

Options
    • -7
    • +14
    /openacs-4/packages/xowiki/tcl/tree-procs.tcl
5:06 pm

antoniop

Port of downstream feature: optionally allow to instantiate the items before deletion in order to apply specific class logics

Options
    • -2
    • +14
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
4:24 pm

antoniop

Require form_parameter array consistently in the commands that need it

Options
    • -5
    • +8
    /openacs-4/packages/xotcl-core/tcl/context-procs.tcl
4:24 pm

trenner

execute configure proc after page was created

Options
    • -14
    • +14
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
4:19 pm

trenner

provide test for p.configure parameter

Options
    • -0
    • +60
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
3:55 pm

antoniop

Treat disabled form fields as they are: fields that the browser would not send to us and need to be treated "internally"

Options
    • -11
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -6
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
3:46 pm

hectorr

Fix quote_unquote_html test

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
3:33 pm

antoniop

Formatting change

Options
    • -6
    • +12
    /openacs-4/packages/xowiki/tcl/tree-procs.tcl
3:02 pm

antoniop

Use the page order as position, rather than an incremental number

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/tree-procs.tcl
11:53 am

gustafn

handle cases in name-validation/normalization, where the language comes from _nls_language rather than nls_language

Many thanks to Markus Moser for analyzing and identifying the problem.

Options
    • -3
    • +21
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
11:30 am

gustafn

fix typo

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
11:11 am

antoniop

Add missing test data

Options
    • binary
    /openacs-4/packages/proctoring-support/tcl/test/data/test.png