OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 146
Last Commit: 29 Jul
Commits this week: 0
Total Lines of Code (LoC): 7,561,801
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 15 Feb 2022
7:06 pm

gustafn

Fixes for Oracle 19c: quick port of missing tables in acs-mail-lite from PostgreSQL

This is q quick port of the table available from PostgreSQL, which

assures that a new instance of OpenACS on Oracle can run without

spitting out frequent error messages. In essence, the sequence

handling was adjusted, and datatype "text" was replaced by

"varchar(4000)" and in one case by "clob". Probably, some of the

lengths and the update operations have to be adjusted.

Options
    • -1
    • +349
    /openacs-4/packages/acs-mail-lite/sql/oracle/acs-mail-lite-create.sql
6:21 pm

gustafn

Fixes for Oracle 19c: boolean types in query

This fixes the following bug for Oracle:

[13/Feb/2022:17:53:36][8701.7f9f62f0b700][-conn:oacs-5-10-0:default:0:0-] Error: nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00920: invalid relational operator

:

: SQL:

:

: select p.package_id,

: p.instance_name,

: n.node_id,

: n.name,

: :subsite_url || n.name as url,

: (select count(*)

: from group_approved_member_map m

: where m.rel_type = 'membership_rel'

: and m.group_id = ag.group_id) as num_members,

: (select min(r2.member_state)

: from group_member_map m2,

: membership_rels r2

: where m2.group_id = ag.group_id

: and m2.member_id = :untrusted_user_id

: and r2.rel_id = m2.rel_id) as member_state,

: g.group_id,

: g.join_policy

: from site_nodes n,

: apm_packages p,

: application_groups ag,

: groups g

: where n.parent_id = :subsite_node_id

: and p.package_id = n.object_id

: and p.package_key in ('acs-subsite')

: and ag.package_id = p.package_id

: and g.group_id = ag.group_id

: and (g.join_policy !>>>!!= 'closed' or acs_permission.permission_p(p.package_id, :untrusted_user_id, 'read'))

: order by lower(instance_name)

:

Options
    • -1
    • +2
    /openacs-4/packages/acs-subsite/lib/subsites.xql
6:20 pm

gustafn

Fixes for Oracle 19c: boolean types in query

This fixes the following bug for Oracle:

': ORA-00920: invalid relational operator

:

: SQL:

: select p.package_id,

: p.instance_name,

: n.node_id,

: n.name

: from site_nodes n,

: apm_packages p,

: apm_package_types t

: where n.parent_id = :subsite_node_id

: and p.package_id = n.object_id

: and t.package_key = p.package_key

: and t.package_type = 'apm_application'

: and acs_permission.permission_p(p.package_id, :user_id, 'read')

: !>>>!order by upper(instance_name)

:

Options
    • -1
    • +3
    /openacs-4/packages/acs-subsite/lib/applications.tcl
6:10 pm

gustafn

Fixes for Oracle 19c: invalid cast to integer

This fixes the following bug for Oracle:

: invalid positional variable `:', valid values start with 1

: while executing

: "ns_ora 0or1row nsdb0 {

: select acs_permission.permission_p(:object_id, :party_id, :privilege)::integer from dual

: }"

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/acs-permissions-procs.tcl
6:00 pm

gustafn

fix editing bug

V: ----------------------------------------------------------------------

Options
    • -2
    • +1
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
5:57 pm

gustafn

Fixes for Oracle 19c boolean types in query

This fixes the following bug for Oracle:

: select u.user_id,

: u.authority_id,

: u.username,

: u.screen_name,

: u.priv_name,

: u.priv_email,

: u.email_verified_p,

: u.email_bouncing_p,

: u.no_alerts_until,

: u.last_visit,

: to_char(last_visit, 'YYYY-MM-DD HH24:MI:SS') as last_visit_ansi,

: u.second_to_last_visit,

: to_char(second_to_last_visit, 'YYYY-MM-DD HH24:MI:SS') as second_to_last_visit_ansi,

: u.n_sessions,

: u.password,

: u.salt,

: u.password_question,

: u.password_answer,

: u.password_changed_date,

: extract(day from current_timestamp - password_changed_date) as password_age_days,

: u.auth_token,

: mm.rel_id,

: mr.member_state !>>>!= 'approved' as registered_user_p,

: mr.member_state

: from users u

: left join group_member_map mm on mm.member_id = u.user_id

: and mm.group_id = mm.container_id

: and mm.group_id = :registered_users_group_id

: and mm.rel_type = 'membership_rel'

: left join membership_rels mr on mr.rel_id = mm.rel_id

: where u.user_id = :user_id

Options
    • -1
    • +2
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
5:51 pm

gustafn

improved error message

Options
    • -2
    • +3
    /openacs-4/packages/acs-lang/tcl/localization-procs.tcl
5:50 pm

gustafn

Fixes for Oracle 19c boolean types in query

This fixes the following bug for Oracle:

: SQL:

: select locale

: from ad_locales l

: where language = :language

: and enabled_p

: !>>>!and (default_p or not exists (select 1 from ad_locales

: where language = :language

: and locale <> l.locale))

:

Options
    • -5
    • +6
    /openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl
4:47 pm

antoniop

Subst commands as well, include the artifact is in the websocket message

Options
    • -2
    • +3
    /openacs-4/packages/proctoring-support/lib/proctoring-upload.tcl
4:14 pm

antoniop

Formatting changes

Options
    • -17
    • +19
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
3:36 pm

antoniop

Port the downstream only websocket enpoint

Options
    • -1
    • +2
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
    • -0
    • +21
    /openacs-4/packages/proctoring-support/lib/proctoring-websocket.tcl
    • -0
    • +4
    /openacs-4/packages/proctoring-support/www/websocket.adp
    • -0
    • +6
    /openacs-4/packages/proctoring-support/www/websocket.tcl
3:36 pm

antoniop

file proctoring-websocket.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/proctoring-support/lib/proctoring-websocket.tcl
3:36 pm

antoniop

file websocket.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/proctoring-support/www/websocket.tcl
3:36 pm

antoniop

file websocket.adp was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/proctoring-support/www/websocket.adp
3:11 pm

antoniop

Rename the file so it actually has an extension

Options
    • -1
    • +3
    /openacs-4/packages/proctoring-support/lib/proctoring-upload.tcl
2:54 pm

antoniop

Add extension to the filename so it is preserved

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-upload.tcl
2:46 pm

antoniop

Improve upgrade:

- make output more visible when executed in the apm

- when atjobs are available, schedule the upgrade to run in the background at the next restart

Options
    • -7
    • +30
    /openacs-4/packages/proctoring-support/tcl/apm-callback-procs.tcl
12:17 pm

antoniop

Dodument a rather convoluted query

Options
    • -0
    • +8
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
12:11 pm

antoniop

Improve doc

Options
    • -1
    • +3
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
12:09 pm

antoniop

Improve doc

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
12:08 pm

antoniop

Improve doc

Options
    • -7
    • +18
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
Monday 14 Feb 2022
5:49 pm

antoniop

Provide a showcase example of proctoring: admins will see the UI to examine results, regular users will start a proctored session

might be extended in the future

Options
    • -0
    • +2
    /openacs-4/packages/proctoring-support/www/display.adp
    • -0
    • +10
    /openacs-4/packages/proctoring-support/www/display.tcl
    • -0
    • +16
    /openacs-4/packages/proctoring-support/www/index.adp
    • -0
    • +14
    /openacs-4/packages/proctoring-support/www/index.tcl
    • -0
    • +25
    /openacs-4/packages/proctoring-support/www/proctored-index.adp
5:49 pm

antoniop

file display.adp was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/proctoring-support/www/display.adp
5:49 pm

antoniop

file proctored-index.adp was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/proctoring-support/www/proctored-index.adp
5:49 pm

antoniop

file index.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/proctoring-support/www/index.tcl
5:49 pm

antoniop

file index.adp was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/proctoring-support/www/index.adp
5:49 pm

antoniop

file display.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/proctoring-support/www/display.tcl
5:45 pm

antoniop

Fix typos in message keys

Options
    • -2
    • +2
    /openacs-4/packages/proctoring-support/proctoring-support.info
    • -7
    • +7
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.it_IT.ISO-8859-1.xml
Sunday 13 Feb 2022
8:31 pm

gustafn

fix cut&paste issue

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/tcl/subsite-callback-procs-postgresql.xql
5:46 pm

gustafn

Fixes for Oracle 19c recursive query

Oracle has a slightly differnt syntax for CTEs require arguments, keyword "recursive" is not allowed.

This fixes the following error during initial installation:

nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00905: missing keyword

SQL:

with recursive !>>>!object_hierarchy as (

select object_type, supertype

from acs_object_types

where object_type = coalesce(:object_type, (select object_type

from acs_objects

where object_id = :object_id))

union all

select t.object_type, t.supertype

from acs_object_types t,

object_hierarchy s

where t.object_type = s.supertype

)

select distinct callback, callback_type as type

from subsite_callbacks

where event_type = :event_type

and object_type in (select object_type from object_hierarchy)

Options
    • -0
    • +30
    /openacs-4/packages/acs-subsite/tcl/subsite-callback-procs-oracle.xql
    • -0
    • +30
    /openacs-4/packages/acs-subsite/tcl/subsite-callback-procs-postgresql.xql
    • -21
    • +2
    /openacs-4/packages/acs-subsite/tcl/subsite-callback-procs.tcl