OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 8
Total Committers: 146
Last Commit: 14:20
Commits this week: 8
Total Lines of Code (LoC): 7,560,931
Net change in LoC this week: 110

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 46 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 29 Oct 2019
2:56 pm

gernst

Strip of validation part before checking for the existence of query parameter

Options
    • -3
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
7:41 am

antoniop

No need to force-cache the value of every parameter of every package instance

We are just adding a new parameter: this should in fact not exist and therefore no cache should be present and needed to be flushed. Furthermore, in most cases one would immediately restart the server, as this normally happens in the context of a package upgrade.

Options
    • -5
    • +1
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
    • -10
    • +0
    /openacs-4/packages/acs-tcl/tcl/apm-procs.xql
Monday 28 Oct 2019
6:38 pm

antoniop

Replace deprecated idioms

Options
    • -3
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/community-core-test-procs.tcl
6:37 pm

antoniop

Replace deprecated idiom

Options
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
3:46 pm

antoniop

Fix typo in regexp command

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
8:18 am

gustafn

improve spelling

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
12:44 am

gustafn

handle missing nt_domcomp case without raising an error

Options
    • -2
    • +2
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
12:35 am

gustafn

add styling for preview exam

Options
    • -0
    • +15
    /openacs-4/packages/xowf/www/resources/test-item.css
12:35 am

gustafn

renamed style file

Options
    • -0
    • +11
    /openacs-4/packages/xowf/www/resources/form-generator.css
12:35 am

gustafn

file form-generator.css was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xowf/www/resources/form-generator.css
Sunday 27 Oct 2019
11:29 pm

gustafn

default to shared workflow definition

Options
    • -1
    • +2
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
11:28 pm

gustafn

change order of class definition: move CompoundField to the front to let other fields depend on it

Options
    • -1078
    • +1079
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
7:26 pm

gustafn

- add invalidation for shared workflow containers (when

sharedWorkflowDefinition is activated)

- use the mew form-field method "set_feedback" defined in xowiki

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -24
    • +55
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
7:04 pm

gustafn

factor out CSS for test-items:

new file: /resources/xowf/test-item.css

Options
    • -1
    • +2
    /openacs-4/packages/xowf/lib/online-exam-answer.wf
    • -22
    • +1
    /openacs-4/packages/xowf/lib/online-exam.wf
    • -0
    • +64
    /openacs-4/packages/xowf/www/resources/test-item.css
7:04 pm

gustafn

file test-item.css was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xowf/www/resources/test-item.css
6:58 pm

gustafn

- new abstract form-field class: ShuffleField

* provide means for shuffling options and answers

* three shuffle modes:

- no-shuffling (parameter shuffle false)

- shuffling on every call

- shuffling for a seed (depending on an ID, always the same shuffling)

- new form-field class text_fields, based on ShuffleField

similar to checkbox, but with text fields

and autocorrection via "correct_when"

- support for richtext in checkbox labels

- factored out set_feedback (was previously inline in xowf)

- bump version number to 5.10.0d41

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -14
    • +231
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
9:46 am

gustafn

reduce verbosity

Options
    • -5
    • +6
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
9:44 am

gustafn

sort available-formfields by displayed class-name, not via fully qualified class-name

Options
    • -8
    • +20
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
9:38 am

gustafn

access components via instance variable

Options
    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
Wednesday 23 Oct 2019
9:49 am

gustafn

improve spelling

Options
    • -1
    • +1
    /openacs-4/packages/oacs-dav/tcl/tDAV-procs.tcl
    • -1
    • +1
    /openacs-4/packages/oacs-dav/www/doc/index.html
Tuesday 22 Oct 2019
6:12 pm

gustafn

factor out loop invariants

Options
    • -22
    • +18
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
4:14 pm

gernst

thighten parameter checking to valid classes

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
3:37 pm

gernst

Provide default value for "return_url" and use "export_vars" for url-construction; whitespace changes

Options
    • -32
    • +27
    /openacs-4/packages/dotlrn/www/admin/toolbar-actions.tcl
9:54 am

gustafn

improve spelling

Options
    • -1
    • +1
    /openacs-4/packages/survey/tcl/survey-notification-procs.tcl
    • -2
    • +2
    /openacs-4/packages/survey/www/admin/question-add.tcl
    • -2
    • +2
    /openacs-4/packages/survey/www/admin/respond.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn/tcl/applets-procs.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/community-edit-2.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/element-list.tcl
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/coverage-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/tclwebtest-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-core-docs/www/object-system-design.adp
    • -1
    • +1
    /openacs-4/packages/chat/lib/current-messages.tcl
Monday 21 Oct 2019
9:31 pm

gustafn

added error message for new validator

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -0
    • +1
    /openacs-4/packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml
9:28 pm

gustafn

added validator for "correct_when" form field types

Options
    • -5
    • +17
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
8:26 pm

gustafn

prefer variable names over method calls

Options
    • -72
    • +71
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
6:39 pm

gustafn

new includelet for documentation purposes: available-formfields

Options
    • -2
    • +82
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
12:02 pm

hectorr

Fix typo in message key

Options
    • -1
    • +1
    /openacs-4/packages/acs-kernel/catalog/acs-kernel.de_DE.ISO-8859-1.xml
Sunday 20 Oct 2019
2:52 pm

gustafn

- Fix a tricky Tcl_Obj sharing bug triggered by the usage of C-level

IndexObjs based on volatile tables. Consider the following example:

proc foo {x} {

return [bar -value x ...]

}

The Tcl_Obj "x" is shared as name of argument and as a value of the

non-positional parameter "-value". When bar (e.g. C-implemented)

uses Tcl_GetIndexFromObj*() to lookup "x" in a table of options,

which is volatile, the involved Tcl_Obj will be converted to an

indexObj.

On a call with wrong number of arguments( e.g."foo 1 2 3"), Tcl

will try to give a nice error message, saying that "foo x" can be

called only with one argument. When printing argument "x", it sees

that "x" is an indexObj, and for these kinds of objects, "x" might

be an abbreviated version of a full name. Since the table behind

the indexObj is in the case above volatile, a crash might happen.

The committed fix above is just a temporary measure. NaviServer should

try to avoid such Tcl_Obj conversions in these cases. It is also

questionable, whether the attempt to interpret a argument name as

an abbreviated.

Options
    • -6
    • +7
    /openacs-4/packages/acs-tcl/tcl/utilities-procs-naviserver.tcl