• last updated 23 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
make skipping reason explicit

removed deprecated call

reduced verbosity

    • -10
    • +10
    /openacs-4/packages/workflow/tcl/case-procs.tcl
Replace deprecated api

Rework array idioms

Finish array reform in this proc

Rework array idioms

Whitespace cleanup

Rework array idioms

Formatting changes

Prefer unset to array unset when no pattern matching is needed

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Rework array idioms into dict idioms where appropriate

Cleanup array idioms

Rework array idioms in dict idioms where appropriate, avoid unsetting arrays via pattern matching

Rework array idioms into dict idioms hwre appropriate, e.g.:

- when the return value of a proc is already a dict in itself

- when the return value of a proc should be completely overwritten in later tests

This avoids array "unwrapping" operations and unsets

Prefer unset to array unset when no pattern matching is needed

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

No need to fiddle in the ad_conn array if we just reset it

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

    • -2
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
Prefer unset to array unset when the whole array should be deleted, rework array idioms into tcl idioms when an array is not needed

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Prefer unset to array unset when we do not need a pattern match

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Rework so that an array is not needed

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Rework array idioms

Modernize tcl idioms

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

    • -1
    • +1
    /openacs-4/packages/caldav/tcl/caldav-procs.tcl
Prefer unset to array unset when the whole array should be deleted, rework array idioms into dict idioms to avoid unsetting the array, where appropriate

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Rework array idioms in dict idioms, closer to the intended logics