OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 09 Oct
11:42 am

antoniop

Rework array idioms into dict idioms hwre appropriate, e.g.:

- when the return value of a proc is already a dict in itself

- when the return value of a proc should be completely overwritten in later tests

This avoids array "unwrapping" operations and unsets

Options
    • -259
    • +230
    /openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl
    • -29
    • +27
    /openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
9:18 am

antoniop

Prefer unset to array unset when no pattern matching is needed

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
    • -4
    • +5
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
Tuesday 08 Oct
5:27 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -2
    • +2
    /openacs-4/packages/xml-rpc/tcl/system-procs.tcl
5:20 pm

antoniop

No need to fiddle in the ad_conn array if we just reset it

Options
    • -6
    • +2
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
5:16 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
    • -2
    • +1
    /openacs-4/packages/xowiki/tcl/notification-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -9
    • +7
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
5:04 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -2
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/context-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/www/show-object.tcl
    • -5
    • +5
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/www/stat-details.tcl
    • -2
    • +2
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
5:02 pm

antoniop

Prefer unset to array unset when the whole array should be deleted, rework array idioms into tcl idioms when an array is not needed

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -7
    • +5
    /openacs-4/packages/rss-support/tcl/rss-generation-procs.tcl
4:59 pm

antoniop

Prefer unset to array unset when we do not need a pattern match

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -5
    • +3
    /openacs-4/packages/notifications/tcl/notification-procs.tcl
4:55 pm

antoniop

Rework so that an array is not needed

Options
    • -8
    • +3
    /openacs-4/packages/new-portal/tcl/portal-procs.tcl
4:52 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -2
    • +2
    /openacs-4/packages/forums/tcl/messages-procs.tcl
4:50 pm

antoniop

Rework array idioms

Options
    • -9
    • +7
    /openacs-4/packages/categories/tcl/category-list-procs.tcl
    • -5
    • +6
    /openacs-4/packages/categories/tcl/widget-procs.tcl
4:26 pm

antoniop

Modernize tcl idioms

Options
    • -11
    • +8
    /openacs-4/packages/acs-templating/tcl/query-procs.tcl
4:20 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -7
    • +7
    /openacs-4/packages/acs-templating/tcl/head-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/query-procs.tcl
    • -1
    • +1
    /openacs-4/packages/caldav/tcl/caldav-procs.tcl
4:13 pm

antoniop

Prefer unset to array unset when the whole array should be deleted, rework array idioms into dict idioms to avoid unsetting the array, where appropriate

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -5
    • +7
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
    • -5
    • +5
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
    • -8
    • +6
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
3:55 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl
3:53 pm

antoniop

Rework array idioms in dict idioms, closer to the intended logics

Options
    • -7
    • +8
    /openacs-4/packages/acs-subsite/tcl/application-group-procs.tcl
3:44 pm

antoniop

Cleanup include found to not be in use in upstream codebase already in 2019

Options
    • -1
    • +0
    /openacs-4/packages/acs-subsite/lib/services.adp
    • -53
    • +0
    /openacs-4/packages/acs-subsite/lib/services.tcl
3:35 pm

antoniop

Rework array idioms into dict idioms to avoid the need to unset

Options
    • -12
    • +12
    /openacs-4/packages/acs-lang/tcl/lang-catalog-procs.tcl
3:11 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/installer/index.tcl
    • -1
    • +1
    /openacs-4/packages/acs-bootstrap-installer/tcl/20-db-bootstrap-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/sync-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/publish-procs.tcl
3:07 pm

antoniop

Streamline idiom

Options
    • -3
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/coverage-procs.tcl
3:04 pm

antoniop

Prefer unset to array unset when the purpose is to delete the whole array

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/coverage-procs.tcl
3:01 pm

antoniop

Prefer unset to array unset when we want to delete the entire array

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -7
    • +2
    /openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl
    • -8
    • +6
    /openacs-4/packages/acs-admin/www/install/install-2.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/install/install-3.tcl
2:51 pm

antoniop

Prefer unset to array unset when the semantic is to delete the whole array

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
2:11 pm

antoniop

State Highcharts package dependency in xotcl-request-monitor

Options
    • -32
    • +24
    /openacs-4/packages/xotcl-request-monitor/xotcl-request-monitor.info
1:06 pm

antoniop

Other leftovers

Options
    • -30
    • +0
    /openacs-4/packages/chat/www/transcript-edit-2.tcl
    • -43
    • +0
    /openacs-4/packages/chat/www/transcript-new-2.tcl
1:03 pm

antoniop

Other files deleted

Options
    • -24
    • +0
    /openacs-4/packages/chat/www/moderator-revoke-2.tcl
    • -26
    • +0
    /openacs-4/packages/chat/www/moderator-revoke.tcl
1:03 pm

antoniop

Delete more zombie files

Options
    • -24
    • +0
    /openacs-4/packages/chat/www/moderator-grant-2.tcl
    • -35
    • +0
    /openacs-4/packages/chat/www/moderator-grant.tcl
1:00 pm

antoniop

Delete zombie file from merge with MAIN

Options
    • -46
    • +0
    /openacs-4/packages/chat/www/chat-room-grant.tcl
12:43 pm

antoniop

Trap illegal encoding exception thrown by tcl9 when a file contains invalid UTF-8 and skip the package with a warning

Unmaintained packages may contain illegal characters and we do not want the UI to crash in this situation

Options
    • -2
    • +7
    /openacs-4/packages/acs-admin/www/apm/packages-install.tcl
11:30 am

antoniop

Limit files__tcl_file_common_errors test to installed packages

Unmaintained packages may ship files with invalid encodings, which tcl9 won't tolerate anymore.

Options
    • -2
    • +13
    /openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl