OpenACS / openacs-4 / packages

xotcl-core

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 11:15
Commits this week: 0
Total Lines of Code (LoC): 20,316
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 43 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 29 Feb
12:04 pm

gustafn

Added parameter to define a default dbn to a database connection

By this change, one can now define a default dbn at the creation time

of a database connection object. Before, it was necessary to pass

the "-dbn" value to every single command. The parameter can still be

used for particular queries as before to overrule the default.

Example for defining a connection context to a pool named "legacy"

using the PostgreSQL database interface

::xo::db::DB-postgresql create ::xo::dc1 -dialect postgresql -dbn legacy

lappend _ [::xo::dc1 get_value . {select count(*) from acs_objects}]

lappend _ [::xo::dc get_value . {select count(*) from acs_objects}]

#> 660 51606

Options
    • -10
    • +15
    ./tcl/05-db-procs.tcl
Friday 23 Feb
1:58 pm

antoniop

Fix method signature

Options
    • -1
    • +1
    ./tcl/01-debug-procs.tcl
Thursday 15 Feb
6:36 pm

gustafn

Fixed implementation of value checker dbtext

The old version was not persistent in the blueprints.

Furthermore, the new version is more than 2x faster by

avoiding regular expressions.

Options
    • -8
    • +9
    ./tcl/01-debug-procs.tcl
1:27 pm

antoniop

Provide facilities to validate against invalid SQL strings

We introduce a new page contract filter and nsf validator called "dbtext". They implement enforcing of a value to be useable in an SQL query. Currently, this means that the value should not contain the NUL character, but the definition may change in the future or become database-specific.

The html contract filter has also be extended to reject the NUL character.

The test suite has been updated/extended to reflect the changes.

Options
    • -0
    • +18
    ./tcl/01-debug-procs.tcl
  2. … 2 more files in changeset.
Saturday 03 Feb
9:29 am

gustafn

reduced verbosity

Options
    • -2
    • +2
    ./tcl/cr-procs.tcl
Friday 26 Jan
5:37 pm

antoniop

Chat reform

The goal of these changes is to reduce the "mode" specific javascript code in the chat implementation and reduce server-side guessing of browser capabilities.

- In the MessageRelay class from xotcl-core, we rework the javascript code sent to the connection when doing scripted streaming to make less assumptions about the functions defined in the parent scope

- In the chat code from xowiki, we move most of the logics to guess the mode into javascript, where we can test the actual capabilities of the browser without relying on the user agent

- The previously 4 javascript files dependant on the chat mode have been made into one

Options
    • -2
    • +2
    ./xotcl-core.info
    • -2
    • +1
    ./tcl/message-relay-procs.tcl
  3. … 6 more files in changeset.
2:14 pm

antoniop

When the mode is "streaming", use Server Sent Events instead of a "plain" endless request

This has the advantage of a clearer, less hacky api, which, for instance, does not require manual parsing of the partial response.

Options
    • -3
    • +3
    ./xotcl-core.info
    • -7
    • +16
    ./tcl/message-relay-procs.tcl
  3. … 3 more files in changeset.
Thursday 30 Nov 2023
7:07 pm

gustafn

avoid double quoting

Options
    • -2
    • +2
    ./tcl/context-procs.tcl
Wednesday 29 Nov 2023
9:16 am

antoniop

Add type=oneof to Serializer exportMethods

Many thanks to Sebastian Scheder and Günter Ernst

Options
    • -0
    • +1
    ./tcl/01-debug-procs.tcl
Friday 24 Nov 2023
5:51 pm

antoniop

Simplify oneof filters to not depend on other api

Options
    • -2
    • +2
    ./tcl/01-debug-procs.tcl
1:56 pm

antoniop

Fix syntax of new oneof value checker

Options
    • -2
    • +2
    ./tcl/01-debug-procs.tcl
  2. … 1 more file in changeset.
Thursday 23 Nov 2023
12:12 pm

antoniop

Implement a oneof value checker for xowiki query parameters

The ad_ filter was used to have a localized error message

Options
    • -2
    • +2
    ./xotcl-core.info
    • -0
    • +5
    ./tcl/01-debug-procs.tcl
Wednesday 25 Oct 2023
11:31 am

gustafn

free explicitly answer ns_set in "sets" method

Options
    • -2
    • +3
    ./tcl/05-db-procs.tcl
Tuesday 24 Oct 2023
6:12 pm

gustafn

free ns_set storage more eager (when e.g. large queries are used in longer loops)

Options
    • -2
    • +3
    ./tcl/05-db-procs.tcl
6:11 pm

gustafn

use "ns_set stats" when available in memory statistics of ::xo::stats

Options
    • -1
    • +1
    ./tcl/01-debug-procs.tcl
  2. … 1 more file in changeset.
Sunday 22 Oct 2023
5:58 pm

gustafn

maintenance: simplified and shortened nested if expression

Options
    • -6
    • +4
    ./tcl/01-debug-procs.tcl
Friday 06 Oct 2023
2:09 pm

gustafn

harden page contracts

Options
    • -5
    • +5
    ./www/cache.tcl
    • -6
    • +6
    ./www/show-class-graph.tcl
  3. … 21 more files in changeset.
Wednesday 02 Aug 2023
3:25 pm

gustafn

don't send messages to other threads during shutdown

The threads might be gone already, causing error log entries

Options
    • -3
    • +4
    ./tcl/40-thread-mod-procs.tcl
Thursday 13 Jul 2023
3:09 pm

gustafn

bumped version numbers to 5.10.1b1

Options
    • -10
    • +10
    ./xotcl-core.info
  2. … 85 more files in changeset.
Wednesday 14 Jun 2023
10:40 am

antoniop

Disable tests to check for executables on the system

Options
    • -15
    • +19
    ./tcl/test/xotcl-test-procs.tcl
  2. … 7 more files in changeset.
Tuesday 13 Jun 2023
5:26 pm

trenner

do not show invalid input to the user

Options
    • -1
    • +2
    ./tcl/01-debug-procs.tcl
Tuesday 30 May 2023
12:01 pm

gustafn

improved spelling

Options
    • -1
    • +1
    ./tcl/01-debug-procs.tcl
    • -6
    • +6
    ./tcl/bgdelivery-procs.tcl
    • -11
    • +21
    ./tcl/context-procs.tcl
    • -2
    • +2
    ./tcl/http-client-procs.tcl
  5. … 7 more files in changeset.
Wednesday 24 May 2023
11:28 am

gustafn

improve listing of properties of NX classes

Options
    • -7
    • +1
    ./tcl/01-debug-procs.tcl
Thursday 20 Apr 2023
5:04 pm

antoniop

Test external command dependencies

Options
    • -0
    • +15
    ./tcl/test/xotcl-test-procs.tcl
  2. … 1 more file in changeset.
Wednesday 19 Apr 2023
7:19 pm

gustafn

Undo part of the recent cache-deactivation for attribute definitions

When all calls for "db_attribute_defined" are performed without

caching, this results in a huge amount of additional SQL queries,

since these tests are performed during blueprint definition as well

during every blueprint reload of every db attribute. On a small site

with just 6 connection threads (2 monitor, 2 default, 2 slow), this

results during startup with 969 additional SQL queries, a reload of

xowiki causes an additional 1063 of such queries. When a site defines

much more connection threads ((the LEARN site has e.g. 85 connection

threads defined), these DB attribute testing operations will result in

10K+ of mostly useless SQL queries. As a consequence of this, the

startup of the server will become slower, reloads will become slower

etc., which is bad especially for large sites.

The new implementation seems to fix the original problem case (running

xotcl_core_tutorial_4 multiple times). If there is still a problem

with installing xolp [2] this problem should be analyzed and fixed

probably there. If necessary, a proper bug report would be appreciated

to reduce guessing work.

[1] https://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-10%3Aantoniop%3A20230310183055

[2] https://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-10%3Aantoniop%3A20230317160241

Options
    • -10
    • +29
    ./tcl/05-db-procs.tcl
6:57 pm

gustafn

Use the usual idiom for checking if the connection is active

... why in the first place was this change necessary? Who calls this

in which way this www-*method without a connection?

Options
    • -3
    • +5
    ./tcl/01-debug-procs.tcl
Tuesday 28 Mar 2023
3:34 pm

antoniop

Don't run the spiel when we are not connected

Options
    • -7
    • +9
    ./tcl/01-debug-procs.tcl
Friday 17 Mar 2023
5:02 pm

antoniop

As it turns out, even caching only by request has consequences e.g. when one installs xolp from scratch

Disabl caching and prepare the statement instead

Options
    • -4
    • +10
    ./tcl/05-db-procs.tcl
Friday 10 Mar 2023
7:30 pm

antoniop

Improve robustness when a class is created/deleted multiple times (e.g. by repeating xotcl-core.xotcl_core_tutorial_4 automated test)

Options
    • -35
    • +8
    ./tcl/05-db-procs.tcl
Tuesday 07 Mar 2023
10:48 am

gustafn

Factor out Package->process_init_parameter into package-custom-procs

This change makes it easier to provide instance specific customization.

In general, these package-custom-procs could also be kept in other

packages.

Options
    • -2
    • +2
    ./xotcl-core.info
    • -9
    • +18
    ./tcl/06-package-procs.tcl
  3. … 3 more files in changeset.