Activity OpenACS/openacs-4/packages/xotcl-core

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	15
Last Commit:	26 Dec
Commits this week:	0
Total Lines of Code (LoC):	20,316
Net change in LoC this week:	0

Commit Activity

last updated 5 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Wednesday 01 Feb 2023

2:40 pm

antoniop

Use an idiom without expr to fill up the multirow after the body execution

- -2
- +4
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

2:39 pm

antoniop

Test the behavior when the multirow contains values in the form "\d+\.": this shows a bug caused by the value retrieval going through an expr, which will "normalize" the value to "\d+\.0"

- -0
- +21
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

Thursday 26 Jan 2023

3:25 pm

antoniop

Performance improvements:

- add with_headers flag to ::xo::dc list_of_lists behaving like the db_list_of_lists counterpart

- use ::xo::dc list_of_lists as internal for ::xo::dc foreach and ::xo::dc multirow to reduce the need for ns_sets

- -78
- +77
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

1:31 pm

antoniop

Collect all query results before executing the code to avoid the out-of-pools bug

- -1
- +6
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

1:30 pm

antoniop

Implement a test making sure ::xo::dc "loop code-executing" api is not subject to the "out of pools" bug

- -0
- +31
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

11:53 am

antoniop

-prepare flag must not be supplied when not available

- -3
- +4
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

11:47 am

antoniop

Fix regression: the reimplementation of ::xo::dc foreach reintroduced the old "out of pools bug"

The fix makes again use of the ns_set api to free the handle before the code is executed

- -25
- +17
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

Monday 23 Jan 2023

10:23 am

antoniop

Remove hack and prefer to document limitation in the automated test

- -17
- +1
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl
- -19
- +35
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

Friday 20 Jan 2023

1:15 pm

antoniop

Fix typo and include again the hack for strings with colon char in the fallback implementation of ns_pg_prepare

Fixes xotcl-core.test_prepared_statements automated test

- -3
- +21
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

Thursday 19 Jan 2023

7:10 pm

gustafn

improved spelling

- -3
- +3
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

6:53 pm

gustafn

use the built-in bindvars parser (when available) for prepared statements

- -30
- +34
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

Tuesday 17 Jan 2023

10:54 am

antoniop

Do not extend the existing multirow, we only enforce that this call will have the same columns

- -8
- +2
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

10:53 am

antoniop

Test that appending to an existing multirow from the db works as expected: when the columns defined via query and extend are the same, this should succeed

- -0
- +39
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

Monday 16 Jan 2023

6:27 pm

antoniop

Don't collide with multirows created by other tests

- -5
- +5
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

5:23 pm

antoniop

Do not enforce that body is a list

- -2
- +2
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

3:42 pm

antoniop

Fix typo

- -2
- +2
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

3:40 pm

antoniop

Performance improvements:

- set variables from the ns_set and extended variables separately

- collect the values and append to the multirow in one sweep

- when no code body is there, just bulk append the values

This appears to be ~5% faster than db_multirow when both are invoked with a code body and ~30% faster when invoked without (with no prepared statements)

- -20
- +36
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

12:30 pm

antoniop

Simplify idiom

- -2
- +2
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

11:52 am

antoniop

Fix behavior of continue in the multirow code block, make the generic fallback behave the same as the postgres version with respect to appending

- -3
- +3
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

11:51 am

antoniop

Test ::xo::dc multirow further

- break and continue behavior in the code block (this will expose a bug)

- appending to an existing multirow

- -4
- +29
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

Friday 13 Jan 2023

6:21 pm

antoniop

Cleanup leftover line

- -2
- +1
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

6:17 pm

antoniop

Extend automated tests to cover new ::xo::dc multirow api

- -9
- +147
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

6:16 pm

antoniop

Provide an ::xo::dc api to generate multirows

Notable differences with the classical db_multirow:

- a multirow will always be appended when it already exists. The constraint that the two multirows must have the same columns remains.

- no "if_no_rows_code_block"

- no unclobber

- no subst, do it yourself :-)

- no cache stuff

- support for prepared statements

The remaining behavior has been kept the same, e.g. variables will always be reset to empty string, even if they existed outside of the code block. Compatibility has been checked with knowns idiosyncrasies.