Activity OpenACS/openacs-4/packages/xotcl-core

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	15
Last Commit:	13:32
Commits this week:	0
Total Lines of Code (LoC):	20,316
Net change in LoC this week:	0

Commit Activity

last updated 3 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Tuesday 17 Jan 2023

10:53 am

antoniop

Test that appending to an existing multirow from the db works as expected: when the columns defined via query and extend are the same, this should succeed

- -0
- +39
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

Monday 16 Jan 2023

6:27 pm

antoniop

Don't collide with multirows created by other tests

- -5
- +5
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

5:23 pm

antoniop

Do not enforce that body is a list

- -2
- +2
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

3:42 pm

antoniop

Fix typo

- -2
- +2
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

3:40 pm

antoniop

Performance improvements:

- set variables from the ns_set and extended variables separately

- collect the values and append to the multirow in one sweep

- when no code body is there, just bulk append the values

This appears to be ~5% faster than db_multirow when both are invoked with a code body and ~30% faster when invoked without (with no prepared statements)

- -20
- +36
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

12:30 pm

antoniop

Simplify idiom

- -2
- +2
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

11:52 am

antoniop

Fix behavior of continue in the multirow code block, make the generic fallback behave the same as the postgres version with respect to appending

- -3
- +3
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

11:51 am

antoniop

Test ::xo::dc multirow further

- break and continue behavior in the code block (this will expose a bug)

- appending to an existing multirow

- -4
- +29
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

Friday 13 Jan 2023

6:21 pm

antoniop

Cleanup leftover line

- -2
- +1
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

6:17 pm

antoniop

Extend automated tests to cover new ::xo::dc multirow api

- -9
- +147
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

6:16 pm

antoniop

Provide an ::xo::dc api to generate multirows

Notable differences with the classical db_multirow:

- a multirow will always be appended when it already exists. The constraint that the two multirows must have the same columns remains.

- no "if_no_rows_code_block"

- no unclobber

- no subst, do it yourself :-)

- no cache stuff

- support for prepared statements

The remaining behavior has been kept the same, e.g. variables will always be reset to empty string, even if they existed outside of the code block. Compatibility has been checked with knowns idiosyncrasies.

- -1
- +116
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

Tuesday 10 Jan 2023

3:18 pm

antoniop

Remove test of undocumented format to specify prepared statement

- -10
- +0
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

Monday 09 Jan 2023

6:11 pm

antoniop

Provide, as for other interfaces, a Postgres implementation of database foreach that will support prepared statements won't just wrap the db_* api

- -0
- +39
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

5:51 pm

antoniop

Make sure the original SQL stays unchanged, as it is used e.g. in the nsv storing the statement and in log messages

- -6
- +6
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

5:48 pm

antoniop

Basic test of xo::dc foreach when using prepared statements

This api currently supports the flag, but will ignore it

- -0
- +29
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

11:53 am

antoniop

Improve the approach with strings containing colons in prepared SQL statements:

we first normalize all strings with a safe placeholder, substitute the variables, then put the strings back in place.

- -2
- +19
./tcl/05-db-procs.tcl
- History
- Source
- Diff
./tcl/05-db-procs.tcl

11:52 am

antoniop

Extend test for prepared statements containing strings with colon characters, exposing that the latest commit won't address all cases

- -0
- +13
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

Thursday 05 Jan 2023

5:54 pm

antoniop

Make test more consistent

- -1
- +1
./tcl/test/xotcl-test-procs.tcl
- History
- Source
- Diff
./tcl/test/xotcl-test-procs.tcl

5:50 pm

antoniop

Improve the regexp detecting variables in a prepared statement, so that a prepared variable must not be preceded by a semicolon (as before), but also by any character allowed for a variable name