OpenACS / openacs-4 / packages

xotcl-core

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 13:32
Commits this week: 0
Total Lines of Code (LoC): 20,316
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 16 Jan 2023
3:40 pm

antoniop

Performance improvements:

- set variables from the ns_set and extended variables separately

- collect the values and append to the multirow in one sweep

- when no code body is there, just bulk append the values

This appears to be ~5% faster than db_multirow when both are invoked with a code body and ~30% faster when invoked without (with no prepared statements)

Options
    • -20
    • +36
    ./tcl/05-db-procs.tcl
12:30 pm

antoniop

Simplify idiom

Options
    • -2
    • +2
    ./tcl/05-db-procs.tcl
11:52 am

antoniop

Fix behavior of continue in the multirow code block, make the generic fallback behave the same as the postgres version with respect to appending

Options
    • -3
    • +3
    ./tcl/05-db-procs.tcl
11:51 am

antoniop

Test ::xo::dc multirow further

- break and continue behavior in the code block (this will expose a bug)

- appending to an existing multirow

Options
    • -4
    • +29
    ./tcl/test/xotcl-test-procs.tcl
Friday 13 Jan 2023
6:21 pm

antoniop

Cleanup leftover line

Options
    • -2
    • +1
    ./tcl/05-db-procs.tcl
6:17 pm

antoniop

Extend automated tests to cover new ::xo::dc multirow api

Options
    • -9
    • +147
    ./tcl/test/xotcl-test-procs.tcl
6:16 pm

antoniop

Provide an ::xo::dc api to generate multirows

Notable differences with the classical db_multirow:

- a multirow will always be appended when it already exists. The constraint that the two multirows must have the same columns remains.

- no "if_no_rows_code_block"

- no unclobber

- no subst, do it yourself :-)

- no cache stuff

- support for prepared statements

The remaining behavior has been kept the same, e.g. variables will always be reset to empty string, even if they existed outside of the code block. Compatibility has been checked with knowns idiosyncrasies.

Options
    • -1
    • +116
    ./tcl/05-db-procs.tcl
Tuesday 10 Jan 2023
3:18 pm

antoniop

Remove test of undocumented format to specify prepared statement

Options
    • -10
    • +0
    ./tcl/test/xotcl-test-procs.tcl
Monday 09 Jan 2023
6:11 pm

antoniop

Provide, as for other interfaces, a Postgres implementation of database foreach that will support prepared statements won't just wrap the db_* api

Options
    • -0
    • +39
    ./tcl/05-db-procs.tcl
5:51 pm

antoniop

Make sure the original SQL stays unchanged, as it is used e.g. in the nsv storing the statement and in log messages

Options
    • -6
    • +6
    ./tcl/05-db-procs.tcl
5:48 pm

antoniop

Basic test of xo::dc foreach when using prepared statements

This api currently supports the flag, but will ignore it

Options
    • -0
    • +29
    ./tcl/test/xotcl-test-procs.tcl
11:53 am

antoniop

Improve the approach with strings containing colons in prepared SQL statements:

we first normalize all strings with a safe placeholder, substitute the variables, then put the strings back in place.

Options
    • -2
    • +19
    ./tcl/05-db-procs.tcl
11:52 am

antoniop

Extend test for prepared statements containing strings with colon characters, exposing that the latest commit won't address all cases

Options
    • -0
    • +13
    ./tcl/test/xotcl-test-procs.tcl
Thursday 05 Jan 2023
5:54 pm

antoniop

Make test more consistent

Options
    • -1
    • +1
    ./tcl/test/xotcl-test-procs.tcl
5:50 pm

antoniop

Improve the regexp detecting variables in a prepared statement, so that a prepared variable must not be preceded by a semicolon (as before), but also by any character allowed for a variable name

Options
    • -2
    • +2
    ./tcl/05-db-procs.tcl
5:49 pm

antoniop

Introduce a test exposing that when a statement is prepared on SQL containing colons, this sould fail because they would be interpreted as variables

Options
    • -0
    • +10
    ./tcl/test/xotcl-test-procs.tcl
Wednesday 04 Jan 2023
12:34 pm

antoniop

Allow to prepare a statement with no parameters (See https://www.postgresql.org/docs/11/sql-prepare.html)

Options
    • -3
    • +11
    ./tcl/05-db-procs.tcl
12:32 pm

antoniop

Basic test of the prepared statements feature on ::xo::dc api

Options
    • -0
    • +69
    ./tcl/test/xotcl-test-procs.tcl
Thursday 22 Dec 2022
3:36 am

gustafn

whitespace change

Options
    • -2
    • +2
    ./tcl/30-widget-procs.tcl
Thursday 15 Dec 2022
2:06 pm

gustafn

remove legacy code

Options
    • -32
    • +5
    ./tcl/01-debug-procs.tcl
Sunday 27 Nov 2022
6:37 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./tcl/ical-procs.tcl
6:35 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./tcl/ical-procs.tcl
6:28 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./tcl/01-debug-procs.tcl
    • -2
    • +2
    ./tcl/06-package-procs.tcl
    • -1
    • +1
    ./tcl/06-param-procs.tcl
    • -2
    • +2
    ./tcl/40-thread-mod-procs.tcl
    • -4
    • +4
    ./tcl/50-protocol-handler-procs.tcl
    • -5
    • +4
    ./tcl/context-procs.tcl
    • -1
    • +1
    ./tcl/html-procs.tcl
    • -2
    • +2
    ./tcl/policy-procs.tcl
  9. … 1 more file in changeset.
Saturday 26 Nov 2022
6:00 pm

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -3
    • +3
    ./xotcl-core.info
    • -7
    • +10
    ./www/show-class-graph.tcl
  3. … 4 more files in changeset.
Tuesday 08 Nov 2022
7:04 pm

gustafn

Deescalation: the usage of the pairs in export_vars is not so dangerous as it looked at first sight.

The problem case was originating from the call

lappend __vars [lindex $_var 0] [uplevel subst [lindex $_var 1]]

which calls Tcl's "uplevel" with two arguments. In this case, the arguments

are concatenated and the evaluated in the caller's frame. There is a substitution

before the evaluation. When just one argument is passed in, this problem there

is only one evaluation:

lappend __vars [lindex $_var 0] [uplevel [list subst [lindex $_var 1]]]

Options
    • -6
    • +8
    ./tcl/06-package-procs.tcl
  2. … 1 more file in changeset.
2:24 pm

gustafn

Added support for passing parameter_name:value_constraint to xowiki::Package->get_parameter

- The get_parameter method can get values from query-parameters, therefore

we have to validate these.

- Use the new feature at several places (especially for boolean values)

- Still, more places should be checked

- bumped xowiki to 5.10.1d37

- bumped xotcl-core to 5.10.1d14

Options
    • -2
    • +2
    ./xotcl-core.info
    • -26
    • +4
    ./tcl/06-package-procs.tcl
    • -29
    • +52
    ./tcl/context-procs.tcl
  4. … 8 more files in changeset.
1:47 pm

trenner

add missing brackets

Options
    • -2
    • +2
    ./tcl/06-package-procs.tcl
Monday 07 Nov 2022
2:34 pm

gustafn

new API call util::potentially_unsafe_eval_p

Check content of the string to identify potentially unsafe content

in the provided string. The content is unsafe, when it contains

externally provided content, which might be provided e.g. via

query variables, or via user values stored in the database. When

such content contains square braces, a "subst" command on

theses can evaluate arbitrary commands, which is dangerous.

The new API call is used in "::xo::Package->return_page", where the

"subst" command stripped from its command substitution capabilities.

In case, command subsitution is needed, perform this prior this call.

bumped acs-tcl to 5.10.1d23

bumped xotcl-core to 5.10.1d13

Options
    • -3
    • +3
    ./xotcl-core.info
    • -2
    • +5
    ./tcl/06-package-procs.tcl
  3. … 2 more files in changeset.
Sunday 30 Oct 2022
11:00 am

gustafn

xo::Table::Action: added property "CSSclass"

This property exists already for all other ::xo::Table::* widgets.

Bumped version number to 5.10.1d12

Options
    • -2
    • +2
    ./xotcl-core.info
    • -3
    • +3
    ./tcl/30-widget-procs.tcl
Monday 24 Oct 2022
1:21 pm

gustafn

prefer adp:icon over old-style .gif images

Options
    • -6
    • +2
    ./lib/revisions.tcl
  2. … 13 more files in changeset.