OpenACS / openacs-4 / packages

acs-lang

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 41
Last Commit: 17 Dec
Commits this week: 0
Total Lines of Code (LoC): 20,563
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 36 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 24 Apr 2019
12:24 pm

hectorr

file message-unregister.adp was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./www/admin/message-unregister.adp
Tuesday 23 Apr 2019
9:25 pm

hectorr

Fix query and logic for retrieving a particular locale stats for acs-lang admin/index page. In particular, messages that do not exist in a certain locale are properly computed in order to calculate deleted and untranslated ones, at the price of executing one query per locale instead of just a big one.

Options
    • -14
    • +57
    ./www/admin/index.tcl
    • -5
    • +7
    ./www/admin/index.xql
Wednesday 17 Apr 2019
11:57 am

antoniop

Update italian translation

Options
    • -0
    • +1
    ./catalog/acs-lang.it_IT.ISO-8859-1.xml
  2. … 1 more file in changeset.
11:53 am

antoniop

Default deleted_p should be false for non-existing translations

Options
    • -2
    • +2
    ./www/admin/edit-localized-message.tcl
Monday 15 Apr 2019
7:30 pm

hectorr

Allow to undelete a message from acs-lang 'edit-localized-message', instead of showing the option to delete it whatever the state is

Options
    • -1
    • +6
    ./www/admin/edit-localized-message.adp
    • -1
    • +9
    ./www/admin/edit-localized-message.tcl
6:34 pm

hectorr

Refactor acs-lang 'admin/index' page, adding the new columns 'total' and 'deleted' to the listing, and reworking the query so it is faster (53ms -> 7ms), correct (number of messages by state are computed coherently with other acs-lang pages) and gives more information

Options
    • -2
    • +22
    ./www/admin/index.adp
    • -53
    • +50
    ./www/admin/index.tcl
    • -0
    • +62
    ./www/admin/index.xql
6:34 pm

hectorr

file index.xql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./www/admin/index.xql
2:17 pm

hectorr

Refactor acs-lang 'message-list', using a single query for counting the different message states instead of one per state, and simplifying tcl logic

Options
    • -43
    • +15
    ./www/admin/message-list.tcl
    • -16
    • +43
    ./www/admin/message-list.xql
    • -0
    • +1
    ./www/admin/package-list.xql
Friday 12 Apr 2019
11:19 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./tcl/lang-catalog-procs.tcl
  2. … 17 more files in changeset.
3:48 pm

hectorr

Rework acs-lang 'package-list' query 'packages_locale_status' query (89ms -> 4ms)

Options
    • -52
    • +27
    ./www/admin/package-list.xql
2:49 pm

hectorr

Rework acs-lang 'package-list' query 'packages_locale_status_default' query (48ms -> 2ms)

Options
    • -28
    • +20
    ./www/admin/package-list.xql
Thursday 11 Apr 2019
8:36 pm

hectorr

Add deleted column to acs-lang 'package-list', and fixed number of messages depending on status, making it coherent with 'message-list'. Also fixed translated/untranslated count on default locale in 'message-list'. Version bump.

Options
    • -4
    • +4
    ./acs-lang.info
    • -0
    • +1
    ./catalog/acs-lang.en_US.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-lang.es_ES.ISO-8859-1.xml
    • -5
    • +6
    ./www/admin/message-list.tcl
    • -0
    • +1
    ./www/admin/message-list.xql
    • -0
    • +6
    ./www/admin/package-list.adp
    • -53
    • +32
    ./www/admin/package-list.tcl
    • -0
    • +97
    ./www/admin/package-list.xql
8:36 pm

hectorr

file package-list.xql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./www/admin/package-list.xql
4:53 pm

hectorr

Fix untranslated count and view on acs-lang 'message-list' + some refactoring

Options
    • -20
    • +24
    ./www/admin/message-list.tcl
    • -1
    • +1
    ./www/admin/message-list.xql
Tuesday 09 Apr 2019
9:17 pm

hectorr

Fix acs-lang 'admin/message-list' page, making the number of messages in different states coherent, and general refactoring

Options
    • -7
    • +14
    ./www/admin/message-list.adp
    • -109
    • +72
    ./www/admin/message-list.tcl
    • -14
    • +66
    ./www/admin/message-list.xql
Monday 08 Apr 2019
4:47 pm

hectorr

HTML cleanup

Options
    • -4
    • +2
    ./www/admin/message-delete.adp
    • -4
    • +2
    ./www/admin/message-undelete.adp
4:46 pm

hectorr

Whitespace changes

Options
    • -15
    • +15
    ./www/admin/message-list.tcl
4:38 pm

hectorr

Fix message key description edition

Options
    • -7
    • +4
    ./www/admin/edit-localized-message.tcl
3:24 pm

hectorr

Add 'message-undelete' page to make use of the new '::message::undelete' proc for undeleting messages, a couple of icons, the undelete option in 'message-list' and the undelete action in automated tests

Options
    • -0
    • +12
    ./tcl/test/acs-lang-test-procs.tcl
    • -2
    • +7
    ./www/admin/message-list.adp
    • -4
    • +6
    ./www/admin/message-list.tcl
    • -0
    • +14
    ./www/admin/message-undelete.adp
    • -0
    • +50
    ./www/admin/message-undelete.tcl
  6. … 2 more files in changeset.
3:24 pm

hectorr

file message-undelete.adp was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./www/admin/message-undelete.adp
3:24 pm

hectorr

file message-undelete.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./www/admin/message-undelete.tcl
Friday 05 Apr 2019
2:50 pm

hectorr

Add 'lang::message::undelete', in order to provide an API for undeletion of messages deleted via 'lang::message::delete', and modify 'lang::message::edit' accordingly. Next step would be to provide a user interface for it.

Options
    • -36
    • +66
    ./tcl/lang-message-procs.tcl
Monday 25 Mar 2019
3:16 pm

antoniop

Exclude locales that are not enabled from test

Options
    • -1
    • +3
    ./tcl/test/acs-lang-test-procs.tcl
3:06 pm

antoniop

Do not test deleted keys

Options
    • -4
    • +4
    ./tcl/test/acs-lang-test-procs.tcl
1:08 pm

antoniop

Display error message when the test fails

Options
    • -2
    • +3
    ./tcl/test/acs-lang-test-procs.tcl
Thursday 14 Mar 2019
3:26 pm

antoniop

Update test case for lang::util::default_locale_from_lang

Options
    • -16
    • +10
    ./tcl/test/acs-lang-test-procs.tcl
11:41 am

antoniop

Trim padding from column to be sure

Options
    • -0
    • +3
    ./sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
11:23 am

antoniop

Redefine ad_locales.language table column as varchar to avoid Oracle idiosyncrasies when comparing a char(n) with other string datatypes when using bind variables (following insightful LARS's remark)

char(n) in Oracle are automatically padded to be n characters long. Apparently, comparing char(n) -> char(n) is "blanks insensitive", while comparing char(n) -> varchar2(n) will account for such automatically inserted blanks. When using bind variables, one should carefully specify the type to use to avoid surprises with char(n) (for this we should touch the oracle driver), normalize the value via trim/pad all the time or replace every char(n) datatype with varchar2. ...are there other places where this is happening?

Options
    • -2
    • +2
    ./acs-lang.info
    • -2
    • +2
    ./sql/oracle/ad-locales.sql
    • -0
    • +11
    ./sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
    • -2
    • +2
    ./sql/postgresql/ad-locales.sql
    • -0
    • +11
    ./sql/postgresql/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
    • -5
    • +1
    ./tcl/lang-util-procs.tcl
11:23 am

antoniop

file upgrade-5.10.0d2-5.10.0d3.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
Wednesday 13 Mar 2019
2:37 pm

antoniop

Rewrite the query to leverage transparent variable quoting, replace count with quicker existance check, bring sql inline

Options
    • -2
    • +10
    ./tcl/lang-util-procs.tcl
    • -14
    • +0
    ./tcl/lang-util-procs.xql