• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset MAIN:hectorr:20190408132437:1 does not match your current filter (clear filter).

file message-undelete.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./www/admin/message-undelete.adp
file message-undelete.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./www/admin/message-undelete.tcl
Add 'lang::message::undelete', in order to provide an API for undeletion of messages deleted via 'lang::message::delete', and modify 'lang::message::edit' accordingly. Next step would be to provide a user interface for it.

Exclude locales that are not enabled from test

Do not test deleted keys

Display error message when the test fails

Update test case for lang::util::default_locale_from_lang

    • -16
    • +10
    ./tcl/test/acs-lang-test-procs.tcl
Trim padding from column to be sure

    • -0
    • +3
    ./sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
Redefine ad_locales.language table column as varchar to avoid Oracle idiosyncrasies when comparing a char(n) with other string datatypes when using bind variables (following insightful LARS's remark)

char(n) in Oracle are automatically padded to be n characters long. Apparently, comparing char(n) -> char(n) is "blanks insensitive", while comparing char(n) -> varchar2(n) will account for such automatically inserted blanks. When using bind variables, one should carefully specify the type to use to avoid surprises with char(n) (for this we should touch the oracle driver), normalize the value via trim/pad all the time or replace every char(n) datatype with varchar2. ...are there other places where this is happening?

    • -0
    • +11
    ./sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
file upgrade-5.10.0d2-5.10.0d3.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
Rewrite the query to leverage transparent variable quoting, replace count with quicker existance check, bring sql inline

Replace ad_decode idioms

  1. … 2 more files in changeset.
Bring back to life edit-history page:

- fix oracle-only limit idiom

- link the page to the UI (again?). Will be in acs-lang/admin

- provide message key for the UI

    • -0
    • +1
    ./catalog/acs-lang.en_US.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-lang.it_IT.ISO-8859-1.xml
improve spelling

  1. … 21 more files in changeset.
Switch to a sql-only approach (fixes regression)

Replace ad_decode idioms

  1. … 1 more file in changeset.
Replace ad_decode idioms

Bring files on oacs-5-10 in sync with HEAD

  1. … 162 more files in changeset.
Bring files on oacs-5-10 in sync with HEAD

  1. … 15 more files in changeset.
Whitespace changes + editor hints

  1. … 19 more files in changeset.
Replace/remove deprecated proc 'db_null' and update doc accordingly

  1. … 33 more files in changeset.
Fix typo in proc doc

don't load deleted messages into the cache and drop conceptually broken parameter

Get rid of warning: "template::form::check_elements: MISSING FORMWIDGET"

Fix typo

Replace silent catch with something nicer

Fulfill Lars old dream by using a thread safe idiom

Tolerate wrong locales from browsers by assuming our default one

improve spelling

  1. … 15 more files in changeset.
Whitespace changes

    • -1
    • +1
    ./www/admin/message-conflict-revert.tcl
  1. … 1 more file in changeset.