• last updated 16 hours ago
Constraints: committers
Constraints: files
Constraints: dates
make sure that the query variable "show" is only passed non-empty, otherwise the page-contract of admin/message-list.tcl will fail

    • -9
    • +9
list called api procs

Mark 'lang::message::cache' as public, as it is used in 'acs-admin'

Mark 'lang::catalog::package_catalog_dir' as public, as it is used in 'acs-admin'

Mark 'lang::util::get_hash_indices' as public, as it is used in 'acs-admin'

Remove ancient tests for 'acs-lang', which use obsolete API and don't work for the most part anymore

    • -26
    • +0
    • -43
    • +0
complete listing of covered procs in test cases

  1. … 14 more files in changeset.
Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 4 more files in changeset.
remove protection "private", since function has to be called from other packages

  1. … 6 more files in changeset.
bring test coverage to >50% by adding test cases and marking only locally called functions as private

    • -0
    • +29
mark unused function "_mr" as deprecated

improve listing of test coverage

  1. … 17 more files in changeset.
use per_thread_cache for flusing rather than raw variables

make listing of tested procs more complete

    • -2
    • +5
  1. … 5 more files in changeset.
make comment more precise

New test to enforce that catalog files are valid XML

Define arguments so that documentation__check_parameters automated test does find -varname flag correctly

Pass missing object_id flag

Do not insert object_ids that do not exist in acs_object (leftover group message keys)

Improve sql portability

    • -22
    • +22
  1. … 6 more files in changeset.
Improve test

    • -8
    • +13
New test for lang::util::convert_to_i18n pinpointing some expected behaviors of this proc

    • -0
    • +67
Fix typo

acs-lang reform:

when calling lang::util::convert_to_i18n, do not always register a en_US translation, which will be otherwise always overridden. Instead, let lang::message::register make sure that a en_US message exists and create it only when needed as a fallback. Before, lang::message::register would return an error when e.g. a new message keys was registered for de_DE and no en_US was there. Now the en_US will be just created on the fly.

This does not break current automated tests

Take also care to populate the newly created column with the group ids coming from automatically generated message keys

file upgrade-5.10.0d13-5.10.0d14.sql was initially added on branch oacs-5-10.

    • -0
    • +0
Create index on the new lang_message_keys.object_id column

file upgrade-5.10.0d12-5.10.0d13.sql was initially added on branch oacs-5-10.

    • -0
    • +0
file upgrade-5.10.0d11-5.10.0d12.sql was initially added on branch oacs-5-10.

    • -0
    • +0
acs-lang reform

Provide an optional object_id which can be used to register message keys that will be bound to the lifecycle of an acs-object. When the object is deleted, so will the message key.

This is useful for groups that automatically define a message key for their pretty name. Tcl api was already aware of this and would cleanup such message keys, but other idioms e.g. stored procedures used to delete groups would leave leftovers behind. These can become relatively numerous on group-intensive systems such as LEARN.

Other future usages for this new feature might be the automatic localization of xowiki FormPage properties.

  1. … 2 more files in changeset.