• last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix query and logic for retrieving a particular locale stats for acs-lang admin/index page. In particular, messages that do not exist in a certain locale are properly computed in order to calculate deleted and untranslated ones, at the price of executing one query per locale instead of just a big one.

Update italian translation

    • -0
    • +1
    ./catalog/acs-lang.it_IT.ISO-8859-1.xml
  1. … 1 more file in changeset.
Default deleted_p should be false for non-existing translations

    • -2
    • +2
    ./www/admin/edit-localized-message.tcl
Allow to undelete a message from acs-lang 'edit-localized-message', instead of showing the option to delete it whatever the state is

    • -1
    • +6
    ./www/admin/edit-localized-message.adp
    • -1
    • +9
    ./www/admin/edit-localized-message.tcl
Refactor acs-lang 'admin/index' page, adding the new columns 'total' and 'deleted' to the listing, and reworking the query so it is faster (53ms -> 7ms), correct (number of messages by state are computed coherently with other acs-lang pages) and gives more information

file index.xql was initially added on branch oacs-5-10.

Refactor acs-lang 'message-list', using a single query for counting the different message states instead of one per state, and simplifying tcl logic

improve spelling

  1. … 17 more files in changeset.
Rework acs-lang 'package-list' query 'packages_locale_status' query (89ms -> 4ms)

Rework acs-lang 'package-list' query 'packages_locale_status_default' query (48ms -> 2ms)

Add deleted column to acs-lang 'package-list', and fixed number of messages depending on status, making it coherent with 'message-list'. Also fixed translated/untranslated count on default locale in 'message-list'. Version bump.

    • -0
    • +1
    ./catalog/acs-lang.en_US.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-lang.es_ES.ISO-8859-1.xml
file package-list.xql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./www/admin/package-list.xql
Fix untranslated count and view on acs-lang 'message-list' + some refactoring

Fix acs-lang 'admin/message-list' page, making the number of messages in different states coherent, and general refactoring

HTML cleanup

Whitespace changes

Fix message key description edition

    • -7
    • +4
    ./www/admin/edit-localized-message.tcl
Add 'message-undelete' page to make use of the new '::message::undelete' proc for undeleting messages, a couple of icons, the undelete option in 'message-list' and the undelete action in automated tests

  1. … 2 more files in changeset.
file message-undelete.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./www/admin/message-undelete.adp
file message-undelete.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./www/admin/message-undelete.tcl
Add 'lang::message::undelete', in order to provide an API for undeletion of messages deleted via 'lang::message::delete', and modify 'lang::message::edit' accordingly. Next step would be to provide a user interface for it.

Exclude locales that are not enabled from test

Do not test deleted keys

Display error message when the test fails

Update test case for lang::util::default_locale_from_lang

    • -16
    • +10
    ./tcl/test/acs-lang-test-procs.tcl
Trim padding from column to be sure

    • -0
    • +3
    ./sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
Redefine ad_locales.language table column as varchar to avoid Oracle idiosyncrasies when comparing a char(n) with other string datatypes when using bind variables (following insightful LARS's remark)

char(n) in Oracle are automatically padded to be n characters long. Apparently, comparing char(n) -> char(n) is "blanks insensitive", while comparing char(n) -> varchar2(n) will account for such automatically inserted blanks. When using bind variables, one should carefully specify the type to use to avoid surprises with char(n) (for this we should touch the oracle driver), normalize the value via trim/pad all the time or replace every char(n) datatype with varchar2. ...are there other places where this is happening?

    • -0
    • +11
    ./sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
file upgrade-5.10.0d2-5.10.0d3.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
Rewrite the query to leverage transparent variable quoting, replace count with quicker existance check, bring sql inline

Replace ad_decode idioms

  1. … 2 more files in changeset.