• last updated 10 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Cleanup leftover references to files deleted in https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Aantoniop%3A20200507144307

This was not preventing the installation or functionalities of the forums package, so it has been long missed. Upon closer inspection, errors were popping up in the installation UI.

  1. … 1 more file in changeset.
improving Oracle upgrade scripts

Oracle has no "ALTER TABLE ADD COLUMN ...."

Oracle has no "ALTER TABLE ADD COLUMN if exists .."

    • -1
    • +1
    ./oracle/upgrade/upgrade-1.3-1.3d1.sql
  1. … 7 more files in changeset.
Handle correctly the indexing of moderated messages in fulltext search:

so far the fulltext search would also include unapproved messages and threads. With this reform we address this by:

- making sure unapproved threads are deleted from the index

- making sure new threads are added to the index only when the are approved

- making sure we unindex or reindex a thread whenever the approval state changes

- not fetching unapproved messages in the datasource callback, hence excluding them from the index

Note that Oracle has not been targeted by the reform. However, the situation improves for Oracle as well, because we won't render unmoderated messages in the datasource callback anymore.

    • -0
    • +124
    ./postgresql/upgrade/upgrade-1.4.0d3-1.4.0d4.sql
  1. … 2 more files in changeset.
New index on the forums_reading_info table

    • -0
    • +1
    ./postgresql/forums-reading-info-create.sql
  1. … 1 more file in changeset.
Whitespace cleanup

    • -8
    • +7
    ./postgresql/forums-reading-info-create.sql
Move logics to create forum notification type to tcl to:

- reduce code duplication

- make it simpler to extend forums with new notification types

This reform was triggered by a downstream request, where users would like a new kind of notification for forum moderators that triggers also when a forum message has not been approved

    • -118
    • +0
    ./oracle/forums-notifications-init.sql
    • -128
    • +0
    ./oracle/forums-notifications-sanitize.sql
    • -134
    • +0
    ./postgresql/forums-notifications-init.sql
    • -151
    • +0
    ./postgresql/forums-notifications-sanitize.sql
  1. … 1 more file in changeset.
Redefine forum charter as text, therefore without length limit

    • -3
    • +17
    ./postgresql/forums-forums-create.sql
    • -0
    • +27
    ./postgresql/upgrade/upgrade-1.3.1d16-1.3.1d17.sql
  1. … 1 more file in changeset.
Add column 'attachments_allowed_p' to 'forums_forums', to be used to allow/disallow attachments on a per forum basis. Currently, the attachment logic is package instance wise, so if the forums instance has an attachment instance mounted below, then attachments are assumed to be enabled for all forums in that package instance. The idea with this change is to check for both the attachments instance mounted under a particular forum instance, and the 'attachments_allowed_p' column on 'forums_forums', to decide if attachments are enabled or not (both should be true). Next step would be to rewrite the logic to achieve that.

    • -0
    • +10
    ./postgresql/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
  1. … 1 more file in changeset.