• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improved spelling

  1. … 7 more files in changeset.
Fix proc signature

  1. … 7 more files in changeset.
Deprecate notification::get_delivery_method_id, same as notification::delivery::get_id and looking more established

  1. … 7 more files in changeset.
Deprecate notification::get_interval_id, duplicated by notification::interval::get_id_from_name which appears to be more established

  1. … 5 more files in changeset.
Use 'portal::exists_p' instead of custom idioms

  1. … 7 more files in changeset.
Reinstate get_portal_id_not_cached as private, flush the cache before calling public api instead

  1. … 3 more files in changeset.
Fix api:

upstream dotlrn mounts dotlrn-forums at /dotlrn/forums/, but testcase dotlrn_forums__applet_portlet (dotlrn-forums) deletes such node and replaces it with a new one at /dotlrn/applets/forums/. As site_node::get_package_url does not get flushed, the api will expect to find the mounted instance at the old URL, which now resolves to the parent dotlrn instead! Fix this by not relying on the cache to retrieve the applet node id.

Delete site_node after unmount in 'dotlrn_forums::remove_applet'

Unmount applet on removal

Add 'dotlrn_forums__applet_portlet' test case, covering 'dotlrn_forums::add_applet', 'dotlrn_forums::add_portlet', 'dotlrn_forums::add_portlet_helper', 'dotlrn_forums::remove_portlet' and 'dotlrn_forums::remove_applet'

    • -0
    • +90
    ./test/dotlrn-forums-test-procs.tcl
Implement 'dotlrn_forums::remove_applet'

Set 'dotlrn-forums' procs without current implementation to private

Whitespace changes

  1. … 5 more files in changeset.
Add 'dotlrn_forums::get_pretty_name' and 'dotlrn_forums_admin_portlet::get_pretty_name' to the 'dotlrn_forums_portlet_links_names' test

Add simple test for 'dotlrn_forums_admin_portlet::link'

    • -0
    • +11
    ./test/dotlrn-forums-test-procs.tcl
Add new simple tests for dotlrn-* packages

    • -0
    • +33
    ./test/dotlrn-forums-test-procs.tcl
  1. … 10 more files in changeset.