• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Harden page contracts

  1. … 1 more file in changeset.
Replace permission::require_write_permission with permission::require_permission across the calendar package

Rationale: permission::require_write_permission assumes the object creator to have write permission on the object. Instead, we should rely on permissions to be set correctly on the calendar. permission::require_write_permission also performs an additional query to retrieve the object creator.

It is unclear whether permission::require_write_permission makes sense at all as an api, but we leave this to a future post-release reform.

  1. … 2 more files in changeset.
Keep populating the event duration radio button according to the time settings

Deprecate calendar::adjust_date, implementing a trivial default logic

  1. … 2 more files in changeset.
Reinstate lost comment

Use modern date and time form input types so that the time values validated by the contract are the same used by the UI and no different values can be supplied to the form via the pseudo-fields for e.g. year, day and so on...

  1. … 1 more file in changeset.
Shorten idiom

Modernize and tighten page contract

Set edit_what to a valid default

Gradually improve usability and security of the calendar item new/edit form by adding additonal input validations. Prefer built-in input validation over custom validation. Also make sure all needed Javascript is in place.

Make sure the value we validate is a list

Fix validated input format

Apply a date-aware validation

Cleanup redundant validation

Add input validation

Don't pass around variables that are not meant to be changed by the UI as hidden fields

Use the new 'url' input type widget. Bump version number for dependency

  1. … 1 more file in changeset.
bugfix: propagate event on radio button via "-preventdefault=false", otherwise switching between all-day and hour event does not work

improve input checking on dates (cal-item-new) and improve error messages

  1. … 2 more files in changeset.