OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 35
Total Committers: 146
Last Commit: 28 Dec
Commits this week: 35
Total Lines of Code (LoC): 7,561,384
Net change in LoC this week: 37

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 Feb 2021
12:10 pm

hectorr

Adjust naming to openacs conventions. Fixes 'naming__proc_naming' test case.

Options
    • -3
    • +3
    /openacs-4/packages/calendar-portlet/calendar-portlet.info
    • -2
    • +2
    /openacs-4/packages/calendar-portlet/tcl/apm-callback-procs.tcl
    • -1
    • +1
    /openacs-4/packages/calendar-portlet/tcl/apm-callback-procs.xql
Sunday 14 Feb 2021
10:22 pm

gustafn

whitespace changes

Options
    • -2
    • +4
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
10:21 pm

gustafn

set default value only in case of failure

Options
    • -6
    • +7
    /openacs-4/packages/acs-authentication/tcl/authentication-procs-naviserver.tcl
10:16 pm

gustafn

use ad_proc -private

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
10:16 pm

gustafn

improve warning message

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
10:15 pm

gustafn

provide better error message

Options
    • -1
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
10:13 pm

gustafn

provide warning about deprecated location

Options
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
    • -65
    • +75
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
10:10 pm

gustafn

reduce verbosity

Options
    • -5
    • +6
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/xotcl-init.tcl
10:08 pm

gustafn

improve spelling

Options
    • -1
    • +10
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -4
    • +8
    /openacs-4/packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl
    • -10
    • +12
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
    • -2
    • +2
    /openacs-4/packages/forums/www/message-view.tcl
    • -2
    • +2
    /openacs-4/packages/news/tcl/test/news-db-test-init.tcl
10:05 pm

gustafn

make listing of tested procs more complete

Options
    • -4
    • +1
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -2
    • +23
    /openacs-4/packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl
    • -3
    • +11
    /openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
    • -1
    • +2
    /openacs-4/packages/acs-templating/tcl/test/spell-checker-procs.tcl
    • -1
    • +4
    /openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
    • -2
    • +6
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
    • -1
    • +18
    /openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl
    • -0
    • +1
    /openacs-4/packages/xowiki/tcl/test/api-test-procs.tcl
    • -14
    • +27
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
    • -0
    • +10
    /openacs-4/packages/xowiki/tcl/test/xowiki-link-test-procs.tcl
    • -6
    • +36
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
10:04 pm

gustafn

make code slightly more regular

Options
    • -15
    • +29
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
    • -15
    • +26
    /openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
9:59 pm

gustafn

no need to use extra namespace for callback

Options
    • -4
    • +4
    /openacs-4/packages/new-portal/new-portal.info
    • -2
    • +2
    /openacs-4/packages/new-portal/tcl/apm-callback-procs.tcl
    • -1
    • +1
    /openacs-4/packages/new-portal/tcl/apm-callback-procs.xql
10:47 am

gustafn

reduce verbosity

Options
    • -3
    • +1
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
Saturday 13 Feb 2021
9:24 pm

gustafn

remove race condition from user/person/party cache management

Options
    • -63
    • +81
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
6:31 pm

gustafn

2 new API functions acs_user::promote_person_to_user and acs_user::demote_user (see issue #3461)

acs_user::promote_person_to_user

Promotes a person/party to an ACS user.

@param person_id the person_id in the acs system that should be promoted to a user.

@param username the username to be used for this user.

Defaults to the person's email

@param password the password to be used for this user.

Defaults to a randomly generated password.

@param authority_id the authority that will be used for the user.

@param locale locale to be used in user preferences.

Defaults to the site wide locale is taken.

@return The user_id of the person promoted to user

@error An error is thrown

if the username is already in use,

or the person_id has no email address,

or if person_id is not in the persons table.

acs_user::demote_user

Demotes an ACS user to a person/party.

This will fail if other tables have content referencing the users

table. It is probably best for tables created in other packages

to reference persons, parties, or acs_objects instead. This proc

could be extended with an option to find all referenced tables and

remove rows referencing this user.

See the following FK relationship in basic OpenACS installations:

TABLE "acs_objects" CONSTRAINT "acs_objects_creation_user_fk" FOREIGN KEY (creation_user) REFERENCES users(user_id)

TABLE "acs_objects" CONSTRAINT "acs_objects_modifying_user_fk" FOREIGN KEY (modifying_user) REFERENCES users(user_id)

TABLE "ad_locale_user_prefs" CONSTRAINT "ad_locale_user_prefs_users_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "auth_batch_job_entries" CONSTRAINT "auth_batch_job_entries_user_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE SET NULL

TABLE "auth_batch_jobs" CONSTRAINT "auth_batch_jobs_user_fk" FOREIGN KEY (creation_user) REFERENCES users(user_id) ON DELETE SET NULL

TABLE "cr_news" CONSTRAINT "cr_news_approval_user_fk" FOREIGN KEY (approval_user) REFERENCES users(user_id)

TABLE "email_images" CONSTRAINT "email_images_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "forums_messages" CONSTRAINT "forums_mess_last_poster_fk" FOREIGN KEY (last_poster) REFERENCES users(user_id)

TABLE "forums_messages" CONSTRAINT "forums_mess_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "forums_reading_info" CONSTRAINT "forums_read_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "lang_messages_audit" CONSTRAINT "lang_messages_audit_ou_fk" FOREIGN KEY (overwrite_user) REFERENCES users(user_id)

TABLE "lang_messages" CONSTRAINT "lang_messages_creation_user_fk" FOREIGN KEY (creation_user) REFERENCES users(user_id)

TABLE "lang_user_timezone" CONSTRAINT "lang_user_timezone_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "notification_replies" CONSTRAINT "notif_repl_from_fk" FOREIGN KEY (from_user) REFERENCES users(user_id)

TABLE "notification_user_map" CONSTRAINT "notif_user_map_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "notifications" CONSTRAINT "notifications_notif_user_fk" FOREIGN KEY (notif_user) REFERENCES users(user_id)

TABLE "notification_requests" CONSTRAINT "notifications_request_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "proctoring_examination_statement_acceptance" CONSTRAINT "proctoring_examination_statement_acceptance_user_id_fkey" FOREIGN KEY (user_id) REFERENCES users(user_id) ON DELETE CASCADE

TABLE "user_portraits" CONSTRAINT "user_portraits_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "user_preferences" CONSTRAINT "user_preferences_user_id_fk" FOREIGN KEY (user_id) REFERENCES users(user_id)

TABLE "xowiki_tags" CONSTRAINT "xowiki_tags_user_id_fkey" FOREIGN KEY (user_id) REFERENCES users(user_id)

Options
    • -9
    • +252
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
Friday 12 Feb 2021
2:19 pm

antoniop

Fix https://openacs.org/bugtracker/openacs/bug?bug_number=3454, many thanks to Maurizio Martignano

Options
    • -2
    • +6
    /openacs-4/packages/assessment/www/asm-admin/item-add.tcl
    • -2
    • +4
    /openacs-4/packages/assessment/www/asm-admin/item-edit-general.tcl
Thursday 11 Feb 2021
5:41 pm

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
5:25 pm

antoniop

Creating the site wide xowiki instance cannot half fail, as it might leave the subsite in an inconsistent state

Fixes acs-admin.acs_admin_require_site_wide automated test

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-init.tcl
3:22 pm

hectorr

Fix tested proc name.

::xo::db::Class get_instance_from_db is defined using ad_proc instead of instproc.

Fixes the acs_api_browser_api_get_body test case.

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl
1:45 pm

antoniop

Fix typo

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
Wednesday 10 Feb 2021
5:29 pm

antoniop

Indroduce new indexes on xolp_activity_hierarchy_bridge and xolp_competency_set_bridge

Options
    • -0
    • +8
    /openacs-4/packages/xolp/tcl/xolp-activity-procs.tcl
    • -0
    • +8
    /openacs-4/packages/xolp/tcl/xolp-competency-procs.tcl
4:02 pm

antoniop

Make sure recipient is enclosed in a list to avoid ambiguity with values containing spaces

Options
    • -2
    • +2
    /openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl
3:47 pm

antoniop

Cast both value and default value

Options
    • -2
    • +2
    /openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl
2:36 pm

antoniop

Introduce a new 'to_display_name' column enabling to specify a display name with which qualify recipients of a bulk mail as e.g. "Members of Group 1"

This is useful to inform the user about who else should be expected to have received the same communication

Options
    • -2
    • +2
    /openacs-4/packages/bulk-mail/bulk-mail.info
    • -1
    • +2
    /openacs-4/packages/bulk-mail/sql/oracle/bulk-mail-create.sql
    • -0
    • +19
    /openacs-4/packages/bulk-mail/sql/oracle/upgrade/upgrade-2.10.0d2-2.10.0d3.sql
    • -1
    • +2
    /openacs-4/packages/bulk-mail/sql/postgresql/bulk-mail-create.sql
    • -0
    • +22
    /openacs-4/packages/bulk-mail/sql/postgresql/upgrade/upgrade-2.10.0d2-2.10.0d3.sql
    • -4
    • +21
    /openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl
2:36 pm

antoniop

file upgrade-2.10.0d2-2.10.0d3.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/bulk-mail/sql/oracle/upgrade/upgrade-2.10.0d2-2.10.0d3.sql
    • -0
    • +0
    /openacs-4/packages/bulk-mail/sql/postgresql/upgrade/upgrade-2.10.0d2-2.10.0d3.sql
12:50 pm

antoniop

Move a bit away from the heavyweight stored-procedure-based standard to schedule bulk_mails, in preparation to accomodate for new metadata

Options
    • -0
    • +21
    /openacs-4/packages/bulk-mail/tcl/bulk-mail-procs-oracle.xql
    • -0
    • +19
    /openacs-4/packages/bulk-mail/tcl/bulk-mail-procs-postgresql.xql
    • -20
    • +43
    /openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl
    • -6
    • +0
    /openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.xql
12:43 pm

antoniop

Basic api test for bulk_mail::new anticipating upcoming reform

Options
    • -0
    • +77
    /openacs-4/packages/bulk-mail/tcl/test/bulk-mail-procs.tcl
12:43 pm

antoniop

file bulk-mail-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/bulk-mail/tcl/test/bulk-mail-procs.tcl
Tuesday 09 Feb 2021
4:20 pm

antoniop

Handle to_addr specified as "DisplayName <email>": keep the display name in the header value and strip it in the RCPT TO

Options
    • -2
    • +16
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
3:34 pm

gustafn

inclass-exam: Added configurability for time budget and display of minutes and/or points during exam

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -1
    • +9
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -1
    • +7
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -3
    • +17
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -1
    • +4
    /openacs-4/packages/xowf/www/prototypes/select_question.form.page