OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 7
Total Committers: 146
Last Commit: 07 Nov
Commits this week: 7
Total Lines of Code (LoC): 7,560,799
Net change in LoC this week: 44

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 18 Feb 2022
11:16 am

antoniop

Include the supplied text_id among the fields we should replace

Options
    • -3
    • +3
    /openacs-4/packages/richtext-xinha/tcl/richtext-procs.tcl
11:14 am

antoniop

Support the extraPlugins attribute the same as the CKEditor4 richtext formfield, as some places in xowiki assume it

Options
    • -2
    • +5
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
10:58 am

trenner

provide value attribute

Options
    • -2
    • +2
    /openacs-4/packages/file-storage/www/version-delete.tcl
10:42 am

antoniop

Reintroduce cast to integer using a portable idiom

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/acs-permissions-procs.tcl
10:29 am

antoniop

Prefer cached API

Options
    • -6
    • +5
    /openacs-4/packages/tsearch2-driver/tcl/tsearch2-driver-procs.tcl
Thursday 17 Feb 2022
9:28 pm

gustafn

improve input validation

Options
    • -1
    • +3
    /openacs-4/packages/notifications/www/request-new.tcl
9:19 pm

gustafn

added validator for zip files

Options
    • -2
    • +25
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl
9:19 pm

gustafn

Fixes for Oracle 19c: more fixes of handling of Boolean values

Options
    • -5
    • +5
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
7:28 pm

antoniop

Significant improvements on the proctoring display UI to help the review process of proctored artifacts:

- user can flag artifacts as OK or to be reviewed

- user can add and delete comments on the single artifacts

- user can filter artifacts by "verified/not verified" "flagged/not flagged" and "all". A counter is displayed showing how many over the total number are being displayed

- interface will update as before when new pictures come in from an ongoing exam

- interface has been designed "mobile first" and with minimal, mostly graphical dependencies, to Bootstrap

Options
    • -2
    • +2
    /openacs-4/packages/proctoring-support/proctoring-support.info
    • -0
    • +8
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +8
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -0
    • +8
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.it_IT.ISO-8859-1.xml
    • -53
    • +438
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
    • -10
    • +21
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
    • -0
    • +103
    /openacs-4/packages/proctoring-support/www/review.tcl
7:28 pm

antoniop

file review.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/proctoring-support/www/review.tcl
4:20 pm

gustafn

Fixes for Oracle 19c: fix data types and interval calculation

Options
    • -8
    • +6
    /openacs-4/packages/acs-templating/sql/oracle/captcha-create.sql
3:17 pm

antoniop

Don't use expressions for the default value, apparently a nono in Oracle

See e.g. https://docs.oracle.com/javadb/10.8.3.0/ref/rrefsqlj30540.html#rrefsqlj30540__sqlj64478

Options
    • -2
    • +7
    /openacs-4/packages/acs-templating/sql/oracle/captcha-create.sql
    • -2
    • +1
    /openacs-4/packages/acs-templating/sql/oracle/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
2:19 pm

gustafn

reduce dependency on adp-level during rendering but get the information directly from the containing objects

Options
    • -11
    • +30
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
11:41 am

gustafn

Fixes for Oracle 19c: added missing Oracle support

Options
    • -19
    • +72
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
11:37 am

gustafn

Fixes for Oracle 19c: consistenly rely on uppercasing of the schema names in the called functions

Options
    • -16
    • +4
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
11:36 am

gustafn

Fixes for Oracle 19c: uppercase consistently in schema queries

All names in the schema data model are in Oracle in uppercase.

Options
    • -8
    • +8
    /openacs-4/packages/acs-kernel/sql/oracle/utilities-create.sql
11:27 am

gustafn

Fixes for Oracle 19c: fixed more cases with Problems with Boolean data types

This fixes e.g. the following problem

[16/Feb/2022:20:55:19][3908.7fa5364fa700][-conn:oacs-5-10-0:default:1:9-] Error: SQL(): nsoracle.c:863:OracleExecPLSQLBind: error in `OCIStmtExecute ()': ORA-06550: line 1, column 13:

: PLS-00382: expression is of wrong type

: ORA-06550: line 1, column 7:

: PL/SQL: Statement ignored

:

: SQL: BEGIN :1 := util.foreign_key_exists(table_name => :table_name,column => :column,reftable => :reftable,refcolumn => :refcolumn); END;

[16/Feb/2022:20:55:19][3908.7fa5364fa700][-conn:oacs-5-10-0:default:1:9-] Notice: ### db_with_handle returned error <nsoracle.c:863:OracleExecPLSQLBind: error in `OCIStmtExecute ()': ORA-06550: line 1, column 13:

: PLS-00382: expression is of wrong type

: ORA-06550: line 1, column 7:

: PL/SQL: Statement ignored

:

Options
    • -173
    • +113
    /openacs-4/packages/acs-kernel/sql/oracle/utilities-create.sql
Wednesday 16 Feb 2022
8:55 pm

gustafn

Fixes for Oracle 19c: output potential errors after command

Options
    • -1
    • +4
    /openacs-4/packages/acs-kernel/sql/oracle/utilities-create.sql
8:22 pm

gustafn

Fixes for Oracle 19c:

- added special rules for DML differences in Oracle ("MODIFY" option in ALTER TABLE)

- fixed call of ns_pg_bind in Oracle applications

- fixed call of an SQL function returning a table

Options
    • -6
    • +43
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
7:45 pm

gustafn

Fixes for Oracle 19c:

- types defined inside an package cannot be used from the outside;

so utility function get_primary_keys() was not usable

- fix various problems with boolean values

Two sample errors raised before the fix:

[16/Feb/2022:16:12:52][20833.7fa027de8940][-main:oacs-5-10-0-] Error: SQL(): nsoracle.c:863:OracleExecPLSQLBind: error in `OCIStmtExecute ()': ORA-06550: line 1, column 13:

: PLS-00382: expression is of wrong type

: ORA-06550: line 1, column 7:

: PL/SQL: Statement ignored

:

: SQL: BEGIN :1 := util.table_column_exists(t_name => :t_name,c_name => :c_name); END;

16/Feb/2022:18:16:39][27419.7fb7a518a940][-main:oacs-5-10-0-] Error: SQL(): nsoracle.c:863:OracleExecPLSQLBind: error in `OCIStmtExecute ()': ORA-06550: line 1, column 13:

: PLS-00382: expression is of wrong type

: ORA-06550: line 1, column 7:

: PL/SQL: Statement ignored

:

: SQL: BEGIN :1 := util.get_primary_keys(table_name => :table_name); END;

[16/Feb/2022:18:16:39][27419.7fb7a518a940][-main:oacs-5-10-0-] Notice: ### db_with_handle returned error <nsoracle.c:863:OracleExecPLSQLBind: error in 'OCIStmtExecute ()': ORA-06550: line 1, column 13:

: PLS-00382: expression is of wrong type

: ORA-06550: line 1, column 7:

: PL/SQL: Statement ignored

:

: SQL: BEGIN :1 := util.get_primary_keys(table_name => :table_name); END;> for statement

: #:log "sql=BEGIN :1 := util.get_primary_keys($sql_args); END;, sql_command=ns_ora exec_plsql_bind $db $sql 1 """

: return [ ns_ora exec_plsql_bind $db $sql 1 "" ]

:

Options
    • -18
    • +21
    /openacs-4/packages/acs-kernel/sql/oracle/utilities-create.sql
3:55 pm

gustafn

Fixes for Oracle 19c: fix syntax and handling of boolean values

This change fixes the following problems:

Errors for PACKAGE ACS_EVENT:

LINE/COL ERROR

-------- -----------------------------------------------------------------

3/5 PL/SQL: Declaration ignored

43/39 PLS-00302: component 'LOCATIONREDIRECT_TO_REL_LINK_P' must be

declared

Warning: Package Body created with compilation errors.

Errors for PACKAGE BODY ACS_EVENT:

LINE/COL ERROR

-------- -----------------------------------------------------------------

19/2 PLS-00103: Encountered the symbol "RELATED_LINK_URL" when

expecting one of the following:

) , * & = - + < / > at in is mod remainder not rem

<an exponent (**)> <> or != or ~= >= <= <> and or like like2

like4 likec between || multiset member submultiset

The symbol "," was substituted for "RELATED_LINK_URL" to

continue.

296/29 PLS-00103: Encountered the symbol "(" when expecting one of the

following:

mod <an identifier> <a double-quoted delimited-identifier>

LINE/COL ERROR

-------- -----------------------------------------------------------------

<a bind variable> continue current sql execute forall merge

pipe purge json_exists json_value json_query json_object

json_array

Options
    • -4
    • +4
    /openacs-4/packages/acs-events/sql/oracle/acs-events-create.sql
2:19 pm

gustafn

Fixes for Oracle 19c: make query portable to Oracle by replacing USING by explicit ON joins

This fixed the following problem, where the problem is not easy to spot on first sight:

[16/Feb/2022:13:26:09][12845.7efd2d3e1700][-sched:0:41:22-] Error: nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00904: "NOTIFICATION_REQUESTS"."USER_ID": invalid identifier

: SQL:

: select notification_id,

: notif_subject,

: notif_text,

: notif_html,

: file_ids,

: user_id,

: request_id,

: type_id,

: delivery_method_id,

: response_id,

: notif_date,

: notif_user,

: acs_permission.permission_p(notification_requests.object_id, !>>>!notification_requests.user_id, 'read') as still_valid_p

: from notifications inner join notification_requests using (type_id, object_id)

: inner join acs_objects on (notification_requests.request_id = acs_objects.object_id)

: left outer join notification_user_map using (notification_id, user_id)

: where sent_date is null

: and creation_date <= notif_date

: and (notif_date is null or notif_date < current_timestamp)

: and interval_id = :interval_id

Options
    • -7
    • +10
    /openacs-4/packages/notifications/tcl/sweep-procs.tcl
1:26 pm

gustafn

Fixes for Oracle 19c: fix broken variable references (introduced in oacs-5-9)

Options
    • -6
    • +6
    /openacs-4/packages/file-storage/sql/oracle/file-storage-package-create.sql
    • -2
    • +2
    /openacs-4/packages/file-storage/sql/oracle/upgrade/upgrade-5.9.1b3-5.9.1b4.sql
1:15 pm

gustafn

Fixes for Oracle 19c: added missing SQL package declaration

Options
    • -1
    • +147
    /openacs-4/packages/file-storage/sql/oracle/file-storage-package-create.sql
Tuesday 15 Feb 2022
10:01 pm

gustafn

Fixes for Oracle 19c: (temporary?) fix for message catalogs

This change fixes the problem that after a fresh installation, all (!)

messages keys are empty. I am not sure what the source of the problem

is, why this has supposedly worked some years before, and whether

there are undesired side-effects of this change. Without this change,

the openacs installation leads to fully broken state.

Options
    • -1
    • +1
    /openacs-4/packages/acs-lang/tcl/lang-message-procs-oracle.xql
7:07 pm

gustafn

Fixes for Oracle 19c: replaced "limit" by the portable idiom "fetch ... rows only"

This fixes the following bug in Oracle installations:

: SQL:

: select aml_email_id from acs_mail_lite_from_external

: where processed_p <>'1'

: and release_p <>'1'

: order by priority

: !>>>!limit :email_max_ct

: nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00933: SQL command not properly ended

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
7:06 pm

gustafn

Fixes for Oracle 19c: quick port of missing tables in acs-mail-lite from PostgreSQL

This is q quick port of the table available from PostgreSQL, which

assures that a new instance of OpenACS on Oracle can run without

spitting out frequent error messages. In essence, the sequence

handling was adjusted, and datatype "text" was replaced by

"varchar(4000)" and in one case by "clob". Probably, some of the

lengths and the update operations have to be adjusted.

Options
    • -1
    • +349
    /openacs-4/packages/acs-mail-lite/sql/oracle/acs-mail-lite-create.sql
6:21 pm

gustafn

Fixes for Oracle 19c: boolean types in query

This fixes the following bug for Oracle:

[13/Feb/2022:17:53:36][8701.7f9f62f0b700][-conn:oacs-5-10-0:default:0:0-] Error: nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00920: invalid relational operator

:

: SQL:

:

: select p.package_id,

: p.instance_name,

: n.node_id,

: n.name,

: :subsite_url || n.name as url,

: (select count(*)

: from group_approved_member_map m

: where m.rel_type = 'membership_rel'

: and m.group_id = ag.group_id) as num_members,

: (select min(r2.member_state)

: from group_member_map m2,

: membership_rels r2

: where m2.group_id = ag.group_id

: and m2.member_id = :untrusted_user_id

: and r2.rel_id = m2.rel_id) as member_state,

: g.group_id,

: g.join_policy

: from site_nodes n,

: apm_packages p,

: application_groups ag,

: groups g

: where n.parent_id = :subsite_node_id

: and p.package_id = n.object_id

: and p.package_key in ('acs-subsite')

: and ag.package_id = p.package_id

: and g.group_id = ag.group_id

: and (g.join_policy !>>>!!= 'closed' or acs_permission.permission_p(p.package_id, :untrusted_user_id, 'read'))

: order by lower(instance_name)

:

Options
    • -1
    • +2
    /openacs-4/packages/acs-subsite/lib/subsites.xql
6:20 pm

gustafn

Fixes for Oracle 19c: boolean types in query

This fixes the following bug for Oracle:

': ORA-00920: invalid relational operator

:

: SQL:

: select p.package_id,

: p.instance_name,

: n.node_id,

: n.name

: from site_nodes n,

: apm_packages p,

: apm_package_types t

: where n.parent_id = :subsite_node_id

: and p.package_id = n.object_id

: and t.package_key = p.package_key

: and t.package_type = 'apm_application'

: and acs_permission.permission_p(p.package_id, :user_id, 'read')

: !>>>!order by upper(instance_name)

:

Options
    • -1
    • +3
    /openacs-4/packages/acs-subsite/lib/applications.tcl
6:10 pm

gustafn

Fixes for Oracle 19c: invalid cast to integer

This fixes the following bug for Oracle:

: invalid positional variable `:', valid values start with 1

: while executing

: "ns_ora 0or1row nsdb0 {

: select acs_permission.permission_p(:object_id, :party_id, :privilege)::integer from dual

: }"

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/acs-permissions-procs.tcl