• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
reduce usage of deprecated procs

modernize tcl

    • -1
    • +1
    ./packages/news-aggregator/www/index.tcl
use proper boolean in .adp files

modernize Tcl

reduce usage of deprecated procs

    • -2
    • +2
    ./packages/dotlrn-admin/www/admin/class.tcl
    • -2
    • +2
    ./packages/dotlrn-admin/www/admin/club.tcl
    • -2
    • +2
    ./packages/dotlrn-admin/www/admin/clubs.tcl
replace depreacted proc site_nodes_sync

remove traces of deprecated proc

    • -1
    • +1
    ./packages/tasks/tcl/tasks-install-procs.tcl
Stop using deprecated proc site_map_unmount_application

    • -9
    • +10
    ./packages/edit-this-page/www/etp-trash.tcl
    • -8
    • +0
    ./packages/edit-this-page/www/etp-trash.xql
stop using deprecated procs site_map_unmount_application and site_node_id

    • -5
    • +7
    ./packages/news/tcl/test/news-db-test-init.tcl
stop using deprecated procs (site_node_delete_package_instance, site_node_id)

    • -4
    • +5
    ./packages/dotlrn/tcl/dotlrn-procs.tcl
simplify code

whitespace cleanup

replace depreacted proc

Mark procs as deprecated, which were previously just documented as

deprecated and document recommended versions via @see. These procs

should be moved to *deprecated*.tcl after a while to give people

a chance to react (maybe in 5.11 or 5.12).

site_node::conn_url -> ad_conn

site_nodes_sync -> site_node::init_cache

site_node_id -> site_node::get_node_id -url

site_map_unmount_application -> site_node::unmount

site_node_delete_package_instance -> site_node::delete

    • -6
    • +12
    ./packages/acs-tcl/tcl/site-nodes-procs.tcl
Fix typo

    • -3
    • +3
    ./packages/xotcl-core/tcl/03-doc-procs.tcl
Prefer lappend over concat for appending lists (lappend modifies the variable 'in place')

    • -2
    • +2
    ./packages/acs-templating/tcl/list-procs.tcl
Prefer lappend over concat for appending lists (lappend modifies the variable 'in place')

    • -2
    • +2
    ./packages/acs-tcl/tcl/00-database-procs.tcl
make prepared statement parser more robust against sql casts

moderniize tcl

    • -7
    • +7
    ./packages/xotcl-core/tcl/05-db-procs.tcl
improve documentation

    • -2
    • +6
    ./packages/xotcl-core/tcl/03-doc-procs.tcl
modernize tcl

    • -3
    • +3
    ./packages/xowiki/tcl/folder-procs.tcl
    • -3
    • +3
    ./packages/xowiki/tcl/form-field-procs.tcl
    • -3
    • +3
    ./packages/xowiki/tcl/includelet-procs.tcl
    • -3
    • +3
    ./packages/xowiki/tcl/package-procs.tcl
    • -3
    • +3
    ./packages/xowiki/tcl/xowiki-procs.tcl
    • -2
    • +2
    ./packages/xowiki/tcl/xowiki-www-procs.tcl
    • -1
    • +1
    ./packages/xotcl-core/tcl/01-debug-procs.tcl
modermize tcl

    • -5
    • +5
    ./packages/acs-tcl/tcl/navigation-procs.tcl
modernize tcl

    • -2
    • +2
    ./packages/acs-tcl/tcl/navigation-procs.tcl
    • -5
    • +7
    ./packages/acs-tcl/tcl/xml-1-dom-procs.tcl
    • -2
    • +3
    ./packages/acs-templating/tcl/date-procs.tcl
modernize Tcl

    • -4
    • +4
    ./packages/dotlrn/tcl/navigation-procs.tcl
Performance: prefer lset over lreplace for modifying list values.

When a list element is modified, lset does it "in place", modifying the

variable itself, while lreplace works with values and returns a second copy

of the list with the modified elements, creating some unnecessary overhead.

On my local tests, this particular operation was around 30% faster.

More details: http://wiki.tcl.tk/1485 and http://wiki.tcl.tk/2556

    • -2
    • +2
    ./packages/acs-templating/tcl/parse-procs.tcl
Fix typo

Fix typos

    • -2
    • +2
    ./packages/address-book/doc/requirements.html
    • -10
    • +10
    ./packages/ams/catalog/ams.en_US.ISO-8859-1.xml
    • -4
    • +4
    ./packages/ams/tcl/telecom-number-widget-procs.tcl
  1. … 136 more files in changeset.
fix typos

prefer XOTcl2 idioms

modernize tcl

Fix typos

Fix typo (info command -> info commands)

Fix get_community_id_from_url call