• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rework array idioms

    • -26
    • +18
    ./packages/bug-tracker/tcl/bug-procs.tcl
Finish array reform in this proc

    • -8
    • +9
    ./packages/acs-tcl/tcl/apm-install-procs.tcl
Rework array idioms

    • -5
    • +3
    ./packages/assessment/lib/assessment.tcl
    • -8
    • +4
    ./packages/assessment/lib/section-items.tcl
    • -9
    • +5
    ./packages/assessment/lib/session-items.tcl
Whitespace cleanup

    • -16
    • +16
    ./packages/assessment/lib/section-items.tcl
Rework array idioms

    • -14
    • +12
    ./packages/acs-tcl/tcl/test/doc-check-procs.tcl
    • -13
    • +15
    ./packages/acs-tcl/tcl/test/file-test-procs.tcl
Formatting changes

    • -12
    • +12
    ./packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
Prefer unset to array unset when no pattern matching is needed

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Rework array idioms into dict idioms where appropriate

Cleanup array idioms

Rework array idioms in dict idioms where appropriate, avoid unsetting arrays via pattern matching

Rework array idioms into dict idioms hwre appropriate, e.g.:

- when the return value of a proc is already a dict in itself

- when the return value of a proc should be completely overwritten in later tests

This avoids array "unwrapping" operations and unsets

Prefer unset to array unset when no pattern matching is needed

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

    • -2
    • +2
    ./packages/xml-rpc/tcl/system-procs.tcl
No need to fiddle in the ad_conn array if we just reset it

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

    • -2
    • +2
    ./packages/xowiki/tcl/includelet-procs.tcl
    • -2
    • +1
    ./packages/xowiki/tcl/notification-procs.tcl
    • -2
    • +2
    ./packages/xowiki/tcl/xowiki-procs.tcl
    • -9
    • +7
    ./packages/acs-tcl/tcl/apm-install-procs.tcl
Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

    • -2
    • +2
    ./packages/search/tcl/search-procs.tcl
    • -1
    • +1
    ./packages/xotcl-core/tcl/01-debug-procs.tcl
    • -2
    • +2
    ./packages/xotcl-core/tcl/context-procs.tcl
    • -3
    • +3
    ./packages/xotcl-core/tcl/cr-procs.tcl
    • -2
    • +2
    ./packages/xotcl-core/www/show-object.tcl
Prefer unset to array unset when the whole array should be deleted, rework array idioms into tcl idioms when an array is not needed

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Prefer unset to array unset when we do not need a pattern match

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Rework so that an array is not needed

    • -8
    • +3
    ./packages/new-portal/tcl/portal-procs.tcl
Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

    • -2
    • +2
    ./packages/forums/tcl/messages-procs.tcl
Rework array idioms

    • -5
    • +6
    ./packages/categories/tcl/widget-procs.tcl
Modernize tcl idioms

    • -11
    • +8
    ./packages/acs-templating/tcl/query-procs.tcl
Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

    • -7
    • +7
    ./packages/acs-templating/tcl/head-procs.tcl
    • -2
    • +2
    ./packages/acs-templating/tcl/list-procs.tcl
    • -3
    • +3
    ./packages/acs-templating/tcl/query-procs.tcl
    • -1
    • +1
    ./packages/caldav/tcl/caldav-procs.tcl
Prefer unset to array unset when the whole array should be deleted, rework array idioms into dict idioms to avoid unsetting the array, where appropriate

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

    • -5
    • +7
    ./packages/acs-tcl/tcl/apm-install-procs.tcl
    • -8
    • +6
    ./packages/acs-tcl/tcl/site-nodes-procs.tcl
    • -2
    • +2
    ./packages/acs-tcl/tcl/text-html-procs.tcl
Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

    • -2
    • +2
    ./packages/acs-subsite/tcl/subsite-procs.tcl
Rework array idioms in dict idioms, closer to the intended logics

Cleanup include found to not be in use in upstream codebase already in 2019

    • -1
    • +0
    ./packages/acs-subsite/lib/services.adp
    • -53
    • +0
    ./packages/acs-subsite/lib/services.tcl
Rework array idioms into dict idioms to avoid the need to unset

    • -12
    • +12
    ./packages/acs-lang/tcl/lang-catalog-procs.tcl
Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Streamline idiom