• last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rework array idioms in dict idioms, closer to the intended logics

Cleanup include found to not be in use in upstream codebase already in 2019

    • -1
    • +0
    ./packages/acs-subsite/lib/services.adp
    • -53
    • +0
    ./packages/acs-subsite/lib/services.tcl
Rework array idioms into dict idioms to avoid the need to unset

    • -12
    • +12
    ./packages/acs-lang/tcl/lang-catalog-procs.tcl
Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Streamline idiom

Prefer unset to array unset when the purpose is to delete the whole array

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Prefer unset to array unset when we want to delete the entire array

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

    • -7
    • +2
    ./packages/acs-admin/tcl/apm-admin-procs.tcl
    • -8
    • +6
    ./packages/acs-admin/www/install/install-2.tcl
    • -2
    • +2
    ./packages/acs-admin/www/install/install-3.tcl
Prefer unset to array unset when the semantic is to delete the whole array

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

State Highcharts package dependency in xotcl-request-monitor

Other leftovers

    • -30
    • +0
    ./packages/chat/www/transcript-edit-2.tcl
    • -43
    • +0
    ./packages/chat/www/transcript-new-2.tcl
Other files deleted

    • -24
    • +0
    ./packages/chat/www/moderator-revoke-2.tcl
    • -26
    • +0
    ./packages/chat/www/moderator-revoke.tcl
Delete more zombie files

    • -24
    • +0
    ./packages/chat/www/moderator-grant-2.tcl
    • -35
    • +0
    ./packages/chat/www/moderator-grant.tcl
Delete zombie file from merge with MAIN

    • -46
    • +0
    ./packages/chat/www/chat-room-grant.tcl
Trap illegal encoding exception thrown by tcl9 when a file contains invalid UTF-8 and skip the package with a warning

Unmaintained packages may contain illegal characters and we do not want the UI to crash in this situation

Limit files__tcl_file_common_errors test to installed packages

Unmaintained packages may ship files with invalid encodings, which tcl9 won't tolerate anymore.

Improve test

- skip packages that are not installed before we check the info file

- ensure all installed packages have an info file

This fixes the test for tcl9, where some unmaintained packages may fail the file parsing because of invalid encoding.

Tcl9 regression test: deactivated case broken in tcl9 with unclear semantics

    • -40
    • +45
    ./packages/acs-tcl/tcl/test/http-client-procs.tcl
whitespace change

    • -4
    • +4
    ./packages/acs-tcl/tcl/acs-db-12-procs.tcl
tcl9 changes in regression test: "2000-00-00 00:00:00" is not a valid date anymore

tcl9 changes: "string bytelength" does not exist in tcl9

    • -13
    • +12
    ./packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
tcl9 changes in regression test: fix read of latin1 file with wrong encoding

tcl9 changes in regression test: address changes in tcl9 tilde explansion

tcl9 change: "... -encoding binary ..." not valid in tcl9

    • -2
    • +2
    ./packages/xotcl-core/tcl/utilities-procs.tcl
regenerated resources

removed file deleted in branch oacs-5-10

    • -3810
    • +0
    ./packages/acs-tcl/tcl/00-database-procs.tcl
child-resources: render bulk-actions iff rows are selectable

    • -7
    • +9
    ./packages/xowiki/tcl/folder-procs.tcl
Ensure we fail the check and complain when a localurl is invalid

Update acs-kernel.info

Author: Adrian Ferenc <68762863+adrianferenc@users.noreply.github.com>

Committer: GitHub <noreply@github.com>

Fix passing complaints info to the complain template

Bugfixes for TinyMCE 7 richtext editor in the context of xowiki repeated fields

- handle via a specific snippet in repeat.js the case of a repeated field being deleted. The editor must be persisted and removed before it is eventually loaded again on the remaining fields.

- use a simpler and more solid logic in the mutation observer to handle cases like compound questions in LEARN that are repeated+compound+repeatedCompound

    • -43
    • +14
    ./packages/xowiki/tcl/form-field-procs.tcl
    • -0
    • +16
    ./packages/xowiki/www/resources/repeat.js