• last updated 50 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
support grading passed in via property

still initialize array

improve comment.

since "nsv_get $array $member varname" returns 0, when the array does not exist, we do not need the extra value for initialization

cache parsed form_constraints via nsv instead of via global variable

- Define converters as procs

- Register these procs as aliases where convenient

- this effects:

dict_to_fc, dict_to_spec, spec_to_dict, fc_to_dict, dict_value

- extended regression test

- bumped version number to 5.10.1d9

    • -38
    • +140
    ./xowiki/tcl/form-field-procs.tcl
    • -0
    • +76
    ./xowiki/tcl/test/api-test-procs.tcl
minor editing changes

improve location of comment

prefer "Package require" over "Package initialize" when possible

    • -1
    • +1
    ./xowiki/tcl/test/xowiki-test-procs.tcl
adjust code with regression test, which performs literal comparison of rendered content

    • -3
    • +3
    ./xowiki/tcl/test/xowiki-admin-tests-procs.tcl
    • -1
    • +1
    ./xowiki/tcl/test/xowiki-link-test-procs.tcl
    • -2
    • +2
    ./xowiki/tcl/test/xowiki-test-procs.tcl
performance improvements for "::xo::db::Class proc get_instance_from_db"

when the object exists already, the text for existance is made earlier

to void useless operations. This change improves the performance by a factor of 3

when the object was already loaded.

OLD {4.544836 microseconds per iteration}

NEW {1.310991 microseconds per iteration}

Smartify idioms

    • -15
    • +16
    ./acs-templating/tcl/tag-init.tcl
Fix typo

reduce verbosity

Similar to the folder-create script, complain if the filename turns out empty after sanitizing

Allow the maximum size permitted by the datamodel in the UI, but then validate it before saving

    • -2
    • +2
    ./calendar/www/calendar-item-types.tcl
When deleting, make sure supplied id is actually a room id

Trap the attempt to retrieve a non-existing forum and return a 404 in this case

this might need to happen in other places and/or be refined

Make error consistent with the already existing check in the content-repository

Handle more gracefully the case, which should not happen on a production system, that the file being downloaded does not exist on the filesystem

simplify idioms

- deactivate unused link-templates

- make quoting of label more consistent (it is passed in already quoted from the rich-text editors)

- whitespace changes

    • -125
    • +146
    ./xowiki/tcl/link-procs.tcl
Deprecate template::util::list_opts: it can be replaced by trivial tcl idioms

    • -1
    • +24
    ./acs-templating/tcl/deprecated-procs.tcl
    • -20
    • +1
    ./acs-templating/tcl/util-procs.tcl
Streamline ns_set idioms

    • -5
    • +2
    ./acs-developer-support/tcl/acs-developer-support-procs.tcl
Streamline ns_set idiom

Streamline idioms

Streamline ns_set idioms

    • -36
    • +9
    ./acs-templating/tcl/query-procs.tcl
    • -9
    • +3
    ./acs-templating/tcl/paginator-procs.tcl
Fix typo

    • -1
    • +2
    ./acs-tcl/tcl/request-processor-procs.tcl
Deprecate template::util::set_to_vars: it can be replaced with trivial idioms

    • -1
    • +30
    ./acs-templating/tcl/deprecated-procs.tcl
    • -25
    • +1
    ./acs-templating/tcl/util-procs.tcl
Deprecate template::util::set_to_list: this proc can be replaced with trivial ns_set and tcl idioms

    • -1
    • +28
    ./acs-templating/tcl/deprecated-procs.tcl
    • -25
    • +1
    ./acs-templating/tcl/util-procs.tcl