• last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improve test robustness:

the folder in the test is required, so it might be the case that its state was already tampered with. Change the test to first make sure the state from db and object are consistent, whatever they are, then perform some set/fetch/check tests on 3 arbitrary states

    • -13
    • +15
    ./tcl/test/xowiki-test-procs.tcl
extended regression test

    • -10
    • +117
    ./tcl/test/xowiki-test-procs.tcl
improve spelling

make API call a public one

issue error for unexpected value

added missing space

date formfield does not need special conversion when converting to external, its value is already converted when rendered

prefer YUI 2.9.0 when available

Upgrade to jQuery UI 1.13.1

    • -2
    • +2
    ./www/resources/jquery/jquery-ui.min.js
Updated inferface for Page->create_form_page_instance

Since "create_form_page_instance" creates always a form

page, we can also pass the state at creation to it

(like other essential parameters). The default value

is "initial" (the default state in workflows).

Bumped version number to 5.10.1d15

updated list of tested functions

    • -6
    • +6
    ./tcl/test/xowiki-admin-tests-procs.tcl
refactor code

safetybelt for acunetix testing: refetch parameter page, when it is not initialized

hopefully a temporary measure

Test reproducing an upstream use case: a compound field made of both regular, and compound field, with the compound field also repeated

This test exposes a bug in the acs::test::xpath::get_form_values proc

    • -0
    • +123
    ./tcl/test/xowiki-test-procs.tcl
improve spelling

  1. … 3 more files in changeset.
deactivate language tool when spellcheck is turned off

Added validation on values provided for options

fix default value for nls_language

prefer "string first" over "string match" (the first one is slightly faster)

Use package_id instead of the package object

fix typo

Added policy priviledge "create-from-prototype"

In certain situations, creating pages from prototype pages might not

be allowed for certain users. The off-the-shelf policies allow

"create-from-prototype" to all users having "create" permissions on

the package_id (very similar to edit-new).

Improve program comments.

Don't break the page cyclus protocol if not necessary.

There is no need to call ad_script_abort in a situation,

where the local installation is broken.

list covered test cases

  1. … 1 more file in changeset.
Address issue with .SELF. references in exams (xowf)

Since it is the goal of the exams to store all resources directly

under the questions, handling extra .SELF. references (which are

inserted by a downstream plugin for CKeditor) do not make sense. A

probably cleaner solution to this is to configure the CKeditor

to omit the .SELF. references in these cases.

address (partly) the issue with .SELF. links in exams

Added convenience function ::xowiki::test::get_content

This function eases testing by just retrieving the content part of a

page, leaving out header and footers of the theme.

whitespace changes

cleanup test

use more compact idioms, remove useless code, etc.

    • -30
    • +11
    ./tcl/test/xowiki-test-procs.tcl
added a test for checking the results of the preview of test-items

Since the preview workflow requires a multiple redirects, xowiki::test::edit_form_page

requires a new flag refetch to actually turn off automatic refetching of the result

page, since this does not give us access to the redirect location returned by

the edit command.

  1. … 2 more files in changeset.