OpenACS / openacs-4 / packages

notifications

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 44
Last Commit: 13:32
Commits this week: 0
Total Lines of Code (LoC): 10,059
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 38 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 01 Nov 2022
5:15 pm

gustafn

prefer usage of parameter::get_from_package_key over plain parameter::get

Options
    • -4
    • +5
    ./tcl/reply-sweep-init.tcl
    • -4
    • +5
    ./tcl/sweep-init.tcl
Thursday 13 Oct 2022
12:54 pm

gustafn

Fix incorrect HTTP status code on result page

The command "ad_return_error" returns HTTP status code 500 (internal server error).

In this script, this status code was returned in cases, where no notifications

were found for an object. "ad_return_exception_page" is better suited for such

cases.

Options
    • -2
    • +2
    ./www/subscribers.tcl
Tuesday 23 Aug 2022
8:44 pm

gustafn

Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

Options
    • -10
    • +18
    ./tcl/notification-callback-procs.tcl
  2. … 13 more files in changeset.
Tuesday 12 Jul 2022
4:16 pm

antoniop

Whitespace cleanup

Options
    • -11
    • +11
    ./tcl/notification-type-procs.tcl
4:15 pm

antoniop

Use quicker idiom to check for existance

Options
    • -2
    • +7
    ./tcl/notification-request-procs.tcl
    • -9
    • +0
    ./tcl/notification-request-procs.xql
4:05 pm

antoniop

Whitespace cleanup

Options
    • -3
    • +3
    ./tcl/notification-display-procs.tcl
    • -3
    • +3
    ./tcl/notification-reply-procs.tcl
4:02 pm

antoniop

Whitespace changes

Options
    • -3
    • +3
    ./tcl/delivery-method-procs.tcl
1:30 pm

antoniop

Prefer api to retrieve the approval state of a user

Options
    • -2
    • +2
    ./tcl/notifications-security-procs.tcl
    • -14
    • +0
    ./tcl/notifications-security-procs.xql
Monday 11 Jul 2022
5:50 pm

antoniop

Complete coverage for the notification package

Options
    • -0
    • +247
    ./tcl/test/notifications-test-procs.tcl
5:09 pm

antoniop

Brutally delete the notification requests before deleting the delivery method (it's fine because it will be rolled back)

Options
    • -0
    • +1
    ./tcl/test/notifications-test-procs.tcl
2:56 pm

antoniop

Fix issue in the query logics: we actually want to check the owner of the request, there might be multiple requests associated to the same object

Options
    • -6
    • +6
    ./tcl/notifications-security-procs.tcl
    • -1
    • +10
    ./tcl/test/notifications-test-procs.tcl
2:49 pm

antoniop

Extend coverage, this will expose an api bug

Options
    • -0
    • +179
    ./tcl/test/notifications-test-procs.tcl
11:29 am

hectorr

Whitespace changes

Options
    • -26
    • +25
    ./www/request-notification.tcl
10:58 am

antoniop

Extend coverage

Options
    • -1
    • +27
    ./tcl/test/notifications-test-procs.tcl
10:42 am

antoniop

Cover more api

Options
    • -0
    • +42
    ./tcl/test/notifications-test-procs.tcl
10:23 am

antoniop

Extend automated tests

Options
    • -0
    • +124
    ./tcl/test/notifications-test-procs.tcl
10:07 am

antoniop

Allow to specify a user that does not come from the connection

Options
    • -2
    • +7
    ./tcl/notification-display-procs.tcl
Friday 08 Jul 2022
6:18 pm

antoniop

Expand tests

Options
    • -2
    • +80
    ./tcl/test/notifications-test-procs.tcl
5:54 pm

antoniop

Improve test a bit

Options
    • -2
    • +9
    ./tcl/test/notifications-test-procs.tcl
5:46 pm

antoniop

Update documentation to best practices

Options
    • -10
    • +8
    ./tcl/notification-display-procs.tcl
5:16 pm

antoniop

Fix proc signature

Options
    • -2
    • +2
    ./tcl/notification-procs.tcl
    • -1
    • +1
    ./tcl/test/notifications-test-procs.tcl
    • -1
    • +1
    ./www/request-notification.tcl
  4. … 5 more files in changeset.
5:06 pm

antoniop

Replace leftover occurrences

Options
    • -2
    • +2
    ./tcl/notification-procs.tcl
    • -1
    • +1
    ./www/admin/sweep-now.tcl
4:53 pm

antoniop

Deprecate notification::get_delivery_method_id, same as notification::delivery::get_id and looking more established

Options
    • -2
    • +7
    ./tcl/notification-procs.tcl
    • -2
    • +2
    ./tcl/test/notifications-test-procs.tcl
    • -1
    • +1
    ./www/request-notification.tcl
  4. … 5 more files in changeset.
4:36 pm

antoniop

Deprecate notification::get_interval_id, duplicated by notification::interval::get_id_from_name which appears to be more established

Options
    • -3
    • +8
    ./tcl/notification-procs.tcl
    • -21
    • +38
    ./tcl/test/notifications-test-procs.tcl
    • -1
    • +1
    ./www/request-notification.tcl
  4. … 3 more files in changeset.
11:23 am

antoniop

Prefer flushing the cache, this addresses the automated test, where multiple insert/deletion are performed in the same request

Options
    • -3
    • +2
    ./tcl/notification-type-procs.tcl
11:22 am

antoniop

Extend test

Options
    • -12
    • +36
    ./tcl/test/notifications-test-procs.tcl
10:50 am

antoniop

Cache the new type_id immediately in the (rare) event that a type was created in a previous request with the same name and then deleted

Options
    • -2
    • +5
    ./tcl/notification-type-procs.tcl
10:47 am

antoniop

Expand test

Options
    • -1
    • +10
    ./tcl/test/notifications-test-procs.tcl
Thursday 07 Jul 2022
5:52 pm

antoniop

Fix typo in xql file

Options
    • -1
    • +1
    ./tcl/notification-request-procs-postgresql.xql
5:52 pm

antoniop

Extend notifications tests

Options
    • -0
    • +154
    ./tcl/test/notifications-test-procs.tcl