OpenACS / openacs-4 / packages

file-storage

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 66
Last Commit: 26 Apr
Commits this week: 0
Total Lines of Code (LoC): 26,014
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 24 Feb 2023
5:18 pm

antoniop

Increase proc coverage

Options
    • -1
    • +169
    ./tcl/test/file-storage-procs.tcl
4:04 pm

antoniop

Deprecate fs::add_created_version

This api was nowhere used in upstream code, however, allowed to create a new file object revision by text content, different from fs::add_version, which would only allow to create a revision from a file.

As the two apis were otherwise identical, I have ported the behavior of fs::add_created_version info fs::add_version.

The new fs::add_version will also take many defaults for unspecified parameters from the existing content item.

Options
    • -37
    • +110
    ./tcl/file-storage-procs.tcl
2:50 pm

antoniop

Make service contract implementation private

Options
    • -4
    • +6
    ./tcl/file-storage-procs.tcl
Monday 20 Feb 2023
10:55 am

antoniop

Don't load the DAV callbacks when oacs-dav is not installed

Options
    • -1
    • +6
    ./tcl/file-storage-dav-procs.tcl
Wednesday 15 Feb 2023
6:00 pm

antoniop

Commit remaining files

Options
    • -1
    • +57
    ./tcl/file-storage-dav-procs.tcl
    • -0
    • +2
    ./tcl/file-storage-init.tcl
    • -3
    • +2
    ./tcl/file-storage-install-procs.tcl
    • -4
    • +8
    ./tcl/file-storage-procs.tcl
6:00 pm

antoniop

Make oacs-dav an optional dependency for the file-storage package

Callback implementations and folder registrations will happen only when the package is detected at startup. For existing installations, no action is performed, buit the oacs-dav package can now be deleted without complaints.

Options
    • -3
    • +2
    ./file-storage.info
Friday 27 Jan 2023
12:59 pm

gernst

Improve validation

Options
    • -1
    • +3
    ./www/file-add.tcl
    • -1
    • +2
    ./www/file-edit.tcl
Monday 16 Jan 2023
5:11 pm

antoniop

Fix typo

Options
    • -1
    • +1
    ./www/folder-chunk-postgresql.xql
Wednesday 04 Jan 2023
1:21 pm

antoniop

Refactor the query in the folder-chunk page so that on postgres one can enforce permissions in bulk, rather than for each file

Options
    • -0
    • +47
    ./www/folder-chunk-postgresql.xql
    • -31
    • +2
    ./www/folder-chunk.tcl
    • -3
    • +31
    ./www/folder-chunk.xql
Wednesday 30 Nov 2022
9:18 am

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -5
    • +3
    ./www/download-archive/index.vuh
  2. … 2 more files in changeset.
Sunday 27 Nov 2022
11:52 am

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -5
    • +3
    ./tcl/file-storage-procs.tcl
    • -5
    • +3
    ./tcl/test/file-storage-procs.tcl
    • -2
    • +1
    ./tcl/test/webtest-procs.tcl
    • -2
    • +1
    ./www/download-zip.tcl
    • -5
    • +3
    ./www/file-add.tcl
    • -3
    • +2
    ./www/folder-zip-add.tcl
  7. … 1 more file in changeset.
Friday 28 Oct 2022
8:16 pm

gustafn

prefer adp:icon over old-style .gif files

Options
    • -2
    • +2
    ./lib/folder-links.tcl
Saturday 22 Oct 2022
7:47 pm

gustafn

provided a helper proc to query the mapping of a generic icon name to a concrete

This function is necessary in boundary cases, where e.g. a display_template passes the generic

name of the icon via template variables which have to be

@-substituted before adp-tag resolution, which performs the

regular icon name mapping (otherwise, the tag resolver receives

e.g. ...name=@icon@...)

Options
    • -3
    • +3
    ./file-storage.info
    • -5
    • +5
    ./www/folder-chunk.tcl
  3. … 2 more files in changeset.
Thursday 20 Oct 2022
9:07 pm

gustafn

prefer adp:icon over old-style .gif images

Options
    • -7
    • +7
    ./www/folder-chunk.tcl
  2. … 2 more files in changeset.
Thursday 13 Oct 2022
12:21 pm

antoniop

Don't go to the cache to tell if a command is available

Options
    • -2
    • +2
    ./www/view/index.vuh
12:19 pm

antoniop

Don't go to the cache to tell if commands are available

Options
    • -2
    • +2
    ./www/file.tcl
    • -2
    • +2
    ./www/index.vuh
    • -3
    • +3
    ./www/download/index.vuh
12:15 pm

antoniop

Don't go to the cache to tell if the views package is installed

Options
    • -3
    • +4
    ./www/folder-chunk.tcl
Tuesday 20 Sep 2022
2:16 pm

antoniop

Make service contract implementation private and replace foreign occurrences

Options
    • -10
    • +37
    ./tcl/file-storage-dav-procs.tcl
  2. … 1 more file in changeset.
2:00 pm

antoniop

Whitespace changes

Options
    • -17
    • +17
    ./tcl/file-storage-dav-procs.tcl
Monday 12 Sep 2022
5:38 pm

antoniop

Make service contract implementation private: they are not meant to be invoked directly

Options
    • -14
    • +14
    ./tcl/file-storage-dav-procs.tcl
Friday 09 Sep 2022
4:38 pm

antoniop

Make service contract implementations private

Options
    • -3
    • +3
    ./tcl/file-storage-search-procs.tcl
4:37 pm

antoniop

Whitespace cleanup

Options
    • -6
    • +6
    ./tcl/file-storage-search-procs.tcl
3:03 pm

antoniop

Deprecate twt::user::create and twt::user::delete, superseded by their acs::test::user:: counterparts

Options
    • -5
    • +5
    ./tcl/test/file-storage-procs.tcl
  2. … 11 more files in changeset.
Thursday 01 Sep 2022
12:41 am

antoniop

Fix self-inflicted bug: one should indeed be able to specify the same form var multiple time, test the behavior for the future

Options
    • -1
    • +1
    ./tcl/test/webtest-procs.tcl
  2. … 2 more files in changeset.
Wednesday 31 Aug 2022
2:55 pm

antoniop

Reimplement upload automated test using a real multipart request, as newer naviserver will reject handcrafted .tmpfile parameters

Options
    • -9
    • +19
    ./tcl/test/webtest-procs.tcl
Thursday 25 Aug 2022
1:29 pm

antoniop

Bring test closer to reality

Options
    • -6
    • +14
    ./tcl/test/webtest-procs.tcl
Wednesday 24 Aug 2022
10:58 am

antoniop

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.

Options
    • -1
    • +121
    ./tcl/test/file-storage-procs.tcl
    • -1
    • +5
    ./www/file-add.tcl
  3. … 1 more file in changeset.
9:05 am

antoniop

Whitespace cleanup

Options
    • -6
    • +6
    ./tcl/test/webtest-procs.tcl
Sunday 26 Jun 2022
9:28 pm

gustafn

acs::test::user::delete: added flag -delete_created_acs_objects and fix regression test for file-storage

Options
    • -3
    • +3
    ./file-storage.info
    • -3
    • +4
    ./tcl/test/file-storage-procs.tcl
  3. … 4 more files in changeset.
Thursday 31 Mar 2022
6:28 pm

antoniop

Prevent names made only of invalid characters to end up null after sanitization, as done in other UIs in this package

Options
    • -2
    • +14
    ./www/folder-edit.tcl