• last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fix overquoting in notification-widget

  1. … 6 more files in changeset.
Localize file-size limits in the UI

Introduce a client-side check for the maximum file size, inform user of current limit and improve file-size related localization

Prettify code

Remove obsolete xql files

    • -26
    • +0
    ./www/version-delete-postgresql.xql
Bugfixes et al:

- don't throw a server error if one clicks submit on the empty form without specifying a file

- allow to upload the same zipfile multiple times without throwing an error

- streamline idioms

File storage max upload limit reform:

the max upload limit will now default to empty. Rationale: this value is

one that ages quickly with respect to new storage requirements, and is

currently set to something incompatible with the vanilla Naviserver configuration

(500MB fs vs 20MB ns).

The upgrade script will make so that instances setting this parameter

higher than the server upload limit configuration will be

set empty as well (this would never have an effect, as server

will prevent the upload altogheter anyway).

Max upload limit in bytes is now retrieved from a proc implementing

this fallback to server configuration logics. Other than centralizing,

its purpose is to be used in client-side code checks in the future

so we could prevent a doomed upload in advance.

    • -2
    • +28
    ./tcl/file-storage-install-procs.tcl
  1. … 1 more file in changeset.
Add ad_include_contract and documentation to this page

Fix typos

  1. … 8 more files in changeset.
Whitespace changes

    • -39
    • +39
    ./tcl/file-storage-callback-procs.tcl
    • -101
    • +98
    ./tcl/test/file-storage-procs.tcl
Fix typos and wording.

create folder only if it not already exists

Removed obsolete @arch-tag

    • -3
    • +2
    ./sql/oracle/upgrade/upgrade-5.1.0a13-5.1.0a14.sql
  1. … 23 more files in changeset.
Removed obsolete @arch-tag

  1. … 58 more files in changeset.
- removed extra colons

- streamline layout of test cases

    • -12
    • +62
    ./tcl/test/file-storage-procs.tcl
Whitespace changes

  1. … 2 more files in changeset.
Fix parameter name in proc doc and add brief descriptions

  1. … 3 more files in changeset.
Remove commented leftover debugging statement, add comment about why we need to name the list by folder_id

Put template::list name back as parametric, because this code might be included multiple times

Redefine this page as ad_include_contract, therefore removing all hardcoded variable checks and exploit builtin checks, remove duplicated definitions and queries, streamline template::list definitions in a way its is readable and simpler to maintain

Pass also orderby to the includelet

Trim whitespaces

Remove unnecessary parentheses and idioms, state query variables explicitly

don't pass deprecated argumentent "-user_id" to fs::get_folder_contents_count

  1. … 1 more file in changeset.
Move callback hooks definitions together with their siblings, add documentation to public procs (fixes automated tests)

    • -94
    • +135
    ./tcl/file-storage-callback-procs.tcl
    • -39
    • +1
    ./tcl/file-storage-install-procs.tcl
Add documentation for public procs (fixes automated tests)

Add documentation to public callback hook (fixes automated tests)

Set package_id explicitly as the main subsite package, as ad_conn package_id could not be properly initialized when a system was freshly restarted

Prefer 'person::name' to 'acs_user::get_element ... -name'

Fiy typo