• last updated 14 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Replace permission::require_write_permission with permission::require_permission across the calendar package

Rationale: permission::require_write_permission assumes the object creator to have write permission on the object. Instead, we should rely on permissions to be set correctly on the calendar. permission::require_write_permission also performs an additional query to retrieve the object creator.

It is unclear whether permission::require_write_permission makes sense at all as an api, but we leave this to a future post-release reform.

Test cornercase encountered in practice: a user claims a timezone different to that of the system and creates a calendar item in various formats

This test currently fails, because when we convert the time between the user and the system timezone, we are too strict and allow only the "long" timestamp format "%Y-%m-%d %H:%M:%S"

Extend test cases

Assume a cal_item is also an acs_object

Qualify source tables in query

Extend testing of data validation

strengthen boolean parameters in page contracts

  1. … 26 more files in changeset.
bumped version numbers to 5.10.1b1

  1. … 85 more files in changeset.
regenerated documentation

  1. … 295 more files in changeset.
Revert latest changes: the root cause was found to be in downstream-only code

  1. … 3 more files in changeset.
Cleanup empty strings from the id list

Prefer an idiom that will tolerate the empty string among the id values

Fix for define_function_args for cal_item__new

- Define always SQL function with the longest argument list

- Bumped version number to 2.10.1d7

file upgrade-2.10.1d6-2.10.1d7.sql was initially added on branch oacs-5-10.

    • -0
    • +0
Prefer cached api

  1. … 1 more file in changeset.
Name the form in a way that it will be de-facto unique on the page and multiple instances of the same portlet can be rendered together

Modernize idiom

State new dependencies

  1. … 1 more file in changeset.
Use new feature for dt_get_info to retrieve variables in a way that we know what is there and what not

Keep populating the event duration radio button according to the time settings

Provide package_id to the api explicitly

Cleanup unused variables

Cleanup reference to non-existent parameter

Test checking for attachments availability by providing explicit package_id

Do not require a connection context to determine whether attachments are enabled on a certain package and provide explicit available information instead

Make sure the cal item notification has at least 1 subscriber

Use a test admin user to run the ics test

Fix typos

Make calendar::get_month_multirow_information private: its purpose is very specific to the usage in the month view

Deprecate calendar::assign_permissions, trivial wrapper to the permission api