OpenACS / openacs-4 / packages

calendar

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 51
Last Commit: 14:41
Commits this week: 0
Total Lines of Code (LoC): 15,886
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 04 Mar
4:46 pm

antoniop

Harden page contracts

Options
    • -2
    • +16
    ./www/cal-item-new.tcl
    • -2
    • +2
    ./www/cal-item-view.tcl
Wednesday 31 Jan
11:27 am

antoniop

Replace permission::require_write_permission with permission::require_permission across the calendar package

Rationale: permission::require_write_permission assumes the object creator to have write permission on the object. Instead, we should rely on permissions to be set correctly on the calendar. permission::require_write_permission also performs an additional query to retrieve the object creator.

It is unclear whether permission::require_write_permission makes sense at all as an api, but we leave this to a future post-release reform.

Options
    • -2
    • +2
    ./calendar.info
    • -6
    • +25
    ./www/cal-item-new.tcl
    • -3
    • +11
    ./www/cal-item-view.tcl
Tuesday 30 Jan
4:54 pm

antoniop

Test cornercase encountered in practice: a user claims a timezone different to that of the system and creates a calendar item in various formats

This test currently fails, because when we convert the time between the user and the system timezone, we are too strict and allow only the "long" timestamp format "%Y-%m-%d %H:%M:%S"

Options
    • -0
    • +70
    ./tcl/test/cal-item-procs.tcl
2:41 pm

antoniop

Extend test cases

Options
    • -0
    • +3
    ./tcl/test/cal-item-procs.tcl
11:56 am

antoniop

Assume a cal_item is also an acs_object

Options
    • -2
    • +2
    ./tcl/cal-item-procs.xql
11:46 am

antoniop

Qualify source tables in query

Options
    • -4
    • +4
    ./tcl/cal-item-procs.xql
11:36 am

antoniop

Extend testing of data validation

Options
    • -0
    • +63
    ./tcl/test/cal-item-procs.tcl
Sunday 22 Oct 2023
6:30 pm

gustafn

strengthen boolean parameters in page contracts

Options
    • -1
    • +1
    ./www/cal-item-delete.tcl
    • -1
    • +1
    ./www/view-list-display.tcl
    • -1
    • +1
    ./www/view-month-display.tcl
    • -1
    • +1
    ./www/view-print-display.tcl
    • -1
    • +1
    ./www/view-week-display.tcl
    • -3
    • +3
    ./www/view-one-day-display.tcl
  7. … 26 more files in changeset.
Thursday 13 Jul 2023
3:09 pm

gustafn

bumped version numbers to 5.10.1b1

Options
    • -9
    • +9
    ./calendar.info
  2. … 85 more files in changeset.
2:43 pm

gustafn

regenerated documentation

Options
    • -4
    • +5
    ./www/doc/requirements.adp
  2. … 295 more files in changeset.
Tuesday 06 Jun 2023
4:37 pm

antoniop

Revert latest changes: the root cause was found to be in downstream-only code

Options
    • -6
    • +1
    ./tcl/calendar-procs.tcl
  2. … 3 more files in changeset.
3:25 pm

antoniop

Cleanup empty strings from the id list

Options
    • -1
    • +6
    ./tcl/calendar-procs.tcl
2:57 pm

antoniop

Prefer an idiom that will tolerate the empty string among the id values

Options
    • -1
    • +1
    ./tcl/calendar-procs.xql
Monday 29 May 2023
11:45 am

gustafn

Fix for define_function_args for cal_item__new

- Define always SQL function with the longest argument list

- Bumped version number to 2.10.1d7

Options
    • -2
    • +2
    ./calendar.info
    • -2
    • +2
    ./sql/postgresql/cal-item-create.sql
    • -0
    • +2
    ./sql/postgresql/upgrade/upgrade-2.10.1d6-2.10.1d7.sql
11:45 am

gustafn

file upgrade-2.10.1d6-2.10.1d7.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-2.10.1d6-2.10.1d7.sql
Friday 14 Apr 2023
4:03 pm

antoniop

Prefer cached api

Options
    • -4
    • +5
    ./tcl/calendar-procs.tcl
  2. … 1 more file in changeset.
Thursday 30 Mar 2023
5:17 pm

antoniop

Name the form in a way that it will be de-facto unique on the page and multiple instances of the same portlet can be rendered together

Options
    • -1
    • +1
    ./www/mini-calendar.adp
    • -1
    • +7
    ./www/mini-calendar.tcl
    • -1
    • +1
    ./www/view-list-display.adp
    • -1
    • +7
    ./www/view-list-display.tcl
Wednesday 29 Mar 2023
3:50 pm

antoniop

Modernize idiom

Options
    • -10
    • +5
    ./www/view-list-display.tcl
Friday 24 Mar 2023
4:21 pm

antoniop

State new dependencies

Options
    • -3
    • +3
    ./calendar.info
  2. … 1 more file in changeset.
Thursday 23 Mar 2023
6:12 pm

antoniop

Use new feature for dt_get_info to retrieve variables in a way that we know what is there and what not

Options
    • -8
    • +12
    ./www/mini-calendar.tcl
    • -1
    • +1
    ./www/view-month-display.adp
    • -7
    • +7
    ./www/view-month-display.tcl
Tuesday 28 Feb 2023
10:28 am

antoniop

Keep populating the event duration radio button according to the time settings

Options
    • -1
    • +3
    ./www/cal-item-new.tcl
Friday 24 Feb 2023
2:04 pm

antoniop

Provide package_id to the api explicitly

Options
    • -2
    • +2
    ./www/cal-item-view.tcl
2:03 pm

antoniop

Cleanup unused variables

Options
    • -4
    • +1
    ./www/cal-item-view.tcl
2:02 pm

antoniop

Cleanup reference to non-existent parameter

Options
    • -2
    • +1
    ./www/cal-item-view.tcl
1:53 pm

antoniop

Test checking for attachments availability by providing explicit package_id

Options
    • -2
    • +10
    ./tcl/test/calendar-procs.tcl
1:53 pm

antoniop

Do not require a connection context to determine whether attachments are enabled on a certain package and provide explicit available information instead

Options
    • -7
    • +6
    ./tcl/cal-item-procs.tcl
    • -43
    • +0
    ./tcl/cal-item-procs.xql
    • -3
    • +20
    ./tcl/calendar-procs.tcl
Wednesday 22 Feb 2023
4:55 pm

antoniop

Make sure the cal item notification has at least 1 subscriber

Options
    • -4
    • +21
    ./tcl/test/cal-item-procs.tcl
1:06 pm

antoniop

Use a test admin user to run the ics test

Options
    • -3
    • +7
    ./tcl/test/cal-item-procs.tcl
Monday 20 Feb 2023
10:55 am

antoniop

Fix typos

Options
    • -4
    • +4
    ./tcl/test/cal-item-procs.tcl
Wednesday 15 Feb 2023
4:31 pm

antoniop

Make calendar::get_month_multirow_information private: its purpose is very specific to the usage in the month view

Options
    • -2
    • +2
    ./tcl/calendar-procs.tcl